Skip to content

Commit 7f837d3

Browse files
authored
Chat: unskip and fix unstable test with ScrollView integration (DevExpress#29664)
1 parent 5af607a commit 7f837d3

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

packages/devextreme/testing/tests/DevExpress.performance/widgetsRenderStyleRecalculations.tests.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ const components = [
9494
{ name: 'dxSelectBox', config: { labelMode: 'outside' }, expectedRecalculations: 1 },
9595
{ name: 'dxSelectBox', config: { label: 'Label', labelMode: 'hidden' }, expectedRecalculations: 1 },
9696
// { name: 'dxSelectBox', config: { label: 'Label', labelMode: 'static' }, expectedRecalculations: 2 },
97-
// TODO Chrome133: skipped during chrome update
9897
// { name: 'dxSelectBox', config: { label: 'Label', labelMode: 'floating' }, expectedRecalculations: 2 },
9998
{ name: 'dxSelectBox', config: { label: 'Label', labelMode: 'outside' }, expectedRecalculations: 1 },
10099

packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/messageList.tests.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1178,8 +1178,7 @@ QUnit.module('MessageList', () => {
11781178
});
11791179
});
11801180

1181-
// TODO Chrome133: skipped during chrome update
1182-
QUnit.test.skip('should not be scroll down if typingUsers changed at runtime if scroll position not at the bottom', function(assert) {
1181+
QUnit.test('should not be scroll down if typingUsers changed at runtime if scroll position not at the bottom', function(assert) {
11831182
const done = assert.async();
11841183

11851184
this.reinit({
@@ -1205,9 +1204,9 @@ QUnit.module('MessageList', () => {
12051204

12061205
assert.roughEqual(scrollTop, scrollTopBefore, 1, 'scroll position should remain the same after updating typingUsers when not at the bottom');
12071206
done();
1208-
});
1209-
});
1210-
});
1207+
}, this._resizeTimeout);
1208+
}, this._resizeTimeout);
1209+
}, this._resizeTimeout);
12111210
});
12121211

12131212
QUnit.test('should be scroll down if typingUsers changed at runtime, provided the content does not overflow before the typing indicator is displayed', function(assert) {
@@ -1398,9 +1397,9 @@ QUnit.module('MessageList', () => {
13981397
assert.notEqual(scrollTop, 0, 'scroll position should not be 0 after a new message is rendered');
13991398
assert.roughEqual(scrollTop, scrollTopBefore, 1, 'scroll position should be at the bottom after rendering the new message');
14001399
done();
1401-
});
1402-
});
1403-
});
1400+
}, this._resizeTimeout);
1401+
}, this._resizeTimeout);
1402+
}, this._resizeTimeout);
14041403
});
14051404

14061405
QUnit.test('should be scrolled down after showing if was initially rendered inside an invisible element', function(assert) {

0 commit comments

Comments
 (0)