Menu: remove toggle focus on hover (DevExpress#30603)

Author: anna-shakhova

packages/devextreme/js/__internal/ui/menu/menu.ts

@@ -11,7 +11,7 @@ import { noop } from '@js/core/utils/common';
 import { extend } from '@js/core/utils/extend';
 import { each } from '@js/core/utils/iterator';
 import { getOuterWidth } from '@js/core/utils/size';
-import { isDefined, isObject, isPlainObject } from '@js/core/utils/type';
+import { isDefined, isObject } from '@js/core/utils/type';
 import type { DxEvent, EventInfo } from '@js/events';
 import Button from '@js/ui/button';
 import type dxMenuBase from '@js/ui/context_menu/ui.menu_base';
@@ -406,50 +406,47 @@ class Menu extends MenuBase<MenuProperties> {
     this._hamburger = new Button($('<div>').addClass(DX_ADAPTIVE_HAMBURGER_BUTTON_CLASS), {
       icon: 'menu',
       activeStateEnabled: false,
-      onClick: this._toggleTreeView.bind(this),
+      onClick: (): void => {
+        this._toggleTreeView();
+      },
     });
 
     return this._hamburger.$element();
   }
 
-  _toggleTreeView(state: boolean): void {
-    if (isPlainObject(state)) {
-      const { visible } = this._overlay?.option() ?? {};
-
-      // eslint-disable-next-line no-param-reassign
-      state = !visible;
-    }
+  _toggleTreeView(visible?: boolean): void {
+    const isTreeViewVisible = visible ?? !this._overlay?.option()?.visible;
 
-    this._overlay?.option('visible', state);
+    this._overlay?.option('visible', isTreeViewVisible);
 
-    if (state) {
+    if (isTreeViewVisible) {
       this._treeView?.focus();
     }
-    this._toggleHamburgerActiveState(state);
+    this._toggleHamburgerActiveState(isTreeViewVisible);
   }
 
   _toggleHamburgerActiveState(isActive: boolean): void {
     this._hamburger?.$element().toggleClass(DX_STATE_ACTIVE_CLASS, isActive);
   }
 
-  _toggleAdaptiveMode(state: boolean): void {
+  _toggleAdaptiveMode(isAdaptive: boolean): void {
     const $menuItemsContainer = this.$element().find(`.${DX_MENU_HORIZONTAL_CLASS}`);
     const $adaptiveElements = this.$element().find(`.${DX_ADAPTIVE_MODE_CLASS}`);
 
-    if (state) {
+    if (isAdaptive) {
       this._hideVisibleSubmenu();
     } else {
       this._treeView?.collapseAll();
       if (this._overlay) {
-        this._toggleTreeView(state);
+        this._toggleTreeView(isAdaptive);
       }
     }
 
-    this._setAriaRole(state);
+    this._setAriaRole(isAdaptive);
     // @ts-expect-error ts-error
-    $menuItemsContainer.toggle(!state);
+    $menuItemsContainer.toggle(!isAdaptive);
     // @ts-expect-error ts-error
-    $adaptiveElements.toggle(state);
+    $adaptiveElements.toggle(isAdaptive);
   }
 
   _removeAdaptivity(): void {
@@ -1158,10 +1155,7 @@ class Menu extends MenuBase<MenuProperties> {
       return submenu;
     }
 
-    // eslint-disable-next-line no-param-reassign
-    itemData = itemData ?? this._getItemData($itemElement) as Item;
-
-    const node = this._dataAdapter.getNodeByItem(itemData);
+    const node = this._dataAdapter.getNodeByItem(itemData ?? this._getItemData($itemElement));
 
     if (node && this._hasChildren(node)) {
       return this._renderSubmenuItems(node, $itemElement);

packages/devextreme/js/__internal/ui/menu/submenu.ts

@@ -111,8 +111,6 @@ class Submenu extends ContextMenu<SubmenuProperties> {
 
     onHoverStart?.(e);
     super._hoverStartHandler(e);
-    // @ts-expect-error ts-error
-    this._toggleFocusClass(true, e.currentTarget);
   }
 
   _drawSubmenu($rootItem: dxElementWrapper): void {