RangeSelector: remove depecated callValueChanged (DevExpress#30115)

Author: anna-shakhova

packages/devextreme-angular/src/ui/nested/behavior.ts

@@ -15,7 +15,6 @@ import {
 
 
 import { SliderValueChangeMode } from 'devextreme/common';
-import { ValueChangedCallMode } from 'devextreme/viz/range_selector';
 
 import {
     DxIntegrationModule,
@@ -49,14 +48,6 @@ export class DxoBehaviorComponent extends NestedOption implements OnDestroy, OnI
         this._setOption('animationEnabled', value);
     }
 
-    @Input()
-    get callValueChanged(): ValueChangedCallMode {
-        return this._getOption('callValueChanged');
-    }
-    set callValueChanged(value: ValueChangedCallMode) {
-        this._setOption('callValueChanged', value);
-    }
-
     @Input()
     get manualRangeSelectionEnabled(): boolean {
         return this._getOption('manualRangeSelectionEnabled');

packages/devextreme-angular/src/ui/range-selector/index.ts

@@ -24,7 +24,7 @@ import {
 
 import DataSource from 'devextreme/data/data_source';
 import * as CommonChartTypes from 'devextreme/common/charts';
-import { BackgroundImageLocation, ValueChangedCallMode, ChartAxisScale, DisposingEvent, DrawnEvent, ExportedEvent, ExportingEvent, FileSavingEvent, IncidentOccurredEvent, InitializedEvent, OptionChangedEvent, ValueChangedEvent, AxisScale } from 'devextreme/viz/range_selector';
+import { BackgroundImageLocation, ChartAxisScale, DisposingEvent, DrawnEvent, ExportedEvent, ExportingEvent, FileSavingEvent, IncidentOccurredEvent, InitializedEvent, OptionChangedEvent, ValueChangedEvent, AxisScale } from 'devextreme/viz/range_selector';
 import { SliderValueChangeMode, ExportFormat, HorizontalAlignment, VerticalEdge } from 'devextreme/common';
 import { dxChartCommonSeriesSettings } from 'devextreme/viz/chart';
 import { Palette, PaletteExtensionMode, ChartsDataType, Font, TimeInterval, ScaleBreak, ScaleBreakLineStyle, DiscreteAxisDivisionMode, LabelOverlap, VisualRangeUpdateMode, Theme, TextOverflow, WordWrap } from 'devextreme/common/charts';
@@ -231,10 +231,10 @@ export class DxRangeSelectorComponent extends DxComponent implements OnDestroy,
     
      */
     @Input()
-    get behavior(): { allowSlidersSwap?: boolean, animationEnabled?: boolean, callValueChanged?: ValueChangedCallMode, manualRangeSelectionEnabled?: boolean, moveSelectedRangeByClick?: boolean, snapToTicks?: boolean, valueChangeMode?: SliderValueChangeMode } {
+    get behavior(): { allowSlidersSwap?: boolean, animationEnabled?: boolean, manualRangeSelectionEnabled?: boolean, moveSelectedRangeByClick?: boolean, snapToTicks?: boolean, valueChangeMode?: SliderValueChangeMode } {
         return this._getOption('behavior');
     }
-    set behavior(value: { allowSlidersSwap?: boolean, animationEnabled?: boolean, callValueChanged?: ValueChangedCallMode, manualRangeSelectionEnabled?: boolean, moveSelectedRangeByClick?: boolean, snapToTicks?: boolean, valueChangeMode?: SliderValueChangeMode }) {
+    set behavior(value: { allowSlidersSwap?: boolean, animationEnabled?: boolean, manualRangeSelectionEnabled?: boolean, moveSelectedRangeByClick?: boolean, snapToTicks?: boolean, valueChangeMode?: SliderValueChangeMode }) {
         this._setOption('behavior', value);
     }
 
@@ -621,7 +621,7 @@ export class DxRangeSelectorComponent extends DxComponent implements OnDestroy,
      * This member supports the internal infrastructure and is not intended to be used directly from your code.
     
      */
-    @Output() behaviorChange: EventEmitter<{ allowSlidersSwap?: boolean, animationEnabled?: boolean, callValueChanged?: ValueChangedCallMode, manualRangeSelectionEnabled?: boolean, moveSelectedRangeByClick?: boolean, snapToTicks?: boolean, valueChangeMode?: SliderValueChangeMode }>;
+    @Output() behaviorChange: EventEmitter<{ allowSlidersSwap?: boolean, animationEnabled?: boolean, manualRangeSelectionEnabled?: boolean, moveSelectedRangeByClick?: boolean, snapToTicks?: boolean, valueChangeMode?: SliderValueChangeMode }>;
 
     /**
     

packages/devextreme-angular/src/ui/range-selector/nested/behavior.ts

@@ -14,7 +14,6 @@ import {
 
 
 
-import { ValueChangedCallMode } from 'devextreme/viz/range_selector';
 import { SliderValueChangeMode } from 'devextreme/common';
 
 import {
@@ -49,14 +48,6 @@ export class DxoRangeSelectorBehaviorComponent extends NestedOption implements O
         this._setOption('animationEnabled', value);
     }
 
-    @Input()
-    get callValueChanged(): ValueChangedCallMode {
-        return this._getOption('callValueChanged');
-    }
-    set callValueChanged(value: ValueChangedCallMode) {
-        this._setOption('callValueChanged', value);
-    }
-
     @Input()
     get manualRangeSelectionEnabled(): boolean {
         return this._getOption('manualRangeSelectionEnabled');

packages/devextreme-react/src/range-selector.ts

@@ -8,7 +8,7 @@ import dxRangeSelector, {
 import { Component as BaseComponent, IHtmlOptions, ComponentRef, NestedComponentMeta } from "./core/component";
 import NestedOption from "./core/nested-option";
 
-import type { DisposingEvent, DrawnEvent, ExportedEvent, ExportingEvent, FileSavingEvent, IncidentOccurredEvent, InitializedEvent, ValueChangedEvent, BackgroundImageLocation, ValueChangedCallMode, ChartAxisScale, AxisScale } from "devextreme/viz/range_selector";
+import type { DisposingEvent, DrawnEvent, ExportedEvent, ExportingEvent, FileSavingEvent, IncidentOccurredEvent, InitializedEvent, ValueChangedEvent, BackgroundImageLocation, ChartAxisScale, AxisScale } from "devextreme/viz/range_selector";
 import type { chartPointAggregationInfoObject, chartSeriesObject, ChartSeriesAggregationMethod, dxChartCommonSeriesSettings, FinancialChartReductionLevel } from "devextreme/viz/chart";
 import type { Format as CommonFormat, SliderValueChangeMode, HorizontalAlignment, ExportFormat, VerticalEdge } from "devextreme/common";
 import type { Format as LocalizationFormat } from "devextreme/common/core/localization";
@@ -218,7 +218,6 @@ const BackgroundImage = Object.assign<typeof _componentBackgroundImage, NestedCo
 type IBehaviorProps = React.PropsWithChildren<{
   allowSlidersSwap?: boolean;
   animationEnabled?: boolean;
-  callValueChanged?: ValueChangedCallMode;
   manualRangeSelectionEnabled?: boolean;
   moveSelectedRangeByClick?: boolean;
   snapToTicks?: boolean;

packages/devextreme-vue/src/range-selector.ts

@@ -20,7 +20,6 @@ import {
  OptionChangedEvent,
  ValueChangedEvent,
  BackgroundImageLocation,
- ValueChangedCallMode,
  AxisScale,
  ChartAxisScale,
 } from "devextreme/viz/range_selector";
@@ -352,7 +351,6 @@ const DxBehaviorConfig = {
     "update:hoveredElement": null,
     "update:allowSlidersSwap": null,
     "update:animationEnabled": null,
-    "update:callValueChanged": null,
     "update:manualRangeSelectionEnabled": null,
     "update:moveSelectedRangeByClick": null,
     "update:snapToTicks": null,
@@ -361,7 +359,6 @@ const DxBehaviorConfig = {
   props: {
     allowSlidersSwap: Boolean,
     animationEnabled: Boolean,
-    callValueChanged: String as PropType<ValueChangedCallMode>,
     manualRangeSelectionEnabled: Boolean,
     moveSelectedRangeByClick: Boolean,
     snapToTicks: Boolean,

packages/devextreme/js/viz/range_selector.d.ts

@@ -191,12 +191,6 @@ export interface dxRangeSelectorOptions extends BaseWidgetOptions<dxRangeSelecto
        * @default true
        */
       animationEnabled?: boolean;
-      /**
-       * @docid
-       * @default 'onMovingComplete'
-       * @deprecated
-       */
-      callValueChanged?: ValueChangedCallMode;
       /**
        * @docid
        * @default true

packages/devextreme/js/viz/range_selector/range_selector.js

@@ -563,7 +563,6 @@ const dxRangeSelector = baseWidgetModule.inherit({
     _setDeprecatedOptions() {
         this.callBase();
         extend(this._deprecatedOptions, {
-            'behavior.callValueChanged': { since: '23.1', message: 'Use the "behavior.valueChangeMode" property instead' },
             'scale.aggregateByCategory': { since: '23.1', message: 'Use the aggregation.enabled property' }
         });
     },

packages/devextreme/js/viz/range_selector/sliders_controller.js

@@ -120,7 +120,7 @@ SlidersController.prototype = {
         that._shutterOffset = sliderHandleOptions.width / 2;
         that._updateSelectedView(shutterOptions, selectedRangeColor);
 
-        that._isOnMoving = _normalizeEnum(behavior.valueChangeMode) === 'onhandlemove' || _normalizeEnum(behavior.callValueChanged) === 'onmoving';
+        that._isOnMoving = _normalizeEnum(behavior.valueChangeMode) === 'onhandlemove';
 
         that._updateSelectedRange();
         // This is placing sliders and shutter into initial position. They all will be animated from that position when "setSelectedRange" is called.

packages/devextreme/testing/tests/DevExpress.viz.rangeSelector/common_new.tests.js

@@ -126,27 +126,6 @@ QUnit.test('RangeSelector should change the aggregatebycategory value when the v
     assert.strictEqual(axisOptions.aggregateByCategory, false);
 });
 
-QUnit.test('Should show warning if deprecated "behavior.callValueChanged" property is used', function(assert) {
-    sinon.spy(errors, 'log');
-
-    try {
-        this.$container.dxRangeSelector({
-            behavior: {
-                callValueChanged: 'onMoving'
-            }
-        });
-        assert.deepEqual(errors.log.lastCall.args, [
-            'W0001',
-            'dxRangeSelector',
-            'behavior.callValueChanged',
-            '23.1',
-            'Use the "behavior.valueChangeMode" property instead'
-        ]);
-    } finally {
-        errors.log.restore();
-    }
-});
-
 QUnit.test('Should show warning if deprecated "argumentAxis.aggregateByCategory" property is used', function(assert) {
     sinon.spy(errors, 'log');
 

packages/devextreme/ts/dx.all.d.ts

@@ -42882,11 +42882,6 @@ declare module DevExpress.viz {
        * [descr:dxRangeSelectorOptions.behavior.animationEnabled]
        */
       animationEnabled?: boolean;
-      /**
-       * [descr:dxRangeSelectorOptions.behavior.callValueChanged]
-       * @deprecated [depNote:dxRangeSelectorOptions.behavior.callValueChanged]
-       */
-      callValueChanged?: DevExpress.viz.dxRangeSelector.ValueChangedCallMode;
       /**
        * [descr:dxRangeSelectorOptions.behavior.manualRangeSelectionEnabled]
        */