Sankey: remove deprecated Node title (DevExpress#30106)

Author: anna-shakhova

packages/devextreme/js/__internal/viz/core/themes/generic/light/sankey.ts

@@ -29,8 +29,8 @@ export default {
         width: 2,
         color: WHITE,
       },
-      customizeText(info: { title: string }): string {
-        return info.title;
+      customizeText(info: { label: string }): string {
+        return info.label;
       },
       shadow: {
         opacity: 0.2,

packages/devextreme/js/viz/sankey.d.ts

@@ -748,12 +748,6 @@ export interface dxSankeyNode {
      * @public
      */
     showTooltip(): void;
-    /**
-     * @docid
-     * @deprecated dxSankeyNode.label
-     * @public
-     */
-    title?: string;
 }
 
 /** @public */

packages/devextreme/js/viz/sankey/node_item.js

@@ -58,7 +58,7 @@ function Node(widget, params) {
     that.color = params.color;
     that.options = params.options;
     that.rect = params.rect;
-    that.label = that.title = params.rect._name;
+    that.label = params.rect._name;
     that.coords = {
         x: params.rect.x + params.rect.width / 2 + widgetOffset.left,
         y: params.rect.y + params.rect.height / 2 + widgetOffset.top

packages/devextreme/testing/tests/DevExpress.viz.sankey/sankey.base.tests.js

@@ -468,7 +468,7 @@ QUnit.test('Returning correct nodes[].linksIn and nodes[].linksOut data in getAl
 
     assert.equal(nodes.length, 5);
     ['A', 'B', 'C', 'M', 'Y'].forEach(function(nodeName) {
-        const node = find(nodes, function(node) { return node.title === nodeName; });
+        const node = find(nodes, function(node) { return node.label === nodeName; });
         assert.equal(node.linksIn.length, expected[nodeName][0]);
         assert.equal(node.linksOut.length, expected[nodeName][1]);
     });
@@ -630,7 +630,7 @@ QUnit.test('Largest cascade occupies full chart height', function(assert) {
     let cascadeHeight = 0;
 
     ['A', 'B', 'C'].forEach(function(nodeName) {
-        const node = find(nodes, function(node) { return node.title === nodeName; });
+        const node = find(nodes, function(node) { return node.label === nodeName; });
         cascadeHeight += node.rect.height + (nodeName !== 'C' ? 30 : 0);
     });
 
@@ -645,7 +645,7 @@ QUnit.test('Default align option', function(assert) {
     const nodes = sankey.getAllNodes();
 
     ['M', 'Y'].forEach(function(nodeName) {
-        const node = find(nodes, function(node) { return node.title === nodeName; });
+        const node = find(nodes, function(node) { return node.label === nodeName; });
         assert.equal(node.rect.y + node.rect.height / 2, size.height / 2, nodeName + ' aligned to middle');
     });
 });
@@ -659,7 +659,7 @@ QUnit.test('Align option as <String>', function(assert) {
     const nodes = sankey.getAllNodes();
 
     ['C', 'M', 'Y'].forEach(function(nodeName) {
-        const node = find(nodes, function(node) { return node.title === nodeName; });
+        const node = find(nodes, function(node) { return node.label === nodeName; });
         assert.equal(node.rect.y + node.rect.height, size.height, nodeName + ' aligned to bottom');
     });
 });
@@ -672,7 +672,7 @@ QUnit.test('Align option as <Array>', function(assert) {
     const nodes = sankey.getAllNodes();
 
     ['A', 'M', 'Y'].forEach(function(nodeName) {
-        const node = find(nodes, function(node) { return node.title === nodeName; });
+        const node = find(nodes, function(node) { return node.label === nodeName; });
         assert.equal(node.rect.y, 0, nodeName + ' aligned to top');
     });
 
@@ -687,7 +687,7 @@ QUnit.test('Default alignment value for cascade which is not mentioned in option
         alignment: ['top']
     });
     const nodes = sankey.getAllNodes();
-    const node = find(nodes, function(node) { return node.title === 'Z'; });
+    const node = find(nodes, function(node) { return node.label === 'Z'; });
 
     // 'Z' is expected to be centered
     assert.equal(node.rect.y, 15, 'Z aligned to center');
@@ -786,8 +786,8 @@ QUnit.test('SortData option', function(assert) {
     sankey.option({ sortData: { A: 2, B: 1 } });
     const nodesSorted = sankey.getAllNodes();
 
-    assert.equal(nodesSorted[0].title, 'B');
-    assert.equal(nodesSorted[1].title, 'A');
+    assert.equal(nodesSorted[0].label, 'B');
+    assert.equal(nodesSorted[1].label, 'A');
 });
 
 QUnit.test('Align option updated as <String>', function(assert) {
@@ -801,7 +801,7 @@ QUnit.test('Align option updated as <String>', function(assert) {
     const nodes = sankey.getAllNodes();
 
     ['C', 'M', 'Y'].forEach(function(nodeName) {
-        const node = find(nodes, function(node) { return node.title === nodeName; });
+        const node = find(nodes, function(node) { return node.label === nodeName; });
         assert.equal(node.rect.y + node.rect.height, size.height, 'aligned to bottom');
     });
 });
@@ -816,7 +816,7 @@ QUnit.test('Align option updated as <Array>', function(assert) {
     const nodes = sankey.getAllNodes();
 
     ['A', 'M', 'Y'].forEach(function(nodeName) {
-        const node = find(nodes, function(node) { return node.title === nodeName; });
+        const node = find(nodes, function(node) { return node.label === nodeName; });
         assert.equal(node.rect.y, 0, 'aligned to top');
     });
 });

packages/devextreme/testing/tests/DevExpress.viz.sankey/sankey.items.node.tests.js

@@ -24,19 +24,19 @@ QUnit.test('Creation', function(assert) {
     });
     const nodes = sankey.getAllNodes();
 
-    assert.equal(nodes[0].title, 'A');
+    assert.equal(nodes[0].label, 'A');
     assert.equal(nodes[0].linksIn.length, 0);
     assert.equal(nodes[0].linksOut.length, 1);
     assert.equal(nodes[0].linksOut[0].weight, 1);
     assert.equal(nodes[0].linksOut[0].node, 'Z');
 
-    assert.equal(nodes[1].title, 'B');
+    assert.equal(nodes[1].label, 'B');
     assert.equal(nodes[1].linksIn.length, 0);
     assert.equal(nodes[1].linksOut.length, 1);
     assert.equal(nodes[1].linksOut[0].weight, 1);
     assert.equal(nodes[1].linksOut[0].node, 'Z');
 
-    assert.equal(nodes[2].title, 'Z');
+    assert.equal(nodes[2].label, 'Z');
     assert.equal(nodes[2].linksIn.length, 2);
     assert.equal(nodes[2].linksIn[0].weight, 1);
     assert.equal(nodes[2].linksIn[0].node, 'A');
@@ -53,7 +53,7 @@ QUnit.test('Passing nodes[].rect coordinates to SVG', function(assert) {
     const nodesSVG = this.nodes();
 
     ['A', 'B', 'Z'].forEach(function(nodeName) {
-        const nodeItem = find(nodes, function(n) { return n.title === nodeName; });
+        const nodeItem = find(nodes, function(n) { return n.label === nodeName; });
         const nodeSVG = find(nodesSVG, function(node) { return node.attr.firstCall.args[0]._name === nodeName; });
         assert.deepEqual(nodeSVG.attr.firstCall.args[0], nodeItem.rect, 'Node ' + nodeName + ': rectangles match');
     });

packages/devextreme/testing/tests/DevExpress.viz.sankey/sankey.label.tests.js

@@ -149,7 +149,7 @@ QUnit.test('Label color if useNodeColors set to true', function(assert) {
 QUnit.test('Labels customize text', function(assert) {
 
     const customizeText = function(node) {
-        return 'test text ' + node.title;
+        return 'test text ' + node.label;
     };
 
     createSankey({

packages/devextreme/ts/dx.all.d.ts

@@ -43601,11 +43601,6 @@ declare module DevExpress.viz {
      * [descr:dxSankeyNode.showTooltip()]
      */
     showTooltip(): void;
-    /**
-     * [descr:dxSankeyNode.title]
-     * @deprecated [depNote:dxSankeyNode.title]
-     */
-    title?: string;
   }
   /**
    * [descr:dxSankeyOptions]