Fix PHP-8 Compatibility and Translation (#447)

* fix: Fixed PHP-8 deprecation warning for Singletonable

* fix: Fixed translation issue and spacing

* fix: Remove __wakeup method as it's not necessary more

* 🐛 FIX: Some deprecated warnings for support PHP-8

* 🤖 Chore: Fix release command and composer allowed plugin list

Author: ManiruzzamanAkash

composer.json

@@ -42,5 +42,11 @@
         "dealerdirect/phpcodesniffer-composer-installer": "^0.7.0",
         "phpcompatibility/phpcompatibility-wp": "2.1.0",
         "wp-coding-standards/wpcs": "^2.3.0"
+    },
+    "config": {
+        "allow-plugins": {
+            "kylekatarnls/update-helper": true,
+            "dealerdirect/phpcodesniffer-composer-installer": true
+        }
     }
 }

core/Singletonable.php

@@ -76,7 +76,7 @@ protected function apply_callables( array $callables = [] ) {
 
             if ( method_exists( $this, $method ) ) {
 
-                if ( property_exists( $this, $property ) ) {
+                if ( ! empty( $property ) && property_exists( $this, $property ) ) {
                     $this->$property = call_user_func_array(
                         array( $this, $method ),
                         $params
@@ -105,16 +105,6 @@ protected function __construct() {
     private function __clone() {
 
     }
-
-    /**
-     * Private unserialize method to prevent unserializing of the *Singleton*
-     * instance.
-     *
-     * @return void
-     */
-    private function __wakeup() {
-
-    }
 }
 
 //Example: singleton() first param

core/User_Profile/Profile_Update.php

@@ -106,10 +106,10 @@ protected function capbility_form( $user ) {
         <?php
     }
 
-    public function profile_update( $user_id = 0, $prev_data ) {
+    public function profile_update( $user_id, $prev_data ) {
         if (
             ! isset( $_POST['pm_profile_nonce'] )
-                ||
+            ||
             ! wp_verify_nonce( sanitize_text_field( wp_unslash( $_POST['pm_profile_nonce'] ) ), 'pm_nonce' )
         ) {
             return;
@@ -121,6 +121,8 @@ public function profile_update( $user_id = 0, $prev_data ) {
             return;
         }
 
+        $user_id = empty( $user_id ) ? 0 : absint( $user_id );
+
         $this->update_user_capability( $user_id, $cap_key );
 
         do_action( 'pm_update_profile', $user_id, $prev_data );

libs/functions.php

@@ -662,8 +662,8 @@ function pm_filter_content_url( $content ) {
     return $content;
 }
 
-function pm_get_user_url( $user_id = false, $is_admin ) {
-    $user_id = $user_id ? $user_id : get_current_user_id();
+function pm_get_user_url( $user_id, $is_admin ) {
+    $user_id = ! empty( $user_id ) ? $user_id : get_current_user_id();
 
     $is_admin = $is_admin ? 'admin' : 'frontend';
     $pm_base  = pm_get_project_page($is_admin);

package.json

@@ -9,7 +9,7 @@
   "scripts": {
     "start": "webpack --progress --colors --watch",
     "build": "cross-env NODE_ENV=production webpack --progress --colors ",
-    "release": "webpack --progress --colors gurnt zip",
+    "release": "webpack --progress --colors grunt zip",
     "makepot": "wpvuei18n makepot"
   },
   "repository": {

src/Task_List/Controllers/Task_List_Controller.php

@@ -595,13 +595,17 @@ public function list_search( WP_REST_Request $request ) {
         return $this->get_response( $resource );
     }
 
-    public function get_lists_tasks_count( $list_ids = [], $project_id, $filter_params = [] ) {
+    public function get_lists_tasks_count( $list_ids, $project_id, $filter_params = [] ) {
         global $wpdb;
 
         if ( empty( $list_ids ) ) {
             $list_ids[] = 0;
         }
 
+        if ( ! is_array( $list_ids ) ) {
+            $list_ids = [];
+        }
+
         $tb_tasks     = pm_tb_prefix() . 'pm_tasks';
         $tb_lists     = pm_tb_prefix() . 'pm_boards';
         $tb_boardable = pm_tb_prefix() . 'pm_boardables';

views/assets/src/components/importtools/trello.vue

@@ -19,8 +19,8 @@
                                 <label for="">{{ __( 'Provide your App Key & Token', 'wedevs-project-manager') }}</label>
                             </div>
                             <div class="wpuf-int-field">
-                                <input id="app_key" name="app_key" placeholder="__('App Key', 'wedevs-project-manager' )" class="regular-text">
-                                <input id="app_token" name="app_token" placeholder="__('App Token', 'wedevs-project-manager' )" class="regular-text">
+                                <input id="app_key" name="app_key" :placeholder="__('App Key', 'wedevs-project-manager' )" class="regular-text">
+                                <input id="app_token" name="app_token" :placeholder="__('App Token', 'wedevs-project-manager' )" class="regular-text">
                             </div>
                             <div class="wpuf-int-field">
                                 <div v-if="trello.import_loader.length != 0">

views/assets/src/components/settings/email.vue

@@ -22,7 +22,7 @@
                                 <td>
                                     <fieldset>
                                         <label for="wpuf-pm_mails[email_url_link][backend]">
-                                            <input v-model="link_to_backend" type="checkbox" class="radio">{{ __( 'Link to Backend', 'wedevs-project-manager') }}
+                                            <input v-model="link_to_backend" type="checkbox" class="radio">&nbsp;{{ __( 'Link to Backend', 'wedevs-project-manager') }}
                                         </label>
                                         <br>
                                         <p class="description">{{ __( 'Select where do you want to take the user. Notification emails contain links.', 'wedevs-project-manager') }}