baufm_updater_cron_updates_check_action does not adhere to separation of concerns or OOP methods

[jeffreynolte]

@poweredbycoffee - I was recently looking through the code and noticed something I feel should be addressed ASAP.

baufm_updater_cron_updates_check_actionis not following separation of concerns

Ref: https://github.com/moxienyc/branded-auto-updats-for-mainwp/blob/9b1f676d7af3dfda7f6e38ce4136c6440dbbb5ff/includes/class.baufm-updater.php#L129

Please apply this methodology to this code. It will be helpful for another developer coming aboard or simply legibility and self documenting purposes.

@jeffreynolte I'm actually well aware of that part. But thanks for pointing out. A chunk of that code comes chiefly from MainWP's daily update method, with MainWP's source method being about two times bigger and harder to grok.

As much as I wan't to refactor codes which are inherited right away as I see them, that's not entirely the safe way to deal with integrating with existing systems. I have to resist the temptation to refactor right away, as I might introduce regressions elsewhere in MainWP without even knowing it. No worries, house keeping is always on my pipeline.

[jeffreynolte]

👍 Thanks @poweredbycoffee - I see how it is working now. Lets definitely keep an eye on MWP's base.