Fix types, add missing constants (#4)

* Fix types, add missing constants

* Add constant visibility

Co-authored-by: Dominik Schilling <dominikschilling+git@gmail.com>

Author: szepeviktor

.gitignore

@@ -1,2 +1,2 @@
 vendor
-composer.lock
+composer.lock

composer.json

@@ -28,5 +28,8 @@
     "psr-4": {
       "Required\\Common\\": "src"
     }
+  },
+  "require-dev": {
+    "szepeviktor/phpstan-wordpress": "^0.6.5"
   }
 }

phpstan.neon.dist

@@ -0,0 +1,7 @@
+includes:
+    - vendor/szepeviktor/phpstan-wordpress/extension.neon
+parameters:
+    level: max
+    inferPrivatePropertyTypeFromConstructor: true
+    paths:
+        - src/

src/Admin/AjaxAction.php

@@ -7,7 +7,7 @@
 
 namespace Required\Common\Admin;
 
-use Required\Common\Registrable;
+use Required\Common\Contracts\Registrable;
 
 /**
  * Class used to register Ajax actions.
@@ -16,6 +16,8 @@
  */
 abstract class AjaxAction implements Registrable {
 
+	public const ACTION = 'ajax-action';
+
 	/**
 	 * Whether the Ajax action can be called unauthenticated.
 	 *

src/Admin/Page.php

@@ -25,7 +25,7 @@ class Page implements Registrable {
 	 *
 	 * @var int
 	 */
-	const ADMIN = 1;
+	public const ADMIN = 1;
 
 	/**
 	 * Type of admin page.
@@ -36,7 +36,7 @@ class Page implements Registrable {
 	 *
 	 * @var int
 	 */
-	const ADMIN_NETWORK = 2;
+	public const ADMIN_NETWORK = 2;
 
 	/**
 	 * Type of admin page.
@@ -47,7 +47,7 @@ class Page implements Registrable {
 	 *
 	 * @var int
 	 */
-	const ADMIN_USER = 3;
+	public const ADMIN_USER = 3;
 
 	/**
 	 * Type of admin screen.

src/Admin/PostAction.php

@@ -7,7 +7,7 @@
 
 namespace Required\Common\Admin;
 
-use Required\Common\Registrable;
+use Required\Common\Contracts\Registrable;
 
 /**
  * Class used to register post/get actions.
@@ -16,6 +16,8 @@
  */
 abstract class PostAction implements Registrable {
 
+	public const ACTION = 'post-action';
+
 	/**
 	 * The callback of the action.
 	 *

src/PostType.php

@@ -16,6 +16,8 @@
  */
 abstract class PostType implements Registrable {
 
+	public const NAME = 'post';
+
 	/**
 	 * Creates a post type object.
 	 *

src/Shortcode.php

@@ -16,6 +16,8 @@
  */
 abstract class Shortcode implements Registrable {
 
+	public const TAG = 'shortcode';
+
 	/**
 	 * Shortcode view object.
 	 *

src/Taxonomy.php

@@ -16,6 +16,8 @@
  */
 abstract class Taxonomy implements Registrable {
 
+	public const NAME = 'category';
+
 	/**
 	 * Object types the taxonomy is associated with.
 	 *