Rename filter variables to start with verbs for better sorting

Author: dirkkul

src/Weaviate.Client.Tests/Integration/Datasets/Datasets.cs

@@ -196,12 +196,17 @@ public class DatasetFilteringReferences : TheoryData<string>
                     1
                 ),
                 ["RefPropertyLengthLessThan6"] = (
-                    Filter.Reference("ref").Property("name").Length().LessThan(6),
+                    Filter.Reference("ref").Property("name").HasLength().LessThan(6),
                     0
                 ),
                 ["RefIDEquals"] = (Filter.Reference("ref").ID.Equal(_reusableUuids[1]), 1),
                 ["IndirectSelfRefLengthLessThan6"] = (
-                    Filter.Reference("ref2").Reference("ref").Property("name").Length().LessThan(6),
+                    Filter
+                        .Reference("ref2")
+                        .Reference("ref")
+                        .Property("name")
+                        .HasLength()
+                        .LessThan(6),
                     2
                 ),
             };

src/Weaviate.Client.Tests/Unit/TestFilters.cs

@@ -142,7 +142,7 @@ public void FilterRequestCreatesProperGrpcMessage_4()
     public void Filter_Property_Length()
     {
         // Arrange
-        var f = Filter.Property("name").Length().Equal(5);
+        var f = Filter.Property("name").HasLength().Equal(5);
 
         var expected = new Filters()
         {
@@ -179,7 +179,7 @@ public void Filter_AllOf_And_AnyOf()
     {
         var uuid2 = Guid.NewGuid();
         var f1 = Filter.Property("uuids").ContainsAny(new[] { uuid2 });
-        var f2 = Filter.Property("name").Length().Equal(5);
+        var f2 = Filter.Property("name").HasLength().Equal(5);
 
         var expectedAllOf = f1 & f2;
         var expectedAnyOf = f1 | f2;

src/Weaviate.Client/Models/Filter.cs

@@ -280,7 +280,7 @@ internal PropertyFilter(string name)
         WithProperty(name);
     }
 
-    public TypedValue<int> Length()
+    public TypedValue<int> HasLength()
     {
         if (_target is null)
         {
@@ -334,11 +334,11 @@ public Filter IsLessThan<T>(T value) =>
     public Filter IsLessThanEqual<T>(T value) =>
         WithOperator(Filters.Types.Operator.LessThanEqual).WithValue(value);
 
-    public Filter WithinGeoRange(GeoCoordinate coord, float radius) =>
+    public Filter IsWithinGeoRange(GeoCoordinate coord, float radius) =>
         WithOperator(Filters.Types.Operator.WithinGeoRange)
             .WithValue(new GeoCoordinateConstraint(coord.Latitude, coord.Longitude, radius));
 
-    public Filter WithinGeoRange(GeoCoordinateConstraint value) =>
+    public Filter IsWithinGeoRange(GeoCoordinateConstraint value) =>
         WithOperator(Filters.Types.Operator.WithinGeoRange).WithValue(value);
 
     public Filter IsLike<T>(T value) => WithOperator(Filters.Types.Operator.Like).WithValue(value);

src/Weaviate.Client/Models/FilterExpression.cs

@@ -29,7 +29,8 @@ internal PropertyFilter(string name)
 
         public Filter LessThanEqual(TResult value) => _prop.IsLessThanEqual(value);
 
-        public Filter WithinGeoRange(GeoCoordinateConstraint value) => _prop.WithinGeoRange(value);
+        public Filter WithinGeoRange(GeoCoordinateConstraint value) =>
+            _prop.IsWithinGeoRange(value);
 
         public Filter Like(TResult value) => _prop.IsLike(value);