test(broken): use Array and List<?> filters

Server returns error:
UNKNOWN: explorer: get class: concurrentTargetVector
Search): explorer: get class: vector search: object vector search at index things: s
hard things_JlFtZoNmwIqT: build inverted filter allow list: nested query: nested cla
use at pos 1: expected value to be string, got '[]string'

Author: bevzzz

src/main/java/io/weaviate/client/v1/experimental/Batcher.java

@@ -73,7 +73,6 @@ public void add(T properties, String id, Float[] vector) {
 
     void append(ObjectsBatcher batcher) {
       for ($WeaviateObject<T> object : objects) {
-
         batcher.withObject(WeaviateObject.builder()
             .className(cls.getSimpleName() + "s")
             .vector(object.vector)

src/main/java/io/weaviate/client/v1/experimental/SearchOptions.java

@@ -6,6 +6,8 @@
 
 import org.apache.commons.lang3.StringUtils;
 
+import com.google.protobuf.util.JsonFormat;
+
 import io.weaviate.client.grpc.protocol.v1.WeaviateProtoBase.Filters;
 import io.weaviate.client.grpc.protocol.v1.WeaviateProtoSearchGet.MetadataRequest;
 import io.weaviate.client.grpc.protocol.v1.WeaviateProtoSearchGet.PropertiesRequest;
@@ -43,6 +45,10 @@ void append(SearchRequest.Builder search) {
       Filters.Builder filters = Filters.newBuilder();
       where.append(filters);
       search.setFilters(filters);
+      try {
+        System.out.println(JsonFormat.printer().print(filters));
+      } catch (Exception e) {
+      }
     }
 
     if (!returnMetadata.isEmpty()) {

src/main/java/io/weaviate/client/v1/experimental/Where.java

@@ -127,8 +127,21 @@ static Operand fromObject(Object value) {
         return new $Number((Number) value);
       } else if (value instanceof Date) {
         return new $Date((Date) value);
+      } else if (value instanceof String[]) {
+        return new $TextArray((String[]) value);
+      } else if (value instanceof Boolean[]) {
+        return new $BooleanArray((Boolean[]) value);
+      } else if (value instanceof Integer[]) {
+        return new $IntegerArray((Integer[]) value);
+      } else if (value instanceof Number[]) {
+        return new $NumberArray((Number[]) value);
+      } else if (value instanceof Date[]) {
+        return new $DateArray((Date[]) value);
       } else if (value instanceof List) {
-        assert ((List<?>) value).isEmpty() : "list must not be empty";
+        if (((List<?>) value).isEmpty()) {
+          throw new IllegalArgumentException(
+              "Filter with non-reifiable type (List<T>) cannot be empty, use an array instead");
+        }
 
         Object first = ((List<?>) value).get(0);
         if (first instanceof String) {
@@ -143,7 +156,8 @@ static Operand fromObject(Object value) {
           return new $DateArray((List<Date>) value);
         }
       }
-      throw new IllegalArgumentException("value must be either of String, Boolean, Date, Integer, Number, List");
+      throw new IllegalArgumentException(
+          "value must be either of String, Boolean, Date, Integer, Number, Array/List of these types");
     }
 
     // Equal

src/test/java/io/weaviate/integration/client/grpc/GRPCBenchTest.java

@@ -6,6 +6,7 @@
 
 import java.time.Instant;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Date;
 import java.util.HashMap;
 import java.util.List;
@@ -58,11 +59,14 @@ public class GRPCBenchTest {
   private static final Date NOW = Date.from(Instant.now());
 
   private static final int K = 10;
-  private static final Map<String, Object> filters = new HashMap<String, Object>() {
+  private static final String[] notIngredients = { "ketchup", "mayo" };
+  private static final Map<String, Object> notEqualFilters = new HashMap<String, Object>() {
     {
-      this.put("title", "SomeThing");
-      this.put("price", 8);
-      this.put("bestBefore", DateUtils.addDays(NOW, 5));
+      // this.put("title", "SomeThing");
+      // this.put("price", 8);
+      // this.put("bestBefore", DateUtils.addDays(NOW, 5));
+      this.put("ingredientsList", Arrays.asList(notIngredients));
+      this.put("ingredientsArray", notIngredients);
     }
   };
 
@@ -102,10 +106,10 @@ public void before() {
     assertTrue(writeORM(testData), "loaded test data successfully");
   }
 
-  @Test
+  // @Test
   public void testGraphQL() {
     bench("GraphQL", () -> {
-      int count = searchKNN(queryVector, K, filters, builder -> {
+      int count = searchKNN(queryVector, K, notEqualFilters, builder -> {
         Result<GraphQLResponse> result = client
             .graphQL().raw()
             .withQuery(builder.build().buildQuery())
@@ -121,10 +125,10 @@ public void testGraphQL() {
     }, WARMUP_ROUNDS, BENCHMARK_ROUNDS);
   }
 
-  @Test
+  // @Test
   public void testGRPC() {
     bench("GRPC", () -> {
-      int count = searchKNN(queryVector, K, filters, builder -> {
+      int count = searchKNN(queryVector, K, notEqualFilters, builder -> {
         SearchResult<Map<String, Object>> result = client
             .gRPC().raw()
             .withSearch(builder.build().buildSearchRequest())
@@ -137,7 +141,7 @@ public void testGRPC() {
     }, WARMUP_ROUNDS, BENCHMARK_ROUNDS);
   }
 
-  @Test
+  // @Test
   public void testNewClient() {
     final float[] vector = ArrayUtils.toPrimitive(queryVector);
     final Collection<Map> things = client.collections.use(className, Map.class);
@@ -160,9 +164,14 @@ public static class Thing {
     public String title;
     public Double price;
     public Date bestBefore;
+
+    public String[] ingredientsArray = {};
+    // WARN: this is to test filtering with List<?> values. Creating List<?>
+    // properties is not supported in this version.
+    public String[] ingredientsList = {};
   }
 
-  @Test
+  // @Test
   public void testORMClient() {
     final float[] vector = ArrayUtils.toPrimitive(queryVector);
     bench("GRPC.orm", () -> {
@@ -190,19 +199,19 @@ public void testORMClientMapFilter() {
           vector,
           opt -> opt
               .limit(K)
-              .where(Where.and(filters, Where.Operator.NOT_EQUAL)) // Constructed from a Map<String, Object>!
+              .where(Where.and(notEqualFilters, Where.Operator.NOT_EQUAL)) // Constructed from a Map<String, Object>!
               .returnProperties(returnProperties)
               .returnMetadata(MetadataField.ID, MetadataField.VECTOR, MetadataField.DISTANCE));
 
       int count = countGRPC(result);
       assertEquals(K, count, String.format("must return K=%d results", K));
 
       // Check that filtering works
-      assertFalse(result.objects.stream().anyMatch(obj -> obj.properties.title.equals(filters.get("title"))),
-          "expected title to not be in result set: " + filters.get("title"));
+      assertFalse(result.objects.stream().anyMatch(obj -> obj.properties.title.equals(notEqualFilters.get("title"))),
+          "expected title to not be in result set: " + notEqualFilters.get("title"));
 
-      assertFalse(result.objects.stream().anyMatch(obj -> obj.properties.price.equals(filters.get("price"))),
-          "expected price to not be in result set: " + filters.get("price"));
+      assertFalse(result.objects.stream().anyMatch(obj -> obj.properties.price.equals(notEqualFilters.get("price"))),
+          "expected price to not be in result set: " + notEqualFilters.get("price"));
     }, WARMUP_ROUNDS, BENCHMARK_ROUNDS);
   }
 
@@ -336,6 +345,7 @@ private boolean write(List<Float[]> embeddings) {
     int count = 0;
     for (Float[] e : embeddings) {
       int i = count++;
+      String[] ingr = mixIngredients();
       batcher.withObject(WeaviateObject.builder()
           .className(className)
           .vector(e)
@@ -344,6 +354,8 @@ private boolean write(List<Float[]> embeddings) {
               this.put("title", "Thing-" + String.valueOf(i));
               this.put("price", i);
               this.put("bestBefore", DateFormatUtils.format(DateUtils.addDays(NOW, i), "yyyy-MM-dd'T'HH:mm:ssZZZZZ"));
+              this.put("ingredientsArray", ingr);
+              this.put("ingredientsList", ingr);
             }
           })
           // .id(getUuid(e)) -> use generated UUID
@@ -358,6 +370,7 @@ private boolean write(List<Float[]> embeddings) {
   /** writeORM creates {@link Thing} objects and inserts them in a batch. */
   private boolean writeORM(List<Float[]> embeddings) {
     try (Batcher<Thing> batch = client.datax.batch(Thing.class)) {
+      String[] ingr = mixIngredients();
       return batch.insert(b -> {
         int i = 0;
         for (Float[] e : embeddings) {
@@ -367,14 +380,22 @@ private boolean writeORM(List<Float[]> embeddings) {
 
               // Notice how the ORM is able to handle a raw Date object
               // and convert it to the correct format behind the scenes.
-              /* bestBefore */ DateUtils.addDays(NOW, i));
+              /* bestBefore */ DateUtils.addDays(NOW, i),
+              /* ingredientsArray */ ingr,
+              /* ingredientsList */ ingr);
           b.add(thing, e);
           i++;
         }
       });
     }
   }
 
+  /** Utility for creating random combinations of ingredients for test data. */
+  private String[] mixIngredients() {
+    return Arrays.stream(new String[] { "milk", "honey", "butter" })
+        .filter(x -> rand.nextBoolean()).toArray(String[]::new);
+  }
+
   private static Float[] genVector(int length, float origin, float bound) {
     Float[] vec = new Float[length];
     for (int i = 0; i < length; i++) {