Skip to content

Commit 3e28211

Browse files
committed
chore: deprecate vectorizeCollectionName parameter for multi2vec-jinaai
1 parent 42fd9b4 commit 3e28211

File tree

3 files changed

+40
-37
lines changed

3 files changed

+40
-37
lines changed

src/collections/config/types/vectorizer.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -192,17 +192,17 @@ export type Multi2VecGoogleConfig = {
192192
};
193193

194194
/** The configuration for multi-media-to-multi-vector vectorization using
195-
* the jina-embeddings-v4 model
196-
*
195+
* the jina-embeddings-v4 model
196+
*
197197
* See the [documentation](https://weaviate.io/developers/weaviate/model-providers/jinaai/embeddings-multimodal) for detailed usage.
198-
*/
198+
*/
199199
export type Multi2MultivecJinaAIConfig = {
200200
/** The image fields used when vectorizing. */
201201
imageFields?: string[];
202202

203203
/** The text fields used when vectorizing. */
204204
textFields?: string[];
205-
}
205+
};
206206

207207
/** The configuration for multi-media vectorization using the Jina module.
208208
*
@@ -219,7 +219,11 @@ export type Multi2VecJinaAIConfig = {
219219
model?: string;
220220
/** The text fields used when vectorizing. */
221221
textFields?: string[];
222-
/** Whether the collection name is vectorized. */
222+
/**
223+
* Whether the collection name is vectorized.
224+
*
225+
* @deprecated This parameter is not applicable and has no effect on the underlying module.
226+
* */
223227
vectorizeCollectionName?: boolean;
224228
/** The weights of the fields used for vectorization. */
225229
weights?: {

src/collections/configure/unit.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -703,7 +703,6 @@ describe('Unit testing of the vectorizer factory class', () => {
703703
});
704704
});
705705

706-
707706
requireAtLeast(1, 32, 0).it('should create the correct Multi2MultivecJinaAIConfig with values', () => {
708707
const config = configure.vectorizer.multi2MultivecJinaAI({
709708
name: 'multi-jina',

src/collections/configure/vectorizer.ts

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -184,16 +184,16 @@ export const vectors = {
184184
Object.keys(config).length === 0
185185
? undefined
186186
: {
187-
...config,
188-
audioFields: audioFields?.map((f) => f.name),
189-
depthFields: depthFields?.map((f) => f.name),
190-
imageFields: imageFields?.map((f) => f.name),
191-
IMUFields: IMUFields?.map((f) => f.name),
192-
textFields: textFields?.map((f) => f.name),
193-
thermalFields: thermalFields?.map((f) => f.name),
194-
videoFields: videoFields?.map((f) => f.name),
195-
weights: Object.keys(weights).length === 0 ? undefined : weights,
196-
},
187+
...config,
188+
audioFields: audioFields?.map((f) => f.name),
189+
depthFields: depthFields?.map((f) => f.name),
190+
imageFields: imageFields?.map((f) => f.name),
191+
IMUFields: IMUFields?.map((f) => f.name),
192+
textFields: textFields?.map((f) => f.name),
193+
thermalFields: thermalFields?.map((f) => f.name),
194+
videoFields: videoFields?.map((f) => f.name),
195+
weights: Object.keys(weights).length === 0 ? undefined : weights,
196+
},
197197
},
198198
});
199199
},
@@ -223,11 +223,11 @@ export const vectors = {
223223
Object.keys(config).length === 0
224224
? undefined
225225
: {
226-
...config,
227-
imageFields: imageFields?.map((f) => f.name),
228-
textFields: textFields?.map((f) => f.name),
229-
weights: Object.keys(weights).length === 0 ? undefined : weights,
230-
},
226+
...config,
227+
imageFields: imageFields?.map((f) => f.name),
228+
textFields: textFields?.map((f) => f.name),
229+
weights: Object.keys(weights).length === 0 ? undefined : weights,
230+
},
231231
},
232232
});
233233
},
@@ -257,11 +257,11 @@ export const vectors = {
257257
Object.keys(config).length === 0
258258
? undefined
259259
: {
260-
...config,
261-
imageFields: imageFields?.map((f) => f.name),
262-
textFields: textFields?.map((f) => f.name),
263-
weights: Object.keys(weights).length === 0 ? undefined : weights,
264-
},
260+
...config,
261+
imageFields: imageFields?.map((f) => f.name),
262+
textFields: textFields?.map((f) => f.name),
263+
weights: Object.keys(weights).length === 0 ? undefined : weights,
264+
},
265265
},
266266
});
267267
},
@@ -282,7 +282,7 @@ export const vectors = {
282282
vectorIndexConfig,
283283
vectorizerConfig: {
284284
name: 'multi2multivec-jinaai',
285-
config
285+
config,
286286
},
287287
});
288288
},
@@ -313,11 +313,11 @@ export const vectors = {
313313
Object.keys(config).length === 0
314314
? undefined
315315
: {
316-
...config,
317-
imageFields: imageFields?.map((f) => f.name),
318-
textFields: textFields?.map((f) => f.name),
319-
weights: Object.keys(weights).length === 0 ? undefined : weights,
320-
},
316+
...config,
317+
imageFields: imageFields?.map((f) => f.name),
318+
textFields: textFields?.map((f) => f.name),
319+
weights: Object.keys(weights).length === 0 ? undefined : weights,
320+
},
321321
},
322322
});
323323
},
@@ -417,11 +417,11 @@ export const vectors = {
417417
Object.keys(config).length === 0
418418
? undefined
419419
: {
420-
...config,
421-
imageFields: imageFields?.map((f) => f.name),
422-
textFields: textFields?.map((f) => f.name),
423-
weights: Object.keys(weights).length === 0 ? undefined : weights,
424-
},
420+
...config,
421+
imageFields: imageFields?.map((f) => f.name),
422+
textFields: textFields?.map((f) => f.name),
423+
weights: Object.keys(weights).length === 0 ? undefined : weights,
424+
},
425425
},
426426
});
427427
},

0 commit comments

Comments
 (0)