fix: add 'collection' parameter to AliasPermission

Author: bevzzz

src/roles/index.ts

@@ -159,14 +159,17 @@ export const permissions = {
    */
   aliases: (args: {
     alias: string | string[];
+    collection: string | string[];
     create?: boolean;
     read?: boolean;
     update?: boolean;
     delete?: boolean;
   }): AliasPermission[] => {
     const aliases = Array.isArray(args.alias) ? args.alias : [args.alias];
-    return aliases.flatMap((alias) => {
-      const out: AliasPermission = { alias, actions: [] };
+    const collections = Array.isArray(args.collection) ? args.collection : [args.collection];
+    const combinations = aliases.flatMap((alias) => collections.map((collection) => ({ alias, collection })));
+    return combinations.map(({ collection, alias }) => {
+      const out: AliasPermission = { alias, collection, actions: [] };
       if (args.create) out.actions.push('create_aliases');
       if (args.read) out.actions.push('read_aliases');
       if (args.update) out.actions.push('update_aliases');

src/roles/integration.test.ts

@@ -284,13 +284,16 @@ const testCases: TestCase[] = [
     requireVersion: [1, 32, 0],
     permissions: weaviate.permissions.aliases({
       alias: 'SomeAlias',
+      collection: 'SomeCollection',
       create: true,
       delete: true,
     }),
     expected: {
       name: 'aliases',
       ...emptyPermissions,
-      aliasPermissions: [{ alias: 'SomeAlias', actions: ['create_aliases', 'delete_aliases'] }],
+      aliasPermissions: [
+        { alias: 'SomeAlias', collection: 'SomeCollection', actions: ['create_aliases', 'delete_aliases'] },
+      ],
     },
   },
 ];

src/roles/types.ts

@@ -33,6 +33,7 @@ export type UserAssignment = {
 
 export type AliasPermission = {
   alias: string;
+  collection: string;
   actions: AliasAction[];
 };