Replace testcontainers rbac tests with compose stack

Author: tsmith023

.github/workflows/main.yaml

@@ -11,7 +11,7 @@ env:
   WEAVIATE_125: 1.25.30
   WEAVIATE_126: 1.26.14
   WEAVIATE_127: 1.27.11
-  WEAVIATE_128: 1.28.2
+  WEAVIATE_128: 1.28.4
   WEAVIATE_129: 1.29.0-rc.0
 
 jobs:

ci/compose.sh

@@ -21,5 +21,5 @@ function compose_down_all {
 }
 
 function all_weaviate_ports {
-  echo "8078 8080 8081 8082 8083 8085 8086 8087 8088 8089 8090"
+  echo "8078 8080 8081 8082 8083 8085 8086 8087 8088 8089 8090 8091"
 }

ci/docker-compose-rbac.yml

@@ -0,0 +1,31 @@
+---
+version: '3.4'
+services:
+  weaviate-rbac:
+    command:
+      - --host
+      - 0.0.0.0
+      - --port
+      - '8085'
+      - --scheme
+      - http
+      - --write-timeout=600s
+    image: semitechnologies/weaviate:${WEAVIATE_VERSION}
+    ports:
+      - 8091:8085
+      - 50062:50051
+    restart: on-failure:0
+    environment:
+      ENABLE_MODULES: "generative-dummy,reranker-dummy"
+      PERSISTENCE_DATA_PATH: "./data-weaviate-0"
+      CLUSTER_IN_LOCALHOST: "true"
+      CLUSTER_GOSSIP_BIND_PORT: "7100"
+      CLUSTER_DATA_BIND_PORT: "7101"
+      RAFT_BOOTSTRAP_EXPECT: "1"
+      AUTHENTICATION_APIKEY_ENABLED: "true"
+      AUTHENTICATION_APIKEY_ALLOWED_KEYS: 'viewer-key,editor-key,admin-key,custom-key'
+      AUTHENTICATION_APIKEY_USERS: 'viewer-user,editor-user,admin-user,custom-user'
+      AUTHORIZATION_RBAC_ENABLED: "true"
+      AUTHORIZATION_ADMIN_USERS: "admin-user"
+      AUTHORIZATION_VIEWER_USERS: "viewer-user"
+...

src/roles/integration.test.ts

@@ -1,6 +1,9 @@
-import { StartedWeaviateContainer, WeaviateContainer } from '@testcontainers/weaviate';
 import weaviate, { ApiKey, Permission, Role, WeaviateClient } from '..';
-import { WeaviateInsufficientPermissionsError, WeaviateUnexpectedStatusCodeError } from '../errors';
+import {
+  WeaviateInsufficientPermissionsError,
+  WeaviateStartUpError,
+  WeaviateUnexpectedStatusCodeError,
+} from '../errors';
 import { DbVersion } from '../utils/dbVersion';
 
 const only = DbVersion.fromString(`v${process.env.WEAVIATE_VERSION!}`).isAtLeast(1, 28, 0)
@@ -9,53 +12,32 @@ const only = DbVersion.fromString(`v${process.env.WEAVIATE_VERSION!}`).isAtLeast
 
 only('Integration testing of the roles namespace', () => {
   let client: WeaviateClient;
-  let container: StartedWeaviateContainer;
 
   beforeAll(async () => {
-    container = await new WeaviateContainer(`semitechnologies/weaviate:${process.env.WEAVIATE_VERSION}`)
-      .withExposedPorts(8080, 50051)
-      .withEnvironment({
-        AUTHENTICATION_APIKEY_ENABLED: 'true',
-        AUTHENTICATION_APIKEY_ALLOWED_KEYS: 'admin-key,custom-key',
-        AUTHENTICATION_APIKEY_USERS: 'admin-user,custom-user',
-        AUTHORIZATION_ADMIN_USERS: 'admin-user',
-        AUTHORIZATION_ENABLE_RBAC: 'true',
-      })
-      .start();
-    expect(container).toBeDefined();
     client = await weaviate.connectToLocal({
-      host: container.getHost(),
-      port: container.getMappedPort(8080),
-      grpcPort: container.getMappedPort(50051),
+      port: 8091,
+      grpcPort: 50062,
       authCredentials: new ApiKey('admin-key'),
     });
   });
 
-  afterAll(async () => {
-    await container.stop();
-  });
-
   it('should be able to retrieve the default roles', async () => {
     const roles = await client.roles.listAll();
     expect(Object.values(roles).length).toBeGreaterThan(0);
   });
 
-  it('should fail with insufficient permissions if no key provided', async () => {
-    const unauthenticatedClient = await weaviate.connectToLocal({
-      host: container.getHost(),
-      port: container.getMappedPort(8080),
-      grpcPort: container.getMappedPort(50051),
-    });
-    await expect(unauthenticatedClient.roles.listAll()).rejects.toThrowError(
-      WeaviateInsufficientPermissionsError
-    ); // should be unauthenticated error, needs fixing on server
-  });
+  it('should fail to start up if no key provided', () =>
+    expect(
+      weaviate.connectToLocal({
+        port: 8091,
+        grpcPort: 50062,
+      })
+    ).rejects.toThrowError(WeaviateStartUpError));
 
   it('should fail with insufficient permissions if permission-less key provided', async () => {
     const unauthenticatedClient = await weaviate.connectToLocal({
-      host: container.getHost(),
-      port: container.getMappedPort(8080),
-      grpcPort: container.getMappedPort(50051),
+      port: 8091,
+      grpcPort: 50062,
       authCredentials: new ApiKey('custom-key'),
     });
     await expect(unauthenticatedClient.roles.listAll()).rejects.toThrowError(