test: await on all expectations which should resolve/reject

Author: bevzzz

src/roles/integration.test.ts

@@ -335,7 +335,6 @@ requireAtLeast(
       await client.users.db.assignRoles('landlord', 'Innkeeper');
 
       const assignments = await client.roles.userAssignments('landlord');
-
       expect(assignments).toEqual(
         expect.arrayContaining([
           expect.objectContaining<UserAssignment>({ id: 'custom-user', userType: 'db_env_user' }),

src/users/index.ts

@@ -106,7 +106,7 @@ const db = (connection: ConnectionREST): DBUsers => {
         return error.code === code;
       }
       throw error;
-    }
+    };
   };
 
   type APIKeyResponse = { apikey: string };
@@ -178,7 +178,8 @@ const namespacedUsers = (connection: ConnectionREST): NamespacedUsers => {
     getAssignedRoles: (userType: UserTypeInternal, userId: string, opts?: GetAssignedRolesOptions) =>
       connection
         .get<WeaviateRole[]>(
-          `/authz/users/${userId}/roles/${userType}${opts?.includePermissions ? '?&includeFullRoles=true' : ''
+          `/authz/users/${userId}/roles/${userType}${
+            opts?.includePermissions ? '?&includeFullRoles=true' : ''
           }`
         )
         .then(Map.roles),

src/users/integration.test.ts

@@ -76,19 +76,19 @@ requireAtLeast(
       };
 
       await client.users.db.create('dynamic-dave');
-      expectDave().toHaveProperty('active', true);
+      await expectDave().toHaveProperty('active', true);
 
       // Second activation is a no-op
-      expect(client.users.db.activate('dynamic-dave')).resolves.toEqual(true);
+      await expect(client.users.db.activate('dynamic-dave')).resolves.toEqual(true);
 
       await client.users.db.deactivate('dynamic-dave');
-      expectDave().toHaveProperty('active', false);
+      await expectDave().toHaveProperty('active', false);
 
       // Second deactivation is a no-op
-      expect(client.users.db.deactivate('dynamic-dave')).resolves.toEqual(true);
+      await expect(client.users.db.deactivate('dynamic-dave')).resolves.toEqual(true);
 
       await client.users.db.delete('dynamic-dave');
-      expectDave(false).toHaveProperty('code', 404);
+      await expectDave(false).toHaveProperty('code', 404);
     });
 
     it('should be able to obtain and rotate api keys', async () => {
@@ -128,12 +128,12 @@ requireAtLeast(
       }
 
       await admin.users[kind].assignRoles('test', 'role-rick');
-      expect(admin.users[kind].getAssignedRoles('role-rick')).resolves.toEqual(
+      await expect(admin.users[kind].getAssignedRoles('role-rick')).resolves.toEqual(
         expect.objectContaining({ test: expect.any(Object) })
       );
 
       await admin.users[kind].revokeRoles('test', 'role-rick');
-      expect(admin.users[kind].getAssignedRoles('role-rick')).resolves.toEqual({});
+      await expect(admin.users[kind].getAssignedRoles('role-rick')).resolves.toEqual({});
     });
 
     it('should be able to fetch assigned roles with all permissions', async () => {

src/users/types.ts

@@ -20,4 +20,3 @@ export type GetAssignedRolesOptions = {
 
 /** Optional arguments to /assign and /revoke endpoints. */
 export type AssignRevokeOptions = { userType?: WeaviateUserTypeInternal };
-