Skip to content

Commit 8987ae4

Browse files
committed
chore: deprecate vectorizeCollectionName parameter for multi2vec-jinaai
1 parent 432797a commit 8987ae4

File tree

3 files changed

+40
-37
lines changed

3 files changed

+40
-37
lines changed

src/collections/config/types/vectorizer.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -191,17 +191,17 @@ export type Multi2VecGoogleConfig = {
191191
};
192192

193193
/** The configuration for multi-media-to-multi-vector vectorization using
194-
* the jina-embeddings-v4 model
195-
*
194+
* the jina-embeddings-v4 model
195+
*
196196
* See the [documentation](https://weaviate.io/developers/weaviate/model-providers/jinaai/embeddings-multimodal) for detailed usage.
197-
*/
197+
*/
198198
export type Multi2MultivecJinaAIConfig = {
199199
/** The image fields used when vectorizing. */
200200
imageFields?: string[];
201201

202202
/** The text fields used when vectorizing. */
203203
textFields?: string[];
204-
}
204+
};
205205

206206
/** The configuration for multi-media vectorization using the Jina module.
207207
*
@@ -218,7 +218,11 @@ export type Multi2VecJinaAIConfig = {
218218
model?: string;
219219
/** The text fields used when vectorizing. */
220220
textFields?: string[];
221-
/** Whether the collection name is vectorized. */
221+
/**
222+
* Whether the collection name is vectorized.
223+
*
224+
* @deprecated This parameter is not applicable and has no effect on the underlying module.
225+
* */
222226
vectorizeCollectionName?: boolean;
223227
/** The weights of the fields used for vectorization. */
224228
weights?: {

src/collections/configure/unit.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,6 @@ describe('Unit testing of the vectorizer factory class', () => {
683683
});
684684
});
685685

686-
687686
requireAtLeast(1, 32, 0).it('should create the correct Multi2MultivecJinaAIConfig with values', () => {
688687
const config = configure.vectorizer.multi2MultivecJinaAI({
689688
name: 'multi-jina',

src/collections/configure/vectorizer.ts

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -117,16 +117,16 @@ export const vectorizer = {
117117
Object.keys(config).length === 0
118118
? undefined
119119
: {
120-
...config,
121-
audioFields: audioFields?.map((f) => f.name),
122-
depthFields: depthFields?.map((f) => f.name),
123-
imageFields: imageFields?.map((f) => f.name),
124-
IMUFields: IMUFields?.map((f) => f.name),
125-
textFields: textFields?.map((f) => f.name),
126-
thermalFields: thermalFields?.map((f) => f.name),
127-
videoFields: videoFields?.map((f) => f.name),
128-
weights: Object.keys(weights).length === 0 ? undefined : weights,
129-
},
120+
...config,
121+
audioFields: audioFields?.map((f) => f.name),
122+
depthFields: depthFields?.map((f) => f.name),
123+
imageFields: imageFields?.map((f) => f.name),
124+
IMUFields: IMUFields?.map((f) => f.name),
125+
textFields: textFields?.map((f) => f.name),
126+
thermalFields: thermalFields?.map((f) => f.name),
127+
videoFields: videoFields?.map((f) => f.name),
128+
weights: Object.keys(weights).length === 0 ? undefined : weights,
129+
},
130130
},
131131
});
132132
},
@@ -155,11 +155,11 @@ export const vectorizer = {
155155
Object.keys(config).length === 0
156156
? undefined
157157
: {
158-
...config,
159-
imageFields: imageFields?.map((f) => f.name),
160-
textFields: textFields?.map((f) => f.name),
161-
weights: Object.keys(weights).length === 0 ? undefined : weights,
162-
},
158+
...config,
159+
imageFields: imageFields?.map((f) => f.name),
160+
textFields: textFields?.map((f) => f.name),
161+
weights: Object.keys(weights).length === 0 ? undefined : weights,
162+
},
163163
},
164164
});
165165
},
@@ -188,11 +188,11 @@ export const vectorizer = {
188188
Object.keys(config).length === 0
189189
? undefined
190190
: {
191-
...config,
192-
imageFields: imageFields?.map((f) => f.name),
193-
textFields: textFields?.map((f) => f.name),
194-
weights: Object.keys(weights).length === 0 ? undefined : weights,
195-
},
191+
...config,
192+
imageFields: imageFields?.map((f) => f.name),
193+
textFields: textFields?.map((f) => f.name),
194+
weights: Object.keys(weights).length === 0 ? undefined : weights,
195+
},
196196
},
197197
});
198198
},
@@ -213,7 +213,7 @@ export const vectorizer = {
213213
vectorIndexConfig,
214214
vectorizerConfig: {
215215
name: 'multi2multivec-jinaai',
216-
config
216+
config,
217217
},
218218
});
219219
},
@@ -243,11 +243,11 @@ export const vectorizer = {
243243
Object.keys(config).length === 0
244244
? undefined
245245
: {
246-
...config,
247-
imageFields: imageFields?.map((f) => f.name),
248-
textFields: textFields?.map((f) => f.name),
249-
weights: Object.keys(weights).length === 0 ? undefined : weights,
250-
},
246+
...config,
247+
imageFields: imageFields?.map((f) => f.name),
248+
textFields: textFields?.map((f) => f.name),
249+
weights: Object.keys(weights).length === 0 ? undefined : weights,
250+
},
251251
},
252252
});
253253
},
@@ -344,11 +344,11 @@ export const vectorizer = {
344344
Object.keys(config).length === 0
345345
? undefined
346346
: {
347-
...config,
348-
imageFields: imageFields?.map((f) => f.name),
349-
textFields: textFields?.map((f) => f.name),
350-
weights: Object.keys(weights).length === 0 ? undefined : weights,
351-
},
347+
...config,
348+
imageFields: imageFields?.map((f) => f.name),
349+
textFields: textFields?.map((f) => f.name),
350+
weights: Object.keys(weights).length === 0 ? undefined : weights,
351+
},
352352
},
353353
});
354354
},

0 commit comments

Comments
 (0)