Skip to content

Commit ff0c142

Browse files
committed
refactor: replace .reduce with .map where possible
Rewrote other .reduce occurences in a more succinct manner
1 parent 30cde45 commit ff0c142

File tree

1 file changed

+13
-20
lines changed

1 file changed

+13
-20
lines changed

src/roles/util.ts

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -130,16 +130,16 @@ export class Map {
130130
static roleFromWeaviate = (role: WeaviateRole): Role => PermissionsMapping.use(role).map();
131131

132132
static roles = (roles: WeaviateRole[]): Record<string, Role> =>
133-
roles.reduce((acc, role) => {
134-
acc[role.name] = Map.roleFromWeaviate(role);
135-
return acc;
136-
}, {} as Record<string, Role>);
133+
roles.reduce((acc, role) => ({
134+
...acc,
135+
[role.name]: Map.roleFromWeaviate(role),
136+
}), {} as Record<string, Role>);
137137

138138
static users = (users: string[]): Record<string, User> =>
139-
users.reduce((acc, user) => {
140-
acc[user] = { id: user };
141-
return acc;
142-
}, {} as Record<string, User>);
139+
users.reduce((acc, user) => ({
140+
...acc,
141+
[user]: { id: user },
142+
}), {} as Record<string, User>);
143143
static user = (user: WeaviateUser): User => ({
144144
id: user.username,
145145
roles: user.roles?.map(Map.roleFromWeaviate),
@@ -151,19 +151,12 @@ export class Map {
151151
active: user.active,
152152
});
153153
static dbUsers = (users: WeaviateDBUser[]): UserDB[] =>
154-
users.reduce((acc, user) => {
155-
acc.push(Map.dbUser(user));
156-
return acc;
157-
}, [] as UserDB[]);
158-
154+
users.map(Map.dbUser);
159155
static assignedUsers = (users: WeaviateAssignedUser[]): UserAssignment[] =>
160-
users.reduce((acc, user) => {
161-
acc.push({
162-
id: user.userId || '',
163-
userType: user.userType,
164-
});
165-
return acc;
166-
}, [] as UserAssignment[]);
156+
users.map((user) => ({
157+
id: user.userId || '',
158+
userType: user.userType,
159+
}));
167160
}
168161

169162
class PermissionsMapping {

0 commit comments

Comments
 (0)