feat: support list backups #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
bevzzz
force-pushed
the
feat/list-backups
branch
from
0af812d to
b39aa04
Compare
|
This code looks to be relevant only to the old v2 client, which we haven't released a new version of for a year. For the v3 client, we'd need to add a |
bevzzz
force-pushed
the
feat/list-backups
branch
from
e9d77d9 to
600be34
Compare
bevzzz
commented
Aug 21, 2025
Comment on lines
+92
to
+107
|
|
||
| // wait to complete so that other tests can run without colliding with Weaviate's lack of simultaneous backups | ||
| let wait = true; | ||
| while (wait) { | ||
| const { status, error } = await collection.backup.getCreateStatus({ | ||
| backupId: res.id as string, | ||
| backend: res.backend as Backend, | ||
| }); | ||
| if (status === 'SUCCESS') { | ||
| wait = false; | ||
| } | ||
| if (status === 'FAILED') { | ||
| throw new Error(`Backup creation failed: ${error}`); | ||
| } | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)); | ||
| } |
There was a problem hiding this comment.
Added this wait to make sure the in-progress backup does not interfere with any tests that might follow.
My bad @tsmith023, I forgot we had v2 in the same repo. I stripped the old code away and added the |
bevzzz
changed the title
tsmith023
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weaviate 1.32 supports listing all backups for a backend. This functionality's already been implemented in the client, but we've refrained from exporting before.
Now
BackupGetterjoins the public API for the TS client.