Skip to content

Commit e5ae7ba

Browse files
remove unneccessary OIDC scope filtering (#119)
1 parent 1b8f9a9 commit e5ae7ba

File tree

5 files changed

+2
-10
lines changed

5 files changed

+2
-10
lines changed

ci/docker-compose-azure-cc.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,4 @@ services:
2525
AUTHENTICATION_OIDC_GROUPS_CLAIM: 'groups'
2626
AUTHORIZATION_ADMINLIST_ENABLED: 'true'
2727
AUTHORIZATION_ADMINLIST_USERS: 'b6bf8e1d-d398-4e5d-8f1b-50fda9146a64'
28-
AUTHENTICATION_OIDC_SCOPES: 'openid,email'
2928
...

ci/docker-compose-okta-cc.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,4 @@ services:
2424
AUTHENTICATION_OIDC_GROUPS_CLAIM: 'groups'
2525
AUTHORIZATION_ADMINLIST_ENABLED: 'true'
2626
AUTHORIZATION_ADMINLIST_USERS: '0oa7e9ipdkVZRUcxo5d7'
27-
AUTHENTICATION_OIDC_SCOPES: 'openid,email'
2827
...

connection/auth.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,8 +237,6 @@ class ClientCredentialsAuthenticator {
237237
};
238238

239239
validateOpenidConfig = () => {
240-
this.openidConfig.scopes = this.openidConfig.scopes
241-
.filter(scope => scope != "openid" && scope != "email");
242240
if (this.openidConfig.scopes.length > 0) {
243241
return;
244242
}

connection/unit.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ describe("mock server auth tests", () => {
6363
password: "secure_password",
6464
grant_type: "password",
6565
client_id: "client123",
66-
scope: "openid email custom_scope offline_access"
66+
scope: "custom_scope offline_access"
6767
});
6868
})
6969

test/server.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,7 @@ const getLocalOidcConfig = (ctx, next) => {
4848
ctx.response.type = "application/json";
4949
ctx.response.body = {
5050
clientId: "client123",
51-
href: "http://localhost:" + port + "/remote-openid-configuration",
52-
scopes: [
53-
"openid",
54-
"email"
55-
]
51+
href: "http://localhost:" + port + "/remote-openid-configuration"
5652
};
5753
};
5854

0 commit comments

Comments
 (0)