Skip to content

Commit 9ede3f7

Browse files
authored
Merge pull request #1755 from weaviate/cleanup_multi
Remove unused configs from new vectorizer syntax
2 parents 4366849 + d77a95d commit 9ede3f7

File tree

4 files changed

+5
-19
lines changed

4 files changed

+5
-19
lines changed

test/collection/test_config.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ def test_basic_config():
124124
"multi2vec-voyageai": {
125125
"model": "voyage-multimodal-3",
126126
"truncation": False,
127-
"output_encoding": "base64",
128127
"baseURL": "https://api.voyageai.com/",
129128
}
130129
},
@@ -133,15 +132,13 @@ def test_basic_config():
133132
Configure.Vectorizer.multi2vec_nvidia(
134133
model="nvidia/nvclip",
135134
truncation=False,
136-
output_encoding="base64",
137135
vectorize_collection_name=False,
138136
base_url="https://integrate.api.nvidia.com",
139137
),
140138
{
141139
"multi2vec-nvidia": {
142140
"model": "nvidia/nvclip",
143141
"truncation": False,
144-
"output_encoding": "base64",
145142
"baseURL": "https://integrate.api.nvidia.com/",
146143
}
147144
},

weaviate/collections/classes/config_named_vectors.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,6 @@ def multi2vec_voyageai(
725725
baseURL=base_url,
726726
model=model,
727727
truncation=truncation,
728-
output_encoding=output_encoding,
729728
imageFields=_map_multi2vec_fields(image_fields),
730729
textFields=_map_multi2vec_fields(text_fields),
731730
),
@@ -769,7 +768,6 @@ def multi2vec_nvidia(
769768
baseURL=base_url,
770769
model=model,
771770
truncation=truncation,
772-
output_encoding=output_encoding,
773771
imageFields=_map_multi2vec_fields(image_fields),
774772
textFields=_map_multi2vec_fields(text_fields),
775773
),

weaviate/collections/classes/config_vectorizers.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,6 @@ class _Multi2VecVoyageaiConfig(_Multi2VecBase):
507507
baseURL: Optional[AnyHttpUrl]
508508
model: Optional[str]
509509
truncation: Optional[bool]
510-
output_encoding: Optional[str]
511510

512511
def _to_dict(self) -> Dict[str, Any]:
513512
ret_dict = super()._to_dict()
@@ -523,7 +522,6 @@ class _Multi2VecNvidiaConfig(_Multi2VecBase):
523522
baseURL: Optional[AnyHttpUrl]
524523
model: Optional[str]
525524
truncation: Optional[bool]
526-
output_encoding: Optional[str]
527525

528526
def _to_dict(self) -> Dict[str, Any]:
529527
ret_dict = super()._to_dict()
@@ -852,8 +850,8 @@ def multi2vec_voyageai(
852850
Args:
853851
model: The model to use. Defaults to `None`, which uses the server-defined default.
854852
truncate: The truncation strategy to use. Defaults to `None`, which uses the server-defined default.
855-
output_encoding: Format in which the embeddings are encoded. Defaults to `None`, so the embeddings are represented as a list of floating-point numbers.
856-
vectorize_collection_name: Whether to vectorize the collection name. Defaults to `True`.
853+
output_encoding: Deprecated, has no effect.
854+
vectorize_collection_name: Deprecated, has no effect.
857855
base_url: The base URL to use where API requests should go. Defaults to `None`, which uses the server-defined default.
858856
image_fields: The image fields to use in vectorization.
859857
text_fields: The text fields to use in vectorization.
@@ -865,7 +863,6 @@ def multi2vec_voyageai(
865863
baseURL=base_url,
866864
model=model,
867865
truncation=truncation,
868-
output_encoding=output_encoding,
869866
imageFields=_map_multi2vec_fields(image_fields),
870867
textFields=_map_multi2vec_fields(text_fields),
871868
)
@@ -875,7 +872,7 @@ def multi2vec_nvidia(
875872
*,
876873
model: Optional[str] = None,
877874
truncation: Optional[bool] = None,
878-
output_encoding: Optional[str],
875+
output_encoding: Optional[str] = None,
879876
vectorize_collection_name: bool = True,
880877
base_url: Optional[AnyHttpUrl] = None,
881878
image_fields: Optional[Union[List[str], List[Multi2VecField]]] = None,
@@ -889,8 +886,8 @@ def multi2vec_nvidia(
889886
Args:
890887
model: The model to use. Defaults to `None`, which uses the server-defined default.
891888
truncate: The truncation strategy to use. Defaults to `None`, which uses the server-defined default.
892-
output_encoding: Format in which the embeddings are encoded. Defaults to `None`, so the embeddings are represented as a list of floating-point numbers.
893-
vectorize_collection_name: Whether to vectorize the collection name. Defaults to `True`.
889+
output_encoding: Deprecated, has no effect.
890+
vectorize_collection_name: Deprecated, has no effect.
894891
base_url: The base URL to use where API requests should go. Defaults to `None`, which uses the server-defined default.
895892
image_fields: The image fields to use in vectorization.
896893
text_fields: The text fields to use in vectorization.
@@ -902,7 +899,6 @@ def multi2vec_nvidia(
902899
baseURL=base_url,
903900
model=model,
904901
truncation=truncation,
905-
output_encoding=output_encoding,
906902
imageFields=_map_multi2vec_fields(image_fields),
907903
textFields=_map_multi2vec_fields(text_fields),
908904
)

weaviate/collections/classes/config_vectors.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -813,7 +813,6 @@ def multi2vec_voyageai(
813813
base_url: Optional[AnyHttpUrl] = None,
814814
image_fields: Optional[Union[List[str], List[Multi2VecField]]] = None,
815815
model: Optional[Union[VoyageMultimodalModel, str]] = None,
816-
output_encoding: Optional[str] = None,
817816
text_fields: Optional[Union[List[str], List[Multi2VecField]]] = None,
818817
truncation: Optional[bool] = None,
819818
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
@@ -843,7 +842,6 @@ def multi2vec_voyageai(
843842
baseURL=base_url,
844843
model=model,
845844
truncation=truncation,
846-
output_encoding=output_encoding,
847845
imageFields=_map_multi2vec_fields(image_fields),
848846
textFields=_map_multi2vec_fields(text_fields),
849847
),
@@ -858,7 +856,6 @@ def multi2vec_nvidia(
858856
base_url: Optional[AnyHttpUrl] = None,
859857
image_fields: Optional[Union[List[str], List[Multi2VecField]]] = None,
860858
model: Optional[str] = None,
861-
output_encoding: Optional[str] = None,
862859
text_fields: Optional[Union[List[str], List[Multi2VecField]]] = None,
863860
truncation: Optional[bool] = None,
864861
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
@@ -874,7 +871,6 @@ def multi2vec_nvidia(
874871
base_url: The base URL to use where API requests should go. Defaults to `None`, which uses the server-defined default.
875872
image_fields: The image fields to use in vectorization.
876873
model: The model to use. Defaults to `None`, which uses the server-defined default.
877-
output_encoding: The output encoding to use. Defaults to `None`, which uses the server-defined default.
878874
text_fields: The text fields to use in vectorization.
879875
truncation: The truncation strategy to use. Defaults to `None`, which uses the server-defined default.
880876
vector_index_config: The configuration for Weaviate's vector index. Use `wvc.config.Configure.VectorIndex` to create a vector index configuration. None by default
@@ -888,7 +884,6 @@ def multi2vec_nvidia(
888884
baseURL=base_url,
889885
model=model,
890886
truncation=truncation,
891-
output_encoding=output_encoding,
892887
imageFields=_map_multi2vec_fields(image_fields),
893888
textFields=_map_multi2vec_fields(text_fields),
894889
),

0 commit comments

Comments
 (0)