Skip to content

Commit fd52f50

Browse files
authored
Merge pull request #1901 from weaviate/order_overloads
Reorder overloads to remove deprecation warning in pycharm
2 parents de2526a + bbd4a80 commit fd52f50

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

weaviate/collections/collections/async_.pyi

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ from weaviate.connect.v4 import ConnectionAsync
2828

2929
class _CollectionsAsync(_CollectionsBase[ConnectionAsync]):
3030
@overload
31-
@deprecated(
32-
'Using the "vector_index_config" argument is deprecated. Instead, define the vector index for each specific vectorizer supplied to the "vectorizers_config" argument.'
33-
)
3431
async def create(
3532
self,
3633
name: str,
@@ -44,7 +41,7 @@ class _CollectionsAsync(_CollectionsBase[ConnectionAsync]):
4441
replication_config: Optional[_ReplicationConfigCreate] = None,
4542
reranker_config: Optional[_RerankerProvider] = None,
4643
sharding_config: Optional[_ShardingConfigCreate] = None,
47-
vector_index_config: _VectorIndexConfigCreate,
44+
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
4845
vectorizer_config: Optional[
4946
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
5047
] = None,
@@ -55,7 +52,7 @@ class _CollectionsAsync(_CollectionsBase[ConnectionAsync]):
5552
) -> CollectionAsync[Properties, References]: ...
5653
@overload
5754
@deprecated(
58-
'Using the "vectorizer_config" argument is deprecated. Instead, use the "vectorizers_config" argument.'
55+
'Using the "vectorizer_config" argument is deprecated. Instead, use the "vector_config" argument.'
5956
)
6057
async def create(
6158
self,
@@ -70,14 +67,19 @@ class _CollectionsAsync(_CollectionsBase[ConnectionAsync]):
7067
replication_config: Optional[_ReplicationConfigCreate] = None,
7168
reranker_config: Optional[_RerankerProvider] = None,
7269
sharding_config: Optional[_ShardingConfigCreate] = None,
73-
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
74-
vectorizer_config: Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]],
70+
vector_index_config: _VectorIndexConfigCreate,
71+
vectorizer_config: Optional[
72+
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
73+
] = None,
7574
vector_config: Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]] = None,
7675
data_model_properties: Optional[Type[Properties]] = None,
7776
data_model_references: Optional[Type[References]] = None,
7877
skip_argument_validation: bool = False,
7978
) -> CollectionAsync[Properties, References]: ...
8079
@overload
80+
@deprecated(
81+
'Using the "vectorizer_config" argument is deprecated. Instead, use the "vector_config" argument.'
82+
)
8183
async def create(
8284
self,
8385
name: str,
@@ -92,9 +94,7 @@ class _CollectionsAsync(_CollectionsBase[ConnectionAsync]):
9294
reranker_config: Optional[_RerankerProvider] = None,
9395
sharding_config: Optional[_ShardingConfigCreate] = None,
9496
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
95-
vectorizer_config: Optional[
96-
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
97-
] = None,
97+
vectorizer_config: Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]],
9898
vector_config: Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]] = None,
9999
data_model_properties: Optional[Type[Properties]] = None,
100100
data_model_references: Optional[Type[References]] = None,

weaviate/collections/collections/sync.pyi

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ from weaviate.connect.v4 import ConnectionSync
2828

2929
class _Collections(_CollectionsBase[ConnectionSync]):
3030
@overload
31-
@deprecated(
32-
'Using the "vector_index_config" argument is deprecated. Instead, define the vector index for each specific vectorizer supplied to the "vector_config" argument.'
33-
)
3431
def create(
3532
self,
3633
name: str,
@@ -44,7 +41,7 @@ class _Collections(_CollectionsBase[ConnectionSync]):
4441
replication_config: Optional[_ReplicationConfigCreate] = None,
4542
reranker_config: Optional[_RerankerProvider] = None,
4643
sharding_config: Optional[_ShardingConfigCreate] = None,
47-
vector_index_config: _VectorIndexConfigCreate,
44+
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
4845
vectorizer_config: Optional[
4946
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
5047
] = None,
@@ -55,7 +52,7 @@ class _Collections(_CollectionsBase[ConnectionSync]):
5552
) -> Collection[Properties, References]: ...
5653
@overload
5754
@deprecated(
58-
'Using the "vectorizer_config" argument is deprecated. Instead, use the "vector_config" argument.'
55+
'Using the "vector_index_config" argument is deprecated. Instead, define the vector index for each specific vectorizer supplied to the "vector_config" argument.'
5956
)
6057
def create(
6158
self,
@@ -70,14 +67,19 @@ class _Collections(_CollectionsBase[ConnectionSync]):
7067
replication_config: Optional[_ReplicationConfigCreate] = None,
7168
reranker_config: Optional[_RerankerProvider] = None,
7269
sharding_config: Optional[_ShardingConfigCreate] = None,
73-
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
74-
vectorizer_config: Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]],
70+
vector_index_config: _VectorIndexConfigCreate,
71+
vectorizer_config: Optional[
72+
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
73+
] = None,
7574
vector_config: Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]] = None,
7675
data_model_properties: Optional[Type[Properties]] = None,
7776
data_model_references: Optional[Type[References]] = None,
7877
skip_argument_validation: bool = False,
7978
) -> Collection[Properties, References]: ...
8079
@overload
80+
@deprecated(
81+
'Using the "vectorizer_config" argument is deprecated. Instead, use the "vector_config" argument.'
82+
)
8183
def create(
8284
self,
8385
name: str,
@@ -92,9 +94,7 @@ class _Collections(_CollectionsBase[ConnectionSync]):
9294
reranker_config: Optional[_RerankerProvider] = None,
9395
sharding_config: Optional[_ShardingConfigCreate] = None,
9496
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
95-
vectorizer_config: Optional[
96-
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
97-
] = None,
97+
vectorizer_config: Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]],
9898
vector_config: Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]] = None,
9999
data_model_properties: Optional[Type[Properties]] = None,
100100
data_model_references: Optional[Type[References]] = None,

0 commit comments

Comments
 (0)