Rector/ECS (#792)

Refactor constructor signatures and assertions in various classes for improved clarity

Author: Spomky

composer.json

@@ -121,6 +121,7 @@
         "symfony/monolog-bundle": "^3.8",
         "symfony/twig-bundle": "^6.4|^7.0",
         "symfony/var-dumper": "^6.4|^7.0",
+        "symfony/var-exporter": "^6.4|^7.0",
         "symfony/yaml": "^6.4|^7.0",
         "symplify/easy-coding-standard": "^12.0",
         "web-token/jwt-library": "^4.0"

phpstan-baseline.neon

@@ -124,7 +124,7 @@ public function load(array $configs, ContainerBuilder $container): void
         }
     }
 
-    public function getConfiguration(array $config, ContainerBuilder $container): ?ConfigurationInterface
+    public function getConfiguration(array $config, ContainerBuilder $container): ConfigurationInterface
     {
         return new Configuration($this->alias);
     }

src/symfony/src/DependencyInjection/WebauthnExtension.php

@@ -68,7 +68,7 @@ public function setLogger(LoggerInterface $logger): void
         $this->logger = $logger;
     }
 
-    public function supports(Request $request): ?bool
+    public function supports(Request $request): bool
     {
         if ($request->getMethod() !== Request::METHOD_POST) {
             return false;
@@ -144,7 +144,7 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token,
         return $this->successHandler->onAuthenticationSuccess($request, $token);
     }
 
-    public function onAuthenticationFailure(Request $request, AuthenticationException $exception): ?Response
+    public function onAuthenticationFailure(Request $request, AuthenticationException $exception): Response
     {
         $this->logger->info('Webauthn authentication request failed.', [
             'request' => $request,

src/symfony/src/Security/Http/Authenticator/WebauthnAuthenticator.php

@@ -26,7 +26,7 @@
 
 final class WebauthnBundle extends Bundle
 {
-    public function getContainerExtension(): ?ExtensionInterface
+    public function getContainerExtension(): ExtensionInterface
     {
         return new WebauthnExtension('webauthn');
     }

src/symfony/src/WebauthnBundle.php

@@ -41,9 +41,8 @@ final class TPMAttestationStatementSupport implements AttestationStatementSuppor
 
     private readonly ClockInterface $clock;
 
-    public function __construct(
-        null|ClockInterface $clock = null
-    ) {
+    public function __construct(null|ClockInterface $clock = null)
+    {
         $this->clock = $clock ?? new NativeClock();
         $this->dispatcher = new NullEventDispatcher();
     }

src/webauthn/src/AttestationStatement/TPMAttestationStatementSupport.php

@@ -161,7 +161,7 @@ public function requestCeremony(): CeremonyStepManager
             $this->allowedOrigins === null ? new CheckOrigin(
                 $this->securedRelyingPartyId ?? []
             ) : new CheckAllowedOrigins($this->allowedOrigins, $this->allowSubdomains),
-            new CheckTopOrigin(null),
+            new CheckTopOrigin(),
             new CheckRelyingPartyIdIdHash(),
             new CheckUserWasPresent(),
             new CheckUserVerification(),

src/webauthn/src/CeremonyStep/CeremonyStepManagerFactory.php

@@ -16,9 +16,8 @@
 {
     private ClientDataCollectorManager $clientDataCollectorManager;
 
-    public function __construct(
-        null|ClientDataCollectorManager $clientDataCollectorManager = null,
-    ) {
+    public function __construct(null|ClientDataCollectorManager $clientDataCollectorManager = null)
+    {
         $this->clientDataCollectorManager = $clientDataCollectorManager ?? new ClientDataCollectorManager([
             new WebauthnAuthenticationCollector(),
         ]);

src/webauthn/src/CeremonyStep/CheckClientDataCollectorType.php

@@ -26,9 +26,8 @@
 {
     private Manager $algorithmManager;
 
-    public function __construct(
-        null|Manager $algorithmManager = null,
-    ) {
+    public function __construct(null|Manager $algorithmManager = null)
+    {
         $this->algorithmManager = $algorithmManager ?? Manager::create()->add(ES256::create(), RS256::create());
     }
 

src/webauthn/src/CeremonyStep/CheckSignature.php

@@ -30,10 +30,8 @@ final class JsonMetadataService implements MetadataService, CanDispatchEvents
     /**
      * @param string[] $statements
      */
-    public function __construct(
-        array $statements,
-        ?SerializerInterface $serializer = null,
-    ) {
+    public function __construct(array $statements, ?SerializerInterface $serializer = null)
+    {
         $this->dispatcher = new NullEventDispatcher();
         $this->serializer = $serializer ?? (new WebauthnSerializerFactory(
             AttestationStatementSupportManager::create()