Skip to content

Commit ed039a7

Browse files
Spomkyclaude
andcommitted
fix: add PHPStan type annotations for parse_url() return values in CheckAllowedOrigins
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent b4cd9a4 commit ed039a7

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/webauthn/src/CeremonyStep/CheckAllowedOrigins.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,9 @@ private function isSubdomainOfFullOrigins(array $parsedOrigin): bool
141141
if (! isset($parsedOrigin['scheme'], $parsedOrigin['host'])) {
142142
return false;
143143
}
144+
/** @var string $originScheme */
144145
$originScheme = $parsedOrigin['scheme'];
146+
/** @var string $originHost */
145147
$originHost = $parsedOrigin['host'];
146148
$originPort = $parsedOrigin['port'] ?? null;
147149

@@ -150,14 +152,18 @@ private function isSubdomainOfFullOrigins(array $parsedOrigin): bool
150152
if (! is_array($parsedAllowed) || ! isset($parsedAllowed['scheme'], $parsedAllowed['host'])) {
151153
continue;
152154
}
153-
if ($originScheme !== $parsedAllowed['scheme']) {
155+
/** @var string $allowedScheme */
156+
$allowedScheme = $parsedAllowed['scheme'];
157+
/** @var string $allowedHost */
158+
$allowedHost = $parsedAllowed['host'];
159+
if ($originScheme !== $allowedScheme) {
154160
continue;
155161
}
156162
$allowedPort = $parsedAllowed['port'] ?? null;
157163
if ($originPort !== $allowedPort) {
158164
continue;
159165
}
160-
if ($this->isSubdomainOf($originHost, $parsedAllowed['host'])) {
166+
if ($this->isSubdomainOf($originHost, $allowedHost)) {
161167
return true;
162168
}
163169
}

0 commit comments

Comments
 (0)