feat(croatian-eid): add ElectronicID.allowsUsingLettersInPin()

WE2-376

Signed-off-by: Mart Somermaa <[email protected]>

Author: mrts

include/electronic-id/electronic-id.hpp

@@ -78,6 +78,7 @@ class ElectronicID
                                          const HashAlgorithm hashAlgo) const = 0;
 
     // General functions.
+    virtual bool allowsUsingLettersInPin() const { return false; }
     virtual std::string name() const = 0;
     virtual Type type() const = 0;
 

src/electronic-ids/pkcs11/Pkcs11ElectronicID.cpp

@@ -55,7 +55,7 @@ std::string wstringToString(std::wstring s)
     int len =
         WideCharToMultiByte(CP_UTF8, 0, s.data(), int(s.size()), nullptr, 0, nullptr, nullptr);
     std::string out(size_t(len), 0);
-    WideCharToMultiByte(CP_UTF8, 0, s.data(), int(s.size()), &out[0], len, nullptr, nullptr);
+    WideCharToMultiByte(CP_UTF8, 0, s.data(), int(s.size()), out.data(), len, nullptr, nullptr);
     return out;
 }
 #endif
@@ -103,6 +103,7 @@ const std::map<electronic_id::Pkcs11ElectronicIDType, electronic_id::Pkcs11Elect
              electronic_id::JsonWebSignatureAlgorithm::ES384, // authSignatureAlgorithm
              electronic_id::ELLIPTIC_CURVE_SIGNATURE_ALGOS(), // supportedSigningAlgorithms
              3,
+             false,
          }},
         {electronic_id::Pkcs11ElectronicIDType::LitEIDv2,
          {
@@ -113,6 +114,7 @@ const std::map<electronic_id::Pkcs11ElectronicIDType, electronic_id::Pkcs11Elect
              electronic_id::JsonWebSignatureAlgorithm::RS256, // authSignatureAlgorithm
              electronic_id::RSA_SIGNATURE_ALGOS(), // supportedSigningAlgorithms
              -1,
+             false,
          }},
         {electronic_id::Pkcs11ElectronicIDType::LitEIDv3,
          {
@@ -123,15 +125,19 @@ const std::map<electronic_id::Pkcs11ElectronicIDType, electronic_id::Pkcs11Elect
              electronic_id::JsonWebSignatureAlgorithm::RS256, // authSignatureAlgorithm
              electronic_id::RSA_SIGNATURE_ALGOS(), // supportedSigningAlgorithms
              -1,
+             false,
          }},
         {electronic_id::Pkcs11ElectronicIDType::HrvEID,
-         {"Croatian eID (PKCS#11)"s, // name
-          electronic_id::ElectronicID::Type::HrvEID, // type
-          croatianPkcs11ModulePath(), // path
+         {
+             "Croatian eID (PKCS#11)"s, // name
+             electronic_id::ElectronicID::Type::HrvEID, // type
+             croatianPkcs11ModulePath(), // path
 
-          electronic_id::JsonWebSignatureAlgorithm::RS256, // authSignatureAlgorithm
-          electronic_id::RSA_SIGNATURE_ALGOS(), // supportedSigningAlgorithms
-          3}},
+             electronic_id::JsonWebSignatureAlgorithm::RS256, // authSignatureAlgorithm
+             electronic_id::RSA_SIGNATURE_ALGOS(), // supportedSigningAlgorithms
+             3,
+             true,
+         }},
 };
 
 const electronic_id::Pkcs11ElectronicIDModule&

src/electronic-ids/pkcs11/Pkcs11ElectronicID.hpp

@@ -38,13 +38,14 @@ enum class Pkcs11ElectronicIDType {
 
 struct Pkcs11ElectronicIDModule
 {
-    std::string name;
-    ElectronicID::Type type;
-    std::string path;
-
-    JsonWebSignatureAlgorithm authSignatureAlgorithm;
-    std::set<SignatureAlgorithm> supportedSigningAlgorithms;
-    int8_t retryMax;
+    const std::string name;
+    const ElectronicID::Type type;
+    const std::string path;
+
+    const JsonWebSignatureAlgorithm authSignatureAlgorithm;
+    const std::set<SignatureAlgorithm> supportedSigningAlgorithms;
+    const int8_t retryMax;
+    const bool allowsUsingLettersInPin;
 };
 
 class Pkcs11ElectronicID : public ElectronicID
@@ -53,6 +54,8 @@ class Pkcs11ElectronicID : public ElectronicID
     Pkcs11ElectronicID(pcsc_cpp::SmartCard::ptr card, Pkcs11ElectronicIDType type);
 
 private:
+    bool allowsUsingLettersInPin() const override { return module.allowsUsingLettersInPin; }
+
     pcsc_cpp::byte_vector getCertificate(const CertificateType type) const override;
 
     JsonWebSignatureAlgorithm authSignatureAlgorithm() const override