Fix coverity warnings

metsma · mrts · commit f47fc15265f9 · 2025-02-04T22:47:43.000+02:00
Signed-off-by: Raul Metsma &lt;raul@metsma.ee&gt;
diff --git a/lib/libpcsc-cpp/include/pcsc-cpp/pcsc-cpp.hpp b/lib/libpcsc-cpp/include/pcsc-cpp/pcsc-cpp.hpp
@@ -131,7 +131,7 @@ struct ResponseApdu
 
     friend std::string operator+(std::string&& lhs, const ResponseApdu& rhs)
     {
-        return lhs + rhs.data + byte_vector {rhs.sw1, rhs.sw2};
+        return std::move(lhs) + rhs.data + byte_vector {rhs.sw1, rhs.sw2};
     }
 };
 
diff --git a/lib/libpcsc-cpp/src/utils.cpp b/lib/libpcsc-cpp/src/utils.cpp
@@ -74,7 +74,7 @@ std::ostream& operator<<(std::ostream& os, const pcsc_cpp::byte_vector& data)
     os << std::setfill('0') << std::hex;
     for (const auto byte : data)
         os << std::setw(2) << short(byte);
-    return os;
+    return os << std::setfill(' ') << std::dec;
 }
 
 std::string operator+(std::string lhs, const byte_vector& rhs)

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ struct ResponseApdu`
`131`	`131`
`132`	`132`	`friend std::string operator+(std::string&& lhs, const ResponseApdu& rhs)`
`133`	`133`	`{`
`134`		`- return lhs + rhs.data + byte_vector {rhs.sw1, rhs.sw2};`
	`134`	`+ return std::move(lhs) + rhs.data + byte_vector {rhs.sw1, rhs.sw2};`
`135`	`135`	`}`
`136`	`136`	`};`
`137`	`137`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ std::ostream& operator<<(std::ostream& os, const pcsc_cpp::byte_vector& data)`
`74`	`74`	`os << std::setfill('0') << std::hex;`
`75`	`75`	`for (const auto byte : data)`
`76`	`76`	`os << std::setw(2) << short(byte);`
`77`		`- return os;`
	`77`	`+ return os << std::setfill(' ') << std::dec;`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`std::string operator+(std::string lhs, const byte_vector& rhs)`