refactor(SmartCard): don't move ATR, take it by const reference instead

mrts · mrts · commit fbaf440d1779 · 2021-05-25T18:17:14.000+03:00
diff --git a/include/pcsc-cpp/pcsc-cpp.hpp b/include/pcsc-cpp/pcsc-cpp.hpp
@@ -222,7 +222,7 @@ class SmartCard
         bool& inProgress;
     };
 
-    SmartCard(const ContextPtr& context, const string_t& readerName, byte_vector atr);
+    SmartCard(const ContextPtr& context, const string_t& readerName, const byte_vector& atr);
     ~SmartCard();
 
     // The rule of five.
diff --git a/src/SmartCard.cpp b/src/SmartCard.cpp
@@ -252,9 +252,9 @@ SmartCard::TransactionGuard::~TransactionGuard()
     }
 }
 
-SmartCard::SmartCard(const ContextPtr& contex, const string_t& readerName, byte_vector atr) :
+SmartCard::SmartCard(const ContextPtr& contex, const string_t& readerName, const byte_vector& atr) :
     card(std::make_unique<CardImpl>(connectToCard(contex->handle(), readerName))),
-    _protocol(convertToSmartCardProtocol(card->protocol())), _atr(std::move(atr))
+    _protocol(convertToSmartCardProtocol(card->protocol())), _atr(atr)
 {
     // TODO: debug("Card ATR -> " + bytes2hexstr(atr));
 }

Original file line number	Diff line number	Diff line change
`@@ -252,9 +252,9 @@ SmartCard::TransactionGuard::~TransactionGuard()`
`252`	`252`	`}`
`253`	`253`	`}`
`254`	`254`
`255`		`-SmartCard::SmartCard(const ContextPtr& contex, const string_t& readerName, byte_vector atr) :`
	`255`	`+SmartCard::SmartCard(const ContextPtr& contex, const string_t& readerName, const byte_vector& atr) :`
`256`	`256`	`card(std::make_unique<CardImpl>(connectToCard(contex->handle(), readerName))),`
`257`		`- _protocol(convertToSmartCardProtocol(card->protocol())), _atr(std::move(atr))`
	`257`	`+ _protocol(convertToSmartCardProtocol(card->protocol())), _atr(atr)`
`258`	`258`	`{`
`259`	`259`	`// TODO: debug("Card ATR -> " + bytes2hexstr(atr));`
`260`	`260`	`}`