Skip to content

Commit 0ac6248

Browse files
metsmamrts
authored andcommitted
Build only Burn installer with single arch
IB-7146 Signed-off-by: Raul Metsma <raul@metsma.ee>
1 parent 437adea commit 0ac6248

File tree

3 files changed

+13
-72
lines changed

3 files changed

+13
-72
lines changed

.github/workflows/cmake-windows.yml

Lines changed: 7 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,21 @@ jobs:
2121
- arch: x64
2222
qt: win64_msvc2017_64
2323
- suffix: qt6
24-
qtver: 6.3.0
24+
qtver: 6.3.1
2525
arch: x64
2626
qt: win64_msvc2019_64
2727

2828
steps:
2929
- name: Checkout code
30-
uses: actions/checkout@v2
30+
uses: actions/checkout@v3
3131
with:
3232
submodules: recursive
3333

3434
- name: Prepare vcpkg and libraries
3535
uses: lukka/run-vcpkg@v7
3636
with:
3737
vcpkgArguments: gtest openssl
38-
vcpkgTriplet: ${{ matrix.arch }}-windows
38+
vcpkgTriplet: ${{matrix.arch}}-windows
3939
vcpkgGitCommitId: 9b064ff07b987c8f213fdbf4358122fd4fe38ef1
4040

4141
- name: Install Qt
@@ -60,66 +60,17 @@ jobs:
6060
run: |
6161
cmake --build build --config ${env:BUILD_TYPE}
6262
cmake --build build --config ${env:BUILD_TYPE} --target installer
63+
cmake --build build --config ${env:BUILD_TYPE} --target bundle
6364
6465
- name: Test
6566
if: matrix.arch == 'x64'
6667
run: ctest -V -C ${env:BUILD_TYPE} --test-dir build
6768

6869
- name: Upload artifacts
69-
uses: actions/upload-artifact@v2
70+
uses: actions/upload-artifact@v3
7071
with:
71-
name: web-eid-app-windows-build-${{github.run_number}}-${{ matrix.suffix }}
72+
name: web-eid-app-windows-build-${{github.run_number}}-${{matrix.suffix}}
7273
path: |
7374
build/src/app/*.msi
74-
build/**/*.pdb
75-
76-
bundle:
77-
needs: build
78-
runs-on: windows-2019
79-
steps:
80-
- name: Checkout code
81-
uses: actions/checkout@v2
82-
with:
83-
submodules: recursive
84-
85-
- name: Prepare vcpkg and libraries
86-
uses: lukka/run-vcpkg@v7
87-
with:
88-
vcpkgArguments: gtest openssl
89-
vcpkgTriplet: x64-windows
90-
vcpkgGitCommitId: 9b064ff07b987c8f213fdbf4358122fd4fe38ef1
91-
92-
- name: Install Qt
93-
uses: jurplel/install-qt-action@v2
94-
with:
95-
version: 5.12.12
96-
arch: win64_msvc2017_64
97-
98-
- name: Setup MS Visual C++ dev env
99-
uses: ilammy/msvc-dev-cmd@v1
100-
with:
101-
arch: x64
102-
toolset: 14.29
103-
104-
- name: Configure CMake
105-
run: |
106-
cmake "-GNinja" `
107-
"-DCMAKE_TOOLCHAIN_FILE=${{env.VCPKG_ROOT}}/scripts/buildsystems/vcpkg.cmake" `
108-
"-DCMAKE_BUILD_TYPE=${env:BUILD_TYPE}" -S . -B build
109-
110-
- name: Download artifacts
111-
uses: actions/download-artifact@v2
112-
with:
113-
name: web-eid-app-windows-build-${{github.run_number}}-qt5
114-
path: build
115-
116-
- name: Build
117-
run: |
118-
cmake --build build --config ${env:BUILD_TYPE} --target bundle
119-
120-
- name: Upload artifacts
121-
uses: actions/upload-artifact@v2
122-
with:
123-
name: web-eid-app-windows-build-${{github.run_number}}
124-
path: |
12575
build/src/app/*.exe
76+
build/**/*.pdb

install/plugins.wxs

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,8 @@
3131
Key="SOFTWARE\Mozilla\NativeMessagingHosts\eu.webeid" Win64="yes"/>
3232

3333
<Chain>
34-
<MsiPackage Id="WebEID.X86" InstallCondition="NOT VersionNT64" ForcePerMachine="yes"
35-
SourceFile="$(var.webeid).x86.qt.msi" Compressed="yes">
36-
<MsiProperty Name="APPLICATIONFOLDER" Value="[ProgramFilesFolder]Web eID"/>
37-
<MsiProperty Name="CHROMEINSTALL" Value="[ChromeSupport]"/>
38-
<MsiProperty Name="CHROMEPOLICY" Value="[ForceChromeExtensionActivation]"/>
39-
<MsiProperty Name="EDGEINSTALL" Value="[EdgeSupport]"/>
40-
<MsiProperty Name="EDGEPOLICY" Value="[ForceEdgeExtensionActivation]"/>
41-
<MsiProperty Name="FIREFOXINSTALL" Value="[FirefoxSupport]"/>
42-
</MsiPackage>
43-
<MsiPackage Id="WebEID.X64" InstallCondition="VersionNT64" ForcePerMachine="yes"
44-
SourceFile="$(var.webeid).x64.qt.msi" Compressed="yes">
34+
<MsiPackage Id="WebEID" InstallCondition="VersionNT64" ForcePerMachine="yes"
35+
SourceFile="$(var.webeid).qt.msi" Compressed="yes">
4536
<MsiProperty Name="APPLICATIONFOLDER" Value="[ProgramFiles64Folder]Web eID"/>
4637
<MsiProperty Name="CHROMEINSTALL" Value="[ChromeSupport]"/>
4738
<MsiProperty Name="CHROMEPOLICY" Value="[ForceChromeExtensionActivation]"/>

src/app/CMakeLists.txt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ if(WIN32)
2727
get_filename_component(SSL_PATH "${OPENSSL_INCLUDE_DIR}/../bin" ABSOLUTE)
2828
endif()
2929
set(WEBEID_PATH web-eid.exe)
30-
set(BASE_FILE $<TARGET_NAME:web-eid>_${PROJECT_VERSION})
31-
set(MSI_FILE ${BASE_FILE}.${PLATFORM})
30+
set(BASE_FILE $<TARGET_NAME:web-eid>_${PROJECT_VERSION}.${PLATFORM})
3231
list(APPEND CANDLE_CMD "$ENV{WIX}bin\\candle.exe" -nologo -arch ${PLATFORM}
3332
-dMSI_VERSION=${PROJECT_VERSION}
3433
-dPlatform=${PLATFORM}
@@ -49,10 +48,10 @@ if(WIN32)
4948
)
5049
add_custom_target(installer DEPENDS web-eid
5150
COMMAND ${CANDLE_CMD}
52-
COMMAND ${LIGHT_CMD} -o "${MSI_FILE}.msi"
51+
COMMAND ${LIGHT_CMD} -o "${BASE_FILE}.msi"
5352
#Build MSI with QT
5453
COMMAND ${CANDLE_CMD} -dqt_path=${qtCore_install_prefix} -dqt_version_major=${QT_VERSION_MAJOR}
55-
COMMAND ${LIGHT_CMD} -o "${MSI_FILE}.qt.msi"
54+
COMMAND ${LIGHT_CMD} -o "${BASE_FILE}.qt.msi"
5655
WORKING_DIRECTORY $<TARGET_FILE_DIR:web-eid>
5756
)
5857
add_custom_target(bundle
@@ -69,7 +68,7 @@ if(WIN32)
6968
COMMAND_EXPAND_LISTS
7069
)
7170
add_custom_command(TARGET installer POST_BUILD
72-
COMMAND ${SIGNCMD} "${MSI_FILE}.msi" "${MSI_FILE}.qt.msi"
71+
COMMAND ${SIGNCMD} "${BASE_FILE}.msi" "${BASE_FILE}.qt.msi"
7372
WORKING_DIRECTORY $<TARGET_FILE_DIR:web-eid>
7473
)
7574
add_custom_command(TARGET bundle POST_BUILD

0 commit comments

Comments
 (0)