Web eID about

WE2-427

Signed-off-by: Raul Metsma <[email protected]>

Author: metsma

src/controller/application.cpp

@@ -122,7 +122,9 @@ CommandWithArgumentsPtr Application::parseArgs()
         // https://bugs.chromium.org/p/chromium/issues/detail?id=354597#c2
         qDebug() << "Parent window handle is unused" << parser.value(parentWindow);
     }
-
+    if (arguments().size() == 1) {
+        return std::make_unique<CommandWithArguments>(CommandType::ABOUT, QVariantMap());
+    }
     return nullptr;
 }
 

src/controller/commands.hpp

@@ -36,6 +36,7 @@ class CommandType
         AUTHENTICATE,
         SIGN,
         QUIT,
+        ABOUT,
         NONE = -1
     };
 

src/controller/controller.cpp

@@ -89,11 +89,17 @@ void Controller::run()
 
         REQUIRE_NON_NULL(command)
         // If quit is requested, respond with empty JSON object and quit immediately.
-        if (command->first == CommandType::QUIT) {
+        switch (command->first) {
+        case CommandType::ABOUT:
+            WebEidUI::showAboutPage();
+            return;
+        case CommandType::QUIT:
             qInfo() << "Quit requested, exiting";
             writeResponseToStdOut(true, {}, "quit");
             emit quit();
             return;
+        default:
+            break;
         }
 
         commandHandler = getCommandHandler(*command);
@@ -111,8 +117,7 @@ void Controller::startCommandExecution()
 
     // Reader monitor thread setup.
     WaitForCardThread* waitForCardThread = new WaitForCardThread(this);
-    connect(waitForCardThread, &WaitForCardThread::statusUpdate, this,
-            &Controller::onReaderMonitorStatusUpdate);
+    connect(waitForCardThread, &WaitForCardThread::statusUpdate, this, &Controller::statusUpdate);
     connect(waitForCardThread, &WaitForCardThread::cardsAvailable, this,
             &Controller::onCardsAvailable);
     saveChildThreadPtrAndConnectFailureFinish(waitForCardThread);
@@ -210,11 +215,6 @@ void Controller::runCommandHandler(const std::vector<electronic_id::CardInfo::pt
     }
 }
 
-void Controller::onReaderMonitorStatusUpdate(const RetriableError reason)
-{
-    emit statusUpdate(reason);
-}
-
 void Controller::onCertificatesLoaded()
 {
     CardEventMonitorThread* cardEventMonitorThread =

src/controller/controller.hpp

@@ -54,9 +54,6 @@ class Controller : public QObject
     // Called either directly from run() or from the monitor thread when cards are available.
     void onCardsAvailable(const std::vector<electronic_id::CardInfo::ptr>& availableCards);
 
-    // Called on reader and card events from monitor thread.
-    void onReaderMonitorStatusUpdate(const RetriableError reason);
-
     // Called when CommandHandlerRunThread finishes execution.
     void onCertificatesLoaded();
 

src/controller/ui.hpp

@@ -43,6 +43,7 @@ class WebEidUI : public QDialog
     // Factory function that creates and shows the dialog that implements this interface.
     static ptr createAndShowDialog(const CommandType command);
 
+    static void showAboutPage();
     static void showFatalError();
 
     virtual void showWaitingForCardPage(const CommandType commandType) = 0;

src/ui/ui.cpp

@@ -33,6 +33,11 @@ WebEidUI::ptr WebEidUI::createAndShowDialog(const CommandType command)
     return dialog;
 }
 
+void WebEidUI::showAboutPage()
+{
+    WebEidDialog::showAboutPage();
+}
+
 void WebEidUI::showFatalError()
 {
     auto dialog = WebEidDialog {};

tests/mock-ui/mock-ui.cpp

@@ -28,4 +28,5 @@ WebEidUI::ptr WebEidUI::createAndShowDialog(const CommandType)
     return std::make_unique<MockUI>();
 }
 
+void WebEidUI::showAboutPage() {}
 void WebEidUI::showFatalError() {}