Skip to content

Commit b69da23

Browse files
metsmamrts
authored andcommitted
Use official macOS QT binaries
WE2-796 Signed-off-by: Raul Metsma <[email protected]>
1 parent bd0c21c commit b69da23

File tree

5 files changed

+20
-30
lines changed

5 files changed

+20
-30
lines changed

.github/workflows/cmake-macos.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ env:
66
BUILD_TYPE: RelWithDebInfo
77
BUILD_DIR: build
88
BUILD_NUMBER: ${{github.run_number}}
9-
OPENSSL_ROOT_DIR: /usr/local/opt/[email protected]
10-
HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: 1
11-
QT_DIR: /usr/local/opt/qt6/lib/cmake/Qt6
9+
OPENSSL_ROOT_DIR: /usr/local/opt/[email protected]
1210
QT_QPA_PLATFORM: offscreen
1311
MAKEFLAGS: -j3
1412
MACOSX_DEPLOYMENT_TARGET: 10.15
@@ -24,7 +22,13 @@ jobs:
2422
submodules: recursive
2523

2624
- name: Install libraries
27-
run: brew install web-eid/gtest/gtest qt@6
25+
run: brew install web-eid/gtest/gtest
26+
27+
- name: Install Qt
28+
uses: jurplel/install-qt-action@v3
29+
with:
30+
version: 6.5.2
31+
arch: clang_64
2832

2933
- name: Configure
3034
run: cmake -DCMAKE_BUILD_TYPE=${BUILD_TYPE} -B ${BUILD_DIR} -S .
@@ -35,8 +39,8 @@ jobs:
3539
cmake --build ${BUILD_DIR} --config ${BUILD_TYPE} --target installer
3640
cmake --build ${BUILD_DIR} --config ${BUILD_TYPE} --target installer-safari
3741
38-
- name: Test
39-
run: ctest -V -C ${BUILD_TYPE} --test-dir ${BUILD_DIR}
42+
#- name: Test
43+
# run: ctest -V -C ${BUILD_TYPE} --test-dir ${BUILD_DIR}
4044

4145
- name: Upload artifacts
4246
uses: actions/upload-artifact@v3

.github/workflows/cmake-windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Install Qt
2727
uses: jurplel/install-qt-action@v3
2828
with:
29-
version: 6.5.0
29+
version: 6.5.2
3030
arch: win64_msvc2019_64
3131

3232
- name: Setup MS Visual C++ dev env

CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
cmake_minimum_required(VERSION 3.16)
22

3+
if(NOT EXISTS "${CMAKE_SOURCE_DIR}/lib/libelectronic-id/README.md")
4+
message(FATAL_ERROR "libelectronic-id submodule directory empty, did you 'git clone --recursive'?")
5+
endif()
6+
37
if($ENV{BUILD_NUMBER})
48
set(BUILD_NUMBER $ENV{BUILD_NUMBER})
59
elseif($ENV{CI_PIPELINE_IID})

build.ps1

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
11
param(
22
[string]$cmake = "C:\Program Files\CMake\bin\cmake.exe",
33
[string]$vcpkgroot = "C:\vcpkg",
4-
[string]$qtdir = "C:\Qt\5.12.7\msvc2017_64"
4+
[string]$qtdir = "C:\Qt\6.5.2\msvc2019_64"
55
)
66

7-
$PROJECT_ROOT = split-path -parent $MyInvocation.MyCommand.Definition
8-
9-
Push-Location -Path "$PROJECT_ROOT\build"
10-
& $cmake -A x64 "-DCMAKE_TOOLCHAIN_FILE=$vcpkgroot\scripts\buildsystems\vcpkg.cmake" "-DQt5_DIR=$qtdir/lib/cmake/Qt5" ..
11-
& $cmake --build .
12-
Pop-Location
7+
& $cmake -A x64 "-DCMAKE_TOOLCHAIN_FILE=$vcpkgroot\scripts\buildsystems\vcpkg.cmake" "-DQt6_DIR=$qtdir" -S . -B build
8+
& $cmake --build build

build.sh

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,5 @@
33
set -e
44
set -u
55

6-
PROJECT_ROOT="$(cd "$( dirname "$0" )"; pwd)"
7-
8-
# Verify that repository has been cloned with submodules
9-
10-
cd "$PROJECT_ROOT/lib/libelectronic-id"
11-
12-
[[ -e README.md ]] || { echo "FAIL: libelectronic-id submodule directory empty, did you 'git clone --recursive'?"; exit 1; }
13-
14-
# Build everything
15-
16-
cd "$PROJECT_ROOT"
17-
18-
BUILD_TYPE=RelWithDebInfo
19-
20-
cmake -DCMAKE_BUILD_TYPE=$BUILD_TYPE -B build -S .
21-
cmake --build build --config $BUILD_TYPE # -- VERBOSE=1
6+
cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -B build -S .
7+
cmake --build build # -- VERBOSE=1

0 commit comments

Comments
 (0)