Format name only when SN ang GN are available

metsma · mrts · commit f5d9125ce0d7 · 2023-02-13T21:32:37.000+02:00
WE2-738

Signed-off-by: Raul Metsma &lt;raul@metsma.ee&gt;
diff --git a/src/controller/command-handlers/certificatereader.cpp b/src/controller/command-handlers/certificatereader.cpp
@@ -54,7 +54,7 @@ CardCertificateAndPinInfo getCertificateWithStatusAndInfo(const CardInfo::ptr& c
     if(serialNumber.size() > 6 && serialNumber.startsWith(QStringLiteral("PNO")) && serialNumber[5] == '-')
         serialNumber.remove(0, 6);
 
-    if (!givenName.isEmpty() || !surName.isEmpty() || !serialNumber.isEmpty()) {
+    if (!givenName.isEmpty() || !surName.isEmpty()) {
         subject = QStringLiteral("%1, %2, %3").arg(surName, givenName, serialNumber);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ CardCertificateAndPinInfo getCertificateWithStatusAndInfo(const CardInfo::ptr& c`
`54`	`54`	`if(serialNumber.size() > 6 && serialNumber.startsWith(QStringLiteral("PNO")) && serialNumber[5] == '-')`
`55`	`55`	`serialNumber.remove(0, 6);`
`56`	`56`
`57`		`- if (!givenName.isEmpty() \|\| !surName.isEmpty() \|\| !serialNumber.isEmpty()) {`
	`57`	`+ if (!givenName.isEmpty() \|\| !surName.isEmpty()) {`
`58`	`58`	`subject = QStringLiteral("%1, %2, %3").arg(surName, givenName, serialNumber);`
`59`	`59`	`}`
`60`	`60`