Skip to content

Commit 016dda8

Browse files
NFC-47 Review findings. Extract USER role.
1 parent 444a6af commit 016dda8

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

example/src/main/java/eu/webeid/example/config/ApplicationConfiguration.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import eu.webeid.example.security.AuthTokenDTOAuthenticationProvider;
2626
import eu.webeid.example.security.WebEidAjaxLoginProcessingFilter;
2727
import eu.webeid.example.security.ui.WebEidLoginPageGeneratingFilter;
28+
import org.springframework.boot.autoconfigure.security.servlet.PathRequest;
2829
import org.springframework.context.annotation.Bean;
2930
import org.springframework.context.annotation.Configuration;
3031
import org.springframework.http.HttpMethod;
@@ -51,12 +52,14 @@ public SecurityFilterChain filterChain(HttpSecurity http, AuthTokenDTOAuthentica
5152

5253
return http
5354
.authorizeHttpRequests(auth -> auth
55+
.requestMatchers(PathRequest.toStaticResources().atCommonLocations()).permitAll()
5456
.requestMatchers("/", "/error").permitAll()
5557
.requestMatchers(HttpMethod.GET, "/auth/eid/login").permitAll()
5658
.requestMatchers("/auth/challenge").permitAll()
5759
.requestMatchers(HttpMethod.POST, "/auth/mobile/auth/init").permitAll()
58-
.requestMatchers("/favicon.ico", "/css/**", "/files/**", "/img/**", "/js/**").permitAll()
59-
.anyRequest().authenticated()
60+
.requestMatchers("/auth/login").permitAll()
61+
.requestMatchers("/welcome").hasRole("USER")
62+
.anyRequest().permitAll()
6063
)
6164
.authenticationProvider(authTokenDTOAuthenticationProvider)
6265
.addFilterBefore(new WebEidLoginPageGeneratingFilter(), UsernamePasswordAuthenticationFilter.class)

example/src/main/java/eu/webeid/example/security/ui/WebEidLoginPageGeneratingFilter.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ protected void doFilterInternal(@NonNull HttpServletRequest request, @NonNull Ht
7474
response.getWriter().write(html);
7575
}
7676

77-
7877
private String generateHtml(String csrfToken, String csrfHeaderName) {
7978
return String.format(LOGIN_PAGE_HTML, csrfToken, csrfHeaderName);
8079
}

0 commit comments

Comments
 (0)