Redundant successfulAuthentication override

Author: aarmam

example/src/main/java/eu/webeid/example/security/WebEidAjaxLoginProcessingFilter.java

@@ -27,8 +27,6 @@
 import eu.webeid.example.security.ajax.AjaxAuthenticationFailureHandler;
 import eu.webeid.example.security.ajax.AjaxAuthenticationSuccessHandler;
 import eu.webeid.security.authtoken.WebEidAuthToken;
-import jakarta.servlet.FilterChain;
-import jakarta.servlet.ServletException;
 import jakarta.servlet.http.HttpServletRequest;
 import jakarta.servlet.http.HttpServletResponse;
 import org.slf4j.Logger;
@@ -41,20 +39,17 @@
 import org.springframework.security.authentication.BadCredentialsException;
 import org.springframework.security.core.Authentication;
 import org.springframework.security.core.AuthenticationException;
-import org.springframework.security.core.context.SecurityContextHolder;
 import org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter;
 import org.springframework.security.web.authentication.preauth.PreAuthenticatedAuthenticationToken;
 import org.springframework.security.web.authentication.session.SessionFixationProtectionStrategy;
 import org.springframework.security.web.context.HttpSessionSecurityContextRepository;
-import org.springframework.security.web.context.SecurityContextRepository;
 import org.springframework.security.web.servlet.util.matcher.PathPatternRequestMatcher;
 
 import java.io.IOException;
 
 public class WebEidAjaxLoginProcessingFilter extends AbstractAuthenticationProcessingFilter {
     private static final Logger LOG = LoggerFactory.getLogger(WebEidAjaxLoginProcessingFilter.class);
     private final ObjectReader OBJECT_READER = new ObjectMapper().readerFor(WebEidAuthToken.class);
-    private final SecurityContextRepository securityContextRepository;
 
     public WebEidAjaxLoginProcessingFilter(
         String defaultFilterProcessesUrl,
@@ -64,8 +59,8 @@ public WebEidAjaxLoginProcessingFilter(
         this.setAuthenticationManager(authenticationManager);
         this.setAuthenticationSuccessHandler(new AjaxAuthenticationSuccessHandler());
         this.setAuthenticationFailureHandler(new AjaxAuthenticationFailureHandler());
-        setSessionAuthenticationStrategy(new SessionFixationProtectionStrategy());
-        this.securityContextRepository = new HttpSessionSecurityContextRepository();
+        this.setSessionAuthenticationStrategy(new SessionFixationProtectionStrategy());
+        this.setSecurityContextRepository(new HttpSessionSecurityContextRepository());
     }
 
     @Override
@@ -92,10 +87,4 @@ private WebEidAuthToken parseWebEidAuthToken(HttpServletRequest request) {
             throw new BadCredentialsException("Unable to authenticate the Web eID authentication token", e);
         }
     }
-
-    @Override
-    protected void successfulAuthentication(HttpServletRequest request, HttpServletResponse response, FilterChain chain, Authentication authResult) throws IOException, ServletException {
-        super.successfulAuthentication(request, response, chain, authResult);
-        securityContextRepository.saveContext(SecurityContextHolder.getContext(), request, response);
-    }
 }