Skip to content

Commit 85ba23b

Browse files
authored
fix(report): manual log error message and stack when error stringify failed (#1003)
1 parent bec7621 commit 85ba23b

File tree

1 file changed

+23
-2
lines changed

1 file changed

+23
-2
lines changed

apps/report/src/components/detail-side.tsx

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,28 @@ const DetailSide = (): JSX.Element => {
327327
/>
328328
);
329329
});
330-
} else if (task?.error) {
330+
} else if (task?.error || task?.errorMessage) {
331+
let errorContent = '';
332+
333+
// prefer errorMessage
334+
if (task.errorMessage) {
335+
errorContent = task.errorMessage;
336+
} else if (task.error) {
337+
// if no errorMessage, try to show error object
338+
if (typeof task.error === 'string') {
339+
errorContent = task.error;
340+
} else if (typeof task.error === 'object' && task.error.message) {
341+
errorContent = task.error.message;
342+
} else {
343+
errorContent = JSON.stringify(task.error, null, 2) || 'Unknown error';
344+
}
345+
}
346+
347+
// add stack info (if exists and not duplicate)
348+
if (task.errorStack && !errorContent.includes(task.errorStack)) {
349+
errorContent += `\n\nStack:\n${task.errorStack}`;
350+
}
351+
331352
outputDataContent = (
332353
<Card
333354
liteMode={true}
@@ -336,7 +357,7 @@ const DetailSide = (): JSX.Element => {
336357
onMouseLeave={noop}
337358
content={
338359
<pre className="description-content" style={{ color: '#F00' }}>
339-
{task.error}
360+
{errorContent}
340361
</pre>
341362
}
342363
/>

0 commit comments

Comments
 (0)