Skip to content

Commit 99cb310

Browse files
authored
fix(report): update assert failure condition in sidebar component to include task subtype (#1038)
1 parent d3a22e6 commit 99cb310

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

apps/report/src/components/sidebar.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,11 @@ const SideItem = (props: {
6767

6868
const statusIcon = (() => {
6969
const isFinished = task.status === 'finished';
70-
const isAssertFailed = isFinished && task.output === false;
70+
const isAssertionFailed =
71+
isFinished && task.subType === 'Assert' && task.output === false;
7172
const hasError = isFinished && (task.error || task.errorMessage);
7273

73-
if (isAssertFailed) return iconForStatus('failed');
74+
if (isAssertionFailed) return iconForStatus('failed');
7475

7576
if (hasError) return iconForStatus('finishedWithWarning');
7677

packages/web-integration/src/common/page.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export interface AndroidDevicePage extends AbstractPage {
4949

5050
export type AndroidDeviceInputOpt = {
5151
autoDismissKeyboard?: boolean;
52-
hideKeyboardStrategy?: 'esc-first' | 'back-first';
52+
keyboardDismissStrategy?: 'esc-first' | 'back-first';
5353
};
5454

5555
export type WebPage =

0 commit comments

Comments
 (0)