Skip to content

Commit fff9332

Browse files
authored
chore(chrome-extension): external sharp to avoid warnings in dev (#1004)
1 parent edd6977 commit fff9332

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

apps/chrome-extension/rsbuild.config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ export default defineConfig({
6767
},
6868
],
6969
sourceMap: true,
70+
externals: ['sharp'],
7071
},
7172
source: {
7273
define: {

packages/shared/modern.config.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,11 @@ export default defineConfig({
2626
env: './src/env.ts',
2727
types: './src/types/index.ts',
2828
},
29-
externals: ['sharp'],
29+
/**
30+
* It is unnecessary to declare externals here.
31+
* By default, third-party dependencies under "dependencies" and "peerDependencies" are not bundled by Modern.js Module.
32+
* ref: https://modernjs.dev/module-tools/en/guide/advance/external-dependency.html#default-handling-of-third-party-dependencies
33+
*/
3034
target: 'es2020',
3135
dts: {
3236
respectExternal: true,

0 commit comments

Comments
 (0)