chore(utils): move generateMetaTags method to builder-shared (#3678)

* chore(utils): move generateMetaTags method to builder-shared

* chore: update type

* chore: fix typing

Author: chenjiahan

.changeset/beige-pandas-switch.md

@@ -0,0 +1,9 @@
+---
+'@modern-js/builder-shared': patch
+'@modern-js/main-doc': patch
+'@modern-js/utils': patch
+---
+
+chore(utils): move generateMetaTags method to builder-shared
+
+chore(utils): 移动 generateMetaTags 方法到 builder-shared

README.md

@@ -64,11 +64,10 @@ Some implementations of Modern.js are modified from existing projects, such as [
 
 - `@modern-js/bundle-require`: is modified from [bundle-require](https://github.com/egoist/bundle-require).
 - `@modern-js/plugin`: the hooks API is referenced from [farrow-pipeline](https://github.com/farrow-js/farrow/tree/master/packages/farrow-pipeline).
-- `@modern-js/builder`: the moduleScope and fileSize plugins are referenced from [create-react-app](https://github.com/facebook/create-react-app), the TsConfigPathsPlugin is referenced from [tsconfig-paths-webpack-plugin](https://github.com/dividab/tsconfig-paths-webpack-plugin)。
+- `@modern-js/builder`: the moduleScope and fileSize plugins are referenced from [create-react-app](https://github.com/facebook/create-react-app), the TsConfigPathsPlugin is referenced from [tsconfig-paths-webpack-plugin](https://github.com/dividab/tsconfig-paths-webpack-plugin), the generateMetaTags function is referenced from [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin).
 - `@modern-js/plugin-testing`: the jest runner is referenced from [jest-cli](https://github.com/facebook/jest/blob/fdc74af37235354e077edeeee8aa2d1a4a863032/packages/jest-cli/src/cli/index.ts#L21).
 - `@modern-js/plugin-data-loader`: some code is referenced from [remix](https://github.com/remix-run/remix)。
 - `@modern-js/doc-tools`: some styles are referenced from [vitepress](https://github.com/vuejs/vitepress).
-- `@modern-js/utils`: the generateMetaTags function is referenced from [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin).
 
 ## License
 

README.zh-CN.md

@@ -64,11 +64,10 @@ Modern.js 中的部分代码是参考社区中的其他项目实现的，比如
 
 - `@modern-js/bundle-require`: 修改自 [bundle-require](https://github.com/egoist/bundle-require)。
 - `@modern-js/plugin`: hook API 的实现参考了 [farrow-pipeline](https://github.com/farrow-js/farrow/tree/master/packages/farrow-pipeline)。
-- `@modern-js/builder`: moduleScope 和 fileSize 插件参考了 [create-react-app](https://github.com/facebook/create-react-app)，TsConfigPathsPlugin 参考了 [tsconfig-paths-webpack-plugin](https://github.com/dividab/tsconfig-paths-webpack-plugin)。
+- `@modern-js/builder`: moduleScope 和 fileSize 插件参考了 [create-react-app](https://github.com/facebook/create-react-app)，TsConfigPathsPlugin 参考了 [tsconfig-paths-webpack-plugin](https://github.com/dividab/tsconfig-paths-webpack-plugin)，generateMetaTags 函数参考了 [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin)
 - `@modern-js/plugin-testing`: jest runner 参考了 [jest-cli](https://github.com/facebook/jest/blob/fdc74af37235354e077edeeee8aa2d1a4a863032/packages/jest-cli/src/cli/index.ts#L21)。
 - `@modern-js/doc-tools`: 部分样式参考了 [vitepress](https://github.com/vuejs/vitepress)。
 - `@modern-js/plugin-data-loader`: 部分实现参考了 [remix](https://github.com/remix-run/remix)。
-- `@modern-js/utils`: generateMetaTags 函数参考了 [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin)。
 
 ## License
 

packages/builder/builder-shared/src/config.ts

@@ -14,6 +14,7 @@ import {
   DEFAULT_MOUNT_ID,
   DEFAULT_DATA_URL_SIZE,
 } from './constants';
+import { generateMetaTags } from './generateMetaTags';
 import type {
   BuilderTarget,
   SharedHtmlConfig,
@@ -270,7 +271,6 @@ export async function getMetaTags(
   entryName: string,
   config: { html: SharedHtmlConfig; output: NormalizedSharedOutputConfig },
 ) {
-  const { generateMetaTags } = await import('@modern-js/utils');
   const { meta, metaByEntries } = config.html;
 
   const metaOptions = {

packages/toolkit/utils/src/cli/generateMetaTags.ts renamed to packages/builder/builder-shared/src/generateMetaTags.ts

@@ -1,4 +1,3 @@
-// Todo: only @modern-js/builder-shared used
 /**
  * Copyright JS Foundation and other contributors.
  *

packages/builder/builder-shared/src/index.ts

@@ -5,6 +5,7 @@ export * from './createPluginStore';
 export * from './createContext';
 export * from './utils';
 export * from './fs';
+export * from './generateMetaTags';
 export * from './getBrowserslist';
 export * from './getCssSupport';
 export * from './logger';

packages/builder/builder-shared/src/schema/html.ts

@@ -1,4 +1,4 @@
-import { MetaAttributes, MetaOptions } from '@modern-js/utils';
+import { MetaAttributes, MetaOptions } from '../generateMetaTags';
 import {
   CrossOrigin,
   HtmlInjectTag,

packages/builder/builder-shared/src/types/config/html.ts

@@ -1,4 +1,4 @@
-import type { MetaOptions } from '@modern-js/utils';
+import type { MetaOptions } from '../../generateMetaTags';
 import type { ArrayOrNot, ChainedConfig } from '../utils';
 
 export type CrossOrigin = 'anonymous' | 'use-credentials';

packages/toolkit/utils/tests/generateMetaTags.test.ts renamed to packages/builder/builder-shared/tests/generateMetaTags.test.ts

@@ -1,4 +1,5 @@
-import { generateMetaTags } from '../src';
+import { expect, describe, it } from 'vitest';
+import { generateMetaTags } from '../src/generateMetaTags';
 
 describe('generateMetaTags', () => {
   it('should return empty string when params is empty', () => {

packages/document/main-doc/docs/zh/community/blog/v2-release-note.mdx

@@ -234,11 +234,10 @@ Modern.js 中的部分代码实现参考了社区中的开源项目，我们对
 
 - `@modern-js/bundle-require`: 修改自 [bundle-require](https://github.com/egoist/bundle-require)。
 - `@modern-js/plugin`: hook API 的实现参考了 [farrow-pipeline](https://github.com/farrow-js/farrow/tree/master/packages/farrow-pipeline)。
-- `@modern-js/builder`: moduleScope 和 fileSize 插件参考了 [create-react-app](https://github.com/facebook/create-react-app)，TsConfigPathsPlugin 参考了 [tsconfig-paths-webpack-plugin](https://github.com/dividab/tsconfig-paths-webpack-plugin)。
+- `@modern-js/builder`: moduleScope 和 fileSize 插件参考了 [create-react-app](https://github.com/facebook/create-react-app)，TsConfigPathsPlugin 参考了 [tsconfig-paths-webpack-plugin](https://github.com/dividab/tsconfig-paths-webpack-plugin)，generateMetaTags 函数参考了 [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin)。
 - `@modern-js/plugin-testing`: jest runner 参考了 [jest-cli](https://github.com/facebook/jest/blob/fdc74af37235354e077edeeee8aa2d1a4a863032/packages/jest-cli/src/cli/index.ts#L21)。
 - `@modern-js/doc-tools`: 部分样式参考了 [vitepress](https://github.com/vuejs/vitepress)。
 - `@modern-js/plugin-data-loader`: 部分实现参考了 [remix](https://github.com/remix-run/remix)。
-- `@modern-js/utils`: generateMetaTags 函数参考了 [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin)。
 
 ## 最后