feat(builder): support output.disableTsChecker in rspack (#3751)

* feat: support output.disableTsChecker in rspack

* docs: add changeset

* Update packages/builder/builder/src/plugins/tsChecker.ts

Co-authored-by: neverland <[email protected]>

* fix: log & remove duplicate deps

* fix: snapshot update

---------

Co-authored-by: neverland <[email protected]>

Author: 9aoy

.changeset/neat-fans-think.md

@@ -0,0 +1,8 @@
+---
+'@modern-js/builder-rspack-provider': patch
+'@modern-js/builder': patch
+---
+
+feat(builder): support output.disableTsChecker in Rspack
+
+feat(builder): 在使用 Rspack 构建时支持 output.disableTsChecker 配置项

packages/builder/builder-rspack-provider/src/core/createCompiler.ts

@@ -26,10 +26,12 @@ export async function createCompiler({
       timings: true,
     });
 
-    obj.children?.forEach(c => {
-      c.time &&
-        logger.success(`${c.name} compiled successfully in`, c.time, 'ms');
-    });
+    if (!stats.hasErrors()) {
+      obj.children?.forEach(c => {
+        c.time &&
+          logger.success(`${c.name} compiled successfully in`, c.time, 'ms');
+      });
+    }
 
     const { message, level } = await formatStats(stats);
 

packages/builder/builder-rspack-provider/src/shared/plugin.ts

@@ -20,6 +20,7 @@ export const applyDefaultPlugins = (plugins: Plugins) =>
     plugins.media(),
     plugins.svg(),
     plugins.html(),
+    plugins.tsChecker(),
     // pug plugin should after html plugin
     import('../plugins/pug').then(m => m.builderPluginPug()),
     import('../plugins/babel').then(m => m.builderPluginBabel()),

packages/builder/builder-rspack-provider/tests/plugins/__snapshots__/default.test.ts.snap

@@ -650,6 +650,29 @@ exports[`applyDefaultPlugins > should apply default plugins correctly 1`] = `
     "publicPath": "/",
   },
   "plugins": [
+    ForkTsCheckerWebpackPlugin {
+      "options": {
+        "issue": {
+          "exclude": [
+            {
+              "file": "**/*.(spec|test).ts",
+            },
+            {
+              "file": "**/node_modules/**/*",
+            },
+          ],
+        },
+        "logger": {
+          "error": [Function],
+          "log": [Function],
+        },
+        "typescript": {
+          "configFile": "<ROOT>/tsconfig.json",
+          "memoryLimit": 8192,
+          "typescriptPath": "<WORKSPACE>/node_modules/<PNPM_INNER>/typescript/lib/typescript.js",
+        },
+      },
+    },
     RspackVirtualModulePlugin {},
   ],
   "resolve": {
@@ -1326,6 +1349,29 @@ exports[`applyDefaultPlugins > should apply default plugins correctly when prod
     "publicPath": "/",
   },
   "plugins": [
+    ForkTsCheckerWebpackPlugin {
+      "options": {
+        "issue": {
+          "exclude": [
+            {
+              "file": "**/*.(spec|test).ts",
+            },
+            {
+              "file": "**/node_modules/**/*",
+            },
+          ],
+        },
+        "logger": {
+          "error": [Function],
+          "log": [Function],
+        },
+        "typescript": {
+          "configFile": "<ROOT>/tsconfig.json",
+          "memoryLimit": 8192,
+          "typescriptPath": "<WORKSPACE>/node_modules/<PNPM_INNER>/typescript/lib/typescript.js",
+        },
+      },
+    },
     RspackVirtualModulePlugin {},
     InlineChunkHtmlPlugin {
       "distPath": {
@@ -1743,6 +1789,31 @@ exports[`applyDefaultPlugins > should apply default plugins correctyly when targ
     "pathinfo": false,
     "publicPath": "/",
   },
+  "plugins": [
+    ForkTsCheckerWebpackPlugin {
+      "options": {
+        "issue": {
+          "exclude": [
+            {
+              "file": "**/*.(spec|test).ts",
+            },
+            {
+              "file": "**/node_modules/**/*",
+            },
+          ],
+        },
+        "logger": {
+          "error": [Function],
+          "log": [Function],
+        },
+        "typescript": {
+          "configFile": "<ROOT>/tsconfig.json",
+          "memoryLimit": 8192,
+          "typescriptPath": "<WORKSPACE>/node_modules/<PNPM_INNER>/typescript/lib/typescript.js",
+        },
+      },
+    },
+  ],
   "resolve": {
     "conditionNames": [
       "require",
@@ -2423,6 +2494,29 @@ exports[`tools.rspack > should match snapshot 1`] = `
     TestPlugin {
       "name": "TestPlugin",
     },
+    ForkTsCheckerWebpackPlugin {
+      "options": {
+        "issue": {
+          "exclude": [
+            {
+              "file": "**/*.(spec|test).ts",
+            },
+            {
+              "file": "**/node_modules/**/*",
+            },
+          ],
+        },
+        "logger": {
+          "error": [Function],
+          "log": [Function],
+        },
+        "typescript": {
+          "configFile": "<ROOT>/tsconfig.json",
+          "memoryLimit": 8192,
+          "typescriptPath": "<WORKSPACE>/node_modules/<PNPM_INNER>/typescript/lib/typescript.js",
+        },
+      },
+    },
     RspackVirtualModulePlugin {},
   ],
   "resolve": {

packages/builder/builder-shared/package.json

@@ -37,6 +37,10 @@
       "jsnext:source": "./src/index.ts",
       "default": "./dist/index.js"
     },
+    "./fork-ts-checker-webpack-plugin": {
+      "jsnext:source": "./src/exports/fork-ts-checker-webpack-plugin.ts",
+      "default": "./dist/exports/fork-ts-checker-webpack-plugin.js"
+    },
     "./open": {
       "types": "./compiled/open/index.d.ts",
       "default": "./compiled/open/index.js"
@@ -70,6 +74,9 @@
       "open": [
         "./compiled/open/index.d.ts"
       ],
+      "fork-ts-checker-webpack-plugin": [
+        "./dist/exports/fork-ts-checker-webpack-plugin.d.ts"
+      ],
       "webpack-bundle-analyzer": [
         "./compiled/webpack-bundle-analyzer/index.d.ts"
       ],
@@ -96,6 +103,7 @@
     "@modern-js/types": "workspace:*",
     "@modern-js/utils": "workspace:*",
     "@babel/core": "^7.21.8",
+    "fork-ts-checker-webpack-plugin": "8.0.0",
     "acorn": "^8.8.1",
     "caniuse-lite": "^1.0.30001451",
     "cheerio": "1.0.0-rc.12",
@@ -127,6 +135,7 @@
       "./webpack-5-chain": "./compiled/webpack-5-chain/index.js",
       "./test-stub": "./dist/test-stub/index.js",
       "./zod": "./dist/exports/zod.js",
+      "./fork-ts-checker-webpack-plugin": "./dist/exports/fork-ts-checker-webpack-plugin.js",
       "./pug": "./compiled/pug/index.js"
     }
   }

packages/builder/builder-shared/src/exports/fork-ts-checker-webpack-plugin.ts

@@ -0,0 +1,3 @@
+import ForkTsCheckerWebpackPlugin from 'fork-ts-checker-webpack-plugin';
+
+export default ForkTsCheckerWebpackPlugin;

packages/builder/builder-shared/src/test-stub/helper.ts

@@ -29,5 +29,6 @@ export const mockBuilderPlugins: Plugins = {
   svg: genMockPlugin('builder-plugin-svg'),
   html: genMockPlugin('builder-plugin-html'),
   antd: genMockPlugin('antd'),
+  tsChecker: genMockPlugin('builder-plugin-ts-checker'),
   checkSyntax: genMockPlugin('builder-plugin-check-syntax'),
 };

packages/builder/builder-shared/src/types/bundlerConfig.ts

@@ -157,6 +157,7 @@ export interface BundlerChain
     | 'externalsType'
     | 'externalsPresets'
     | 'entry'
+    | 'get'
   > {
   toConfig: () => BundlerConfig;
   optimization: PickAndModifyThis<

packages/builder/builder-shared/src/types/config/tools.ts

@@ -9,6 +9,7 @@ import type {
   SassLoaderOptions,
   LessLoaderOptions,
   PugOptions,
+  ForkTSCheckerOptions,
 } from '../thirdParty';
 import { BundlerChain } from '../bundlerConfig';
 import { ModifyChainUtils } from '../hooks';
@@ -41,6 +42,8 @@ export type ToolsBabelConfig = ChainedConfig<
 
 export type ToolsPugConfig = true | ChainedConfig<PugOptions>;
 
+export type ToolsTSCheckerConfig = ChainedConfig<ForkTSCheckerOptions>;
+
 export interface SharedToolsConfig {
   /**
    * Configure bundler config base on [webpack-chain](https://github.com/neutrinojs/webpack-chain)
@@ -71,4 +74,8 @@ export interface SharedToolsConfig {
    * Configure the [Pug](https://pugjs.org/) template engine.
    */
   pug?: ToolsPugConfig;
+  /**
+   * Modify the options of [fork-ts-checker-webpack-plugin](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin).
+   */
+  tsChecker?: ToolsTSCheckerConfig;
 }

packages/builder/builder-shared/src/types/plugin.ts

@@ -52,6 +52,7 @@ export type Plugins = {
   svg: PluginsFn;
   html: PluginsFn;
   antd: PluginsFn;
+  tsChecker: PluginsFn;
   checkSyntax: PluginsFn;
 };