refactor: remove bff function mode

Author: yimingjfe

packages/cli/plugin-bff/src/server.ts

@@ -142,14 +142,11 @@ export default (): ServerPlugin => ({
         prefix,
         httpMethodDecider,
       });
-      const apiMode = apiRouter.getApiMode();
-
       const apiHandlerInfos = await apiRouter.getApiHandlers();
       api.updateServerContext({
         ...appContext,
         apiRouter,
         apiHandlerInfos,
-        apiMode,
       });
       return next(input);
     }) as any);

packages/server/bff-core/src/router/constants.ts

@@ -2,18 +2,6 @@ import { HttpMethod } from '../types';
 
 export const AllHttpMethods = Object.values(HttpMethod) as string[];
 
-export enum APIMode {
-  /**
-   * 框架模式
-   */
-  FARMEWORK = 'framework',
-
-  /**
-   * 函数模式
-   */
-  FUNCTION = 'function',
-}
-
 export const FRAMEWORK_MODE_LAMBDA_DIR = 'lambda';
 
 export const FRAMEWORK_MODE_APP_DIR = 'app';

packages/server/bff-core/src/router/index.ts

@@ -5,7 +5,6 @@ import type { HttpMethodDecider } from '@modern-js/types';
 import { HttpMethod, OperatorType, TriggerType, httpMethods } from '../types';
 import { INPUT_PARAMS_DECIDER, debug } from '../utils';
 import {
-  APIMode,
   API_FILE_RULES,
   FRAMEWORK_MODE_APP_DIR,
   FRAMEWORK_MODE_LAMBDA_DIR,
@@ -22,8 +21,6 @@ export * from './types';
 export * from './constants';
 
 export class ApiRouter {
-  private apiMode: APIMode;
-
   private appDir?: string;
 
   private apiDir: string;
@@ -64,7 +61,6 @@ export class ApiRouter {
     this.apiDir = apiDir;
     this.httpMethodDecider = httpMethodDecider;
     this.isBuild = isBuild;
-    this.apiMode = this.getExactApiMode(apiDir, lambdaDir);
     this.lambdaDir = this.getExactLambdaDir(this.apiDir, lambdaDir);
     this.existLambdaDir = fs.existsSync(this.lambdaDir);
     debug(`apiDir:`, this.apiDir, `lambdaDir:`, this.lambdaDir);
@@ -74,10 +70,6 @@ export class ApiRouter {
     return this.existLambdaDir;
   }
 
-  public getApiMode() {
-    return this.apiMode;
-  }
-
   public getLambdaDir() {
     return this.lambdaDir;
   }
@@ -261,32 +253,10 @@ export class ApiRouter {
     }
   }
 
-  private getExactApiMode = (apiDir: string, lambdaDir?: string): APIMode => {
-    const exist = this.createExistChecker(apiDir);
-    const existLambdaDir =
-      (lambdaDir && fs.pathExistsSync(lambdaDir)) ||
-      exist(FRAMEWORK_MODE_LAMBDA_DIR);
-    const existAppDir = exist(FRAMEWORK_MODE_APP_DIR);
-    const existAppFile = exist('app.ts') || exist('app.js');
-
-    if (existLambdaDir || existAppDir || existAppFile) {
-      return APIMode.FARMEWORK;
-    }
-
-    return APIMode.FUNCTION;
-  };
-
-  private createExistChecker = (base: string) => (target: string) =>
-    fs.pathExistsSync(path.resolve(base, target));
-
   private getExactLambdaDir = (
     apiDir: string,
     originLambdaDir?: string,
   ): string => {
-    if (this.apiMode === APIMode.FUNCTION) {
-      return apiDir;
-    }
-
     return originLambdaDir || path.join(apiDir, FRAMEWORK_MODE_LAMBDA_DIR);
   };
 

packages/server/bff-core/tests/fixtures/function/[id]/origin/bar.ts renamed to packages/server/bff-core/tests/fixtures/function/lambda/[id]/origin/bar.ts

@@ -1,4 +1,4 @@
-import { Api, Put } from '../../../../../src';
+import { Api, Put } from '../../../../../../src';
 
 const getOrigin = ({ query: { id } }: { query: { id: string } }) => ({ id });