feat(rspack-provider): support security.checkSyntax in Rspack (#3685)

* fix: support check-syntax in rspack

* fix: lock

* docs: update checkSyntax doc

* fix: move security.sri from shared to webpack-provider

* fix: pure deps

* fix: type SharedSecurityConfig

Author: 9aoy

.changeset/gentle-adults-move.md

@@ -0,0 +1,9 @@
+---
+'@modern-js/builder-rspack-provider': patch
+'@modern-js/builder-shared': patch
+'@modern-js/builder': patch
+---
+
+feat(rspack-provider): support security.checkSyntax in Rspack
+
+feat(rspack-provider): 在使用 Rspack 构建时支持 security.checkSyntax 配置项

packages/builder/builder-rspack-provider/src/config/defaults.ts

@@ -22,6 +22,7 @@ export const createDefaultConfig = () =>
     output: getDefaultOutputConfig(),
     tools: {},
     security: {
+      checkSyntax: false,
       nonce: '',
       // sri: false
     },

packages/builder/builder-rspack-provider/src/shared/plugin.ts

@@ -43,5 +43,6 @@ export const applyDefaultPlugins = (plugins: Plugins) =>
     plugins.inlineChunk(),
     plugins.bundleAnalyzer(),
     plugins.assetsRetry(),
+    plugins.checkSyntax(),
     import('../plugins/fallback').then(m => m.builderPluginFallback()), // fallback should be the last plugin
   ]);

packages/builder/builder-rspack-provider/src/types/config/security.ts

@@ -1,16 +1,8 @@
-// Todo support security.sri configuration
-/**
- * Currently, rspack does not support the security.sri configuration.
- * But it should because it's a shared configuration.
- */
-// import type { SharedSecurityConfig } from '@modern-js/builder-shared';
+import type {
+  SharedSecurityConfig,
+  NormalizedSharedSecurityConfig,
+} from '@modern-js/builder-shared';
 
-// export type SecurityConfig = SharedSecurityConfig;
+export type SecurityConfig = SharedSecurityConfig;
 
-// export type NormalizedSecurityConfig = Required<SecurityConfig>;
-
-export interface SecurityConfig {
-  nonce?: string;
-}
-
-export type NormalizedSecurityConfig = Required<SecurityConfig>;
+export type NormalizedSecurityConfig = NormalizedSharedSecurityConfig;

packages/builder/builder-shared/package.json

@@ -96,6 +96,10 @@
     "@modern-js/types": "workspace:*",
     "@modern-js/utils": "workspace:*",
     "@babel/core": "^7.21.8",
+    "acorn": "^8.8.1",
+    "caniuse-lite": "^1.0.30001451",
+    "cheerio": "1.0.0-rc.12",
+    "source-map": "^0.7.4",
     "webpack-sources": "^3.2.3",
     "zod": "^3.20.2",
     "zod-validation-error": "^0.3.0"
@@ -104,6 +108,7 @@
     "@babel/preset-env": "^7.21.5",
     "@scripts/vitest-config": "workspace:*",
     "@types/babel__core": "^7.20.0",
+    "@types/caniuse-lite": "^1.0.1",
     "@types/node": "^14",
     "html-webpack-plugin": "5.5.0",
     "terser": "^5.14.1",

packages/builder/builder-webpack-provider/src/webpackPlugins/CheckSyntaxPlugin/helpers/generateError.ts renamed to packages/builder/builder-shared/src/plugins/CheckSyntaxPlugin/helpers/generateError.ts

@@ -1,6 +1,6 @@
 import { SyntaxError } from './type';
 import chalk from '@modern-js/utils/chalk';
-import { logger } from '@modern-js/builder-shared';
+import { logger } from '../../../logger';
 
 type Error = {
   source: string;