refactor!: remove @modern-js/rsbuild-plugin-esbuild (#7334)

Author: chenjiahan

packages/cli/plugin-swc/src/index.ts

@@ -22,13 +22,9 @@ export function factory(
         }
 
         const config = api.useResolvedConfigContext();
-        const { esbuild, swc = {} } = config.tools;
+        const { swc = {} } = config.tools;
         const swcOptions = modifySwcOptions(swc);
-        const finalConfig = applyBuilderSwcConfig(
-          swcOptions,
-          esbuild,
-          isSSR(config),
-        );
+        const finalConfig = applyBuilderSwcConfig(swcOptions, isSSR(config));
 
         context.builder.addPlugins([
           pluginSwc(
@@ -45,7 +41,6 @@ export function factory(
 
 export function applyBuilderSwcConfig(
   swc: PluginSwcOptions,
-  esbuild: ToolsUserConfig['esbuild'] | undefined,
   isSSR: boolean,
 ): PluginSwcOptions {
   // common configuration
@@ -57,20 +52,7 @@ export function applyBuilderSwcConfig(
     });
   }
 
-  return applyConfig(swcConfig, config => {
-    if (esbuild) {
-      if (config.jsMinify !== false && esbuild.minimize !== false) {
-        logger.warn(
-          'You have enabled both esbuild minimizer and SWC minimizer, which will cause conflicts. Please remove `tools.esbuild` config and only use SWC to minimize your code.',
-        );
-      }
-      if (esbuild.loader !== false) {
-        logger.warn(
-          'You have enabled both esbuild loader and SWC loader, which will cause conflicts. Please remove `tools.esbuild` config and only use SWC to transform your code.',
-        );
-      }
-    }
-  });
+  return applyConfig(swcConfig, () => {});
 }
 
 const PLUGIN_NAME = '@modern-js/plugin-swc';

packages/cli/plugin-swc/tests/index.test.ts

@@ -8,23 +8,15 @@ import { applyBuilderSwcConfig } from '../src';
 describe('plugin config', () => {
   it('should enable loadableComponents', () => {
     {
-      const config = applyBuilderSwcConfig(
-        {},
-        undefined,
-        true,
-      ) as ObjPluginSwcOptions;
+      const config = applyBuilderSwcConfig({}, true) as ObjPluginSwcOptions;
 
       expect(config.extensions!.loadableComponents).toBeTruthy();
     }
 
     {
-      const config = applyBuilderSwcConfig(
-        config => {
-          expect(config.extensions!.loadableComponents).toBeTruthy();
-        },
-        undefined,
-        true,
-      ) as FnPluginSwcOptions;
+      const config = applyBuilderSwcConfig(config => {
+        expect(config.extensions!.loadableComponents).toBeTruthy();
+      }, true) as FnPluginSwcOptions;
 
       config({}, null as any);
     }
@@ -37,11 +29,10 @@ describe('plugin config', () => {
       count++;
     };
 
-    applyBuilderSwcConfig({}, { minimize: {} }, true) as ObjPluginSwcOptions;
+    applyBuilderSwcConfig({}, true) as ObjPluginSwcOptions;
 
     const config = applyBuilderSwcConfig(
       _config => _config,
-      undefined,
       true,
     ) as FnPluginSwcOptions;
 
@@ -51,14 +42,10 @@ describe('plugin config', () => {
   });
 
   it('should not override user extensions config', () => {
-    const config = applyBuilderSwcConfig(
-      config => {
-        config.extensions ??= {};
-        config.extensions.emotion = true;
-      },
-      undefined,
-      true,
-    ) as FnPluginSwcOptions;
+    const config = applyBuilderSwcConfig(config => {
+      config.extensions ??= {};
+      config.extensions.emotion = true;
+    }, true) as FnPluginSwcOptions;
 
     const finalConfig = config(
       {