fix: script minifiy match regex (#7918)

clChenLiang · web-flow · commit bf22ac6460e7 · 2025-11-24T21:24:13.000+08:00
diff --git a/.changeset/smart-showers-think.md b/.changeset/smart-showers-think.md
@@ -0,0 +1,6 @@
+---
+'@modern-js/runtime': patch
+---
+
+fix: use minify regex
+fix: 用最小匹配来替换
diff --git a/packages/runtime/plugin-runtime/src/document/cli/index.ts b/packages/runtime/plugin-runtime/src/document/cli/index.ts
@@ -251,7 +251,7 @@ export const documentPlugin = (): CliPluginFuture<AppTools<'shared'>> => ({
 
           html = html.replace(
             new RegExp(
-              `${DOCUMENT_SCRIPT_PLACEHOLDER_START}${DOCUMENT_SCRIPT_ATTRIBUTES_START}(.*)${DOCUMENT_SCRIPT_ATTRIBUTES_END}(.*?)${DOCUMENT_SCRIPT_PLACEHOLDER_END}`,
+              `${DOCUMENT_SCRIPT_PLACEHOLDER_START}${DOCUMENT_SCRIPT_ATTRIBUTES_START}(.*?)${DOCUMENT_SCRIPT_ATTRIBUTES_END}(.*?)${DOCUMENT_SCRIPT_PLACEHOLDER_END}`,
               'g',
             ),
             (_scriptStr, $1, $2) =>
diff --git a/tests/integration/app-document/src/sub/Document.tsx b/tests/integration/app-document/src/sub/Document.tsx
@@ -55,6 +55,14 @@ export default function Document(): React.ReactElement {
             console.log('this is a IIFE function');
           }}
         />
+        <Script
+          defer
+          async
+          id="script-has-id2"
+          content={() => {
+            console.log('this is another IIFE function');
+          }}
+        />
       </Head>
       <Body {...{ dir: 'ltr' }}>
         <Root {...{ class: 'root' }}>
diff --git a/tests/integration/app-document/tests/index.test.ts b/tests/integration/app-document/tests/index.test.ts
@@ -172,6 +172,21 @@ describe('test dev and build', () => {
         htmlWithDoc.includes('console.log("this is a IIFE function")'),
       ).toBe(true);
     });
+
+    test('should not break Script origin script properties', async () => {
+      const htmlWithDoc = fs.readFileSync(
+        path.join(appDir, 'dist', 'html/sub/index.html'),
+        'utf-8',
+      );
+
+      expect(
+        htmlWithDoc.includes('<script defer="" async="" id="script-has-id2">'),
+      ).toBe(true);
+      // IIFE should worked
+      expect(
+        htmlWithDoc.includes('console.log("this is another IIFE function")'),
+      ).toBe(true);
+    });
   });
 
   describe('test dev', () => {
