fix: print hint when stats.errors is disabled (#6304)

Co-authored-by: Copilot <[email protected]>

Author: chenjiahan

e2e/cases/diagnostic/disable-stats-errors/index.test.ts

@@ -0,0 +1,21 @@
+import { rspackTest } from '@e2e/helper';
+
+const EXPECTED_LOG = `Build failed. No errors reported since Rspack's "stats.errors" is disabled.`;
+
+rspackTest(
+  'should print a hint if stats.errors is disabled after a dev failure',
+  async ({ dev }) => {
+    const rsbuild = await dev();
+    await rsbuild.expectLog(EXPECTED_LOG);
+  },
+);
+
+rspackTest(
+  'should print a hint if stats.errors is disabled after a build failure',
+  async ({ build }) => {
+    const rsbuild = await build({
+      catchBuildError: true,
+    });
+    await rsbuild.expectLog(EXPECTED_LOG);
+  },
+);

e2e/cases/diagnostic/disable-stats-errors/rsbuild.config.ts

@@ -0,0 +1,11 @@
+import { defineConfig } from '@rsbuild/core';
+
+export default defineConfig({
+  tools: {
+    rspack: {
+      stats: {
+        errors: false,
+      },
+    },
+  },
+});

e2e/cases/diagnostic/disable-stats-errors/src/index.js

@@ -0,0 +1 @@
+import './non-existent-file.js';

e2e/helper/fixture.ts

@@ -19,8 +19,8 @@ import {
 import { type ExtendedLogHelper, proxyConsole } from './logs';
 
 function makeBox(title: string) {
-  const header = `╭──────────────  Logs from: "${title}" ──────────────╮`;
-  const footer = `╰──────────────  Logs from: "${title}" ──────────────╯`;
+  const header = `╭────────────  Logs from: "${title}" ────────────╮`;
+  const footer = `╰────────────  Logs from: "${title}" ────────────╯`;
   return {
     header: `\n${header}\n`,
     footer: `${footer}\n`,

packages/compat/webpack/src/createCompiler.ts

@@ -42,7 +42,7 @@ export async function createCompiler(options: InitConfigsOptions) {
       compiler,
       context.action,
     );
-    const hasErrors = helpers.getStatsErrors(stats).length > 0;
+    const hasErrors = statsInstance.hasErrors();
 
     context.buildState.stats = stats;
     context.buildState.status = 'done';

packages/core/src/helpers/stats.ts

@@ -5,16 +5,14 @@ import { isMultiCompiler } from './';
 import { formatStatsError } from './format';
 
 function formatErrorMessage(errors: string[]) {
-  const title = color.bold(
-    color.red(errors.length > 1 ? 'Build errors: ' : 'Build error: '),
-  );
-
   if (!errors.length) {
-    return `${title}\n${color.yellow(`For more details, please set 'stats.errors: true' `)}`;
+    return `Build failed. No errors reported since Rspack's "stats.errors" is disabled.`;
   }
 
+  const title = color.bold(
+    color.red(errors.length > 1 ? 'Build errors: ' : 'Build error: '),
+  );
   const text = `${errors.join('\n\n')}\n`;
-
   return `${title}\n${text}`;
 }
 

packages/core/src/provider/createCompiler.ts

@@ -3,7 +3,6 @@ import {
   color,
   formatStats,
   getRsbuildStats,
-  getStatsErrors,
   isSatisfyRspackVersion,
   prettyTime,
   rspackMinVersion,
@@ -187,7 +186,7 @@ export async function createCompiler(options: InitConfigsOptions): Promise<{
     HOOK_NAME,
     (statsInstance: Rspack.Stats | Rspack.MultiStats) => {
       const stats = getRsbuildStats(statsInstance, compiler, context.action);
-      const hasErrors = getStatsErrors(stats).length > 0;
+      const hasErrors = statsInstance.hasErrors();
 
       context.buildState.stats = stats;
       context.buildState.status = 'done';

packages/core/src/provider/helpers.ts

@@ -3,12 +3,7 @@
  */
 
 export { modifyBundlerChain } from '../configChain';
-export {
-  formatStats,
-  getRsbuildStats,
-  getStatsErrors,
-  prettyTime,
-} from '../helpers';
+export { formatStats, getRsbuildStats, prettyTime } from '../helpers';
 export { registerBuildHook, registerDevHook } from '../hooks';
 export { inspectConfig } from '../inspectConfig';
 export {