Skip to content

Commit c55f605

Browse files
authored
fix(create-rsbuild): remove React 18 templates (#7387)
1 parent 8c0d50e commit c55f605

File tree

20 files changed

+5
-232
lines changed

20 files changed

+5
-232
lines changed

.github/renovate.json5

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -65,21 +65,10 @@
6565
matchDepTypes: ['peerDependencies'],
6666
enabled: false,
6767
},
68-
// keep React 18 and Vue 2 template
68+
// keep Vue 2 template
6969
{
70-
matchPaths: [
71-
'**/template-react18-js/**',
72-
'**/template-react18-ts/**',
73-
'**/template-vue2-js/**',
74-
'**/template-vue2-ts/**',
75-
],
76-
matchPackageNames: [
77-
'vue',
78-
'react',
79-
'react-dom',
80-
'@types/react',
81-
'@types/react-dom',
82-
],
70+
matchPaths: ['**/template-vue2-js/**', '**/template-vue2-ts/**'],
71+
matchPackageNames: ['vue'],
8372
enabled: false,
8473
},
8574
{

e2e/cases/create-rsbuild/jsTemplates.test.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,6 @@ test('should create react project as expected', async () => {
88
expect(pkgJson.devDependencies['@rsbuild/plugin-react']).toBeTruthy();
99
});
1010

11-
test('should create react18 project as expected', async () => {
12-
const { pkgJson } = await createAndValidate(import.meta.dirname, 'react18');
13-
expect(pkgJson.dependencies.react.startsWith('^18')).toBeTruthy();
14-
expect(pkgJson.dependencies['react-dom'].startsWith('^18')).toBeTruthy();
15-
expect(pkgJson.devDependencies['@rsbuild/plugin-react']).toBeTruthy();
16-
});
17-
1811
test('should create preact project as expected', async () => {
1912
const { pkgJson } = await createAndValidate(import.meta.dirname, 'preact');
2013
expect(pkgJson.dependencies.preact).toBeTruthy();

e2e/cases/create-rsbuild/tsTemplates.test.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,6 @@ test('should create react-ts project as expected', async () => {
88
expect(pkgJson.devDependencies['@rsbuild/plugin-react']).toBeTruthy();
99
});
1010

11-
test('should create react18-ts project as expected', async () => {
12-
const { pkgJson } = await createAndValidate(
13-
import.meta.dirname,
14-
'react18-ts',
15-
);
16-
expect(pkgJson.dependencies.react.startsWith('^18')).toBeTruthy();
17-
expect(pkgJson.dependencies['react-dom'].startsWith('^18')).toBeTruthy();
18-
expect(pkgJson.devDependencies['@rsbuild/plugin-react']).toBeTruthy();
19-
});
20-
2111
test('should create preact-ts project as expected', async () => {
2212
const { pkgJson } = await createAndValidate(import.meta.dirname, 'preact-ts');
2313
expect(pkgJson.dependencies.preact).toBeTruthy();

packages/create-rsbuild/src/index.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ async function getTemplateName({ template }: Argv) {
2929
options: [
3030
{ value: 'vanilla', label: 'Vanilla' },
3131
{ value: 'react', label: 'React 19' },
32-
{ value: 'react18', label: 'React 18' },
3332
{ value: 'vue3', label: 'Vue 3' },
3433
{ value: 'vue2', label: 'Vue 2' },
3534
{ value: 'lit', label: 'Lit' },
@@ -66,10 +65,6 @@ function mapESLintTemplate(templateName: string): ESLintTemplateName {
6665
case 'vue2-ts':
6766
case 'vue3-ts':
6867
return 'vue-ts';
69-
case 'react18-js':
70-
return 'react-js';
71-
case 'react18-ts':
72-
return 'react-ts';
7368
default:
7469
return `vanilla-${templateName.split('-')[1]}` as ESLintTemplateName;
7570
}
@@ -78,10 +73,8 @@ function mapESLintTemplate(templateName: string): ESLintTemplateName {
7873
function mapRstestTemplate(templateName: string): string {
7974
switch (templateName) {
8075
case 'react-js':
81-
case 'react18-js':
8276
return 'react-js';
8377
case 'react-ts':
84-
case 'react18-ts':
8578
return 'react-ts';
8679
case 'vue3-js':
8780
return 'vue-js';
@@ -102,8 +95,6 @@ create({
10295
'vanilla-ts',
10396
'react-js',
10497
'react-ts',
105-
'react18-js',
106-
'react18-ts',
10798
'vue3-js',
10899
'vue3-ts',
109100
'vue2-js',

packages/create-rsbuild/template-react18-js/package.json

Lines changed: 0 additions & 19 deletions
This file was deleted.

packages/create-rsbuild/template-react18-js/rsbuild.config.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

packages/create-rsbuild/template-react18-js/src/App.css

Lines changed: 0 additions & 26 deletions
This file was deleted.

packages/create-rsbuild/template-react18-js/src/App.jsx

Lines changed: 0 additions & 12 deletions
This file was deleted.

packages/create-rsbuild/template-react18-js/src/index.jsx

Lines changed: 0 additions & 10 deletions
This file was deleted.

packages/create-rsbuild/template-react18-ts/package.json

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)