fix: preserve worker syntax (#959)

Author: fi3ework

packages/core/src/config.ts

@@ -576,6 +576,9 @@ const composeFormatConfig = ({
       importMeta: false,
       importDynamic: false,
     },
+    others: {
+      worker: false,
+    },
   } as const;
 
   switch (format) {
@@ -588,6 +591,7 @@ const composeFormatConfig = ({
                 javascript: {
                   ...jsParserOptions.esm,
                   ...jsParserOptions.cjs,
+                  ...jsParserOptions.others,
                 },
               },
             },
@@ -618,7 +622,11 @@ const composeFormatConfig = ({
           rspack: {
             module: {
               parser: {
-                javascript: { ...jsParserOptions.esm, ...jsParserOptions.cjs },
+                javascript: {
+                  ...jsParserOptions.esm,
+                  ...jsParserOptions.cjs,
+                  ...jsParserOptions.others,
+                },
               },
             },
             output: {
@@ -701,8 +709,8 @@ const composeFormatConfig = ({
   }
 };
 
-const formatRsbuildPlugin = (): RsbuildPlugin => ({
-  name: 'rsbuild:format',
+const disableUrlParseRsbuildPlugin = (): RsbuildPlugin => ({
+  name: 'rsbuild:disable-url-parse',
   setup(api) {
     api.modifyBundlerChain((config, { CHAIN_ID }) => {
       // Fix for https://github.com/web-infra-dev/rslib/issues/499.
@@ -761,7 +769,7 @@ const composeShimsConfig = (
         },
         plugins: [
           resolvedShims.esm.require && pluginEsmRequireShim(),
-          formatRsbuildPlugin(),
+          disableUrlParseRsbuildPlugin(),
         ].filter(Boolean),
       };
       break;
@@ -770,6 +778,7 @@ const composeShimsConfig = (
       rsbuildConfig = {
         plugins: [
           resolvedShims.cjs['import.meta.url'] && pluginCjsImportMetaUrlShim(),
+          disableUrlParseRsbuildPlugin(),
         ].filter(Boolean),
       };
       break;

packages/core/tests/__snapshots__/config.test.ts.snap

@@ -111,7 +111,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
       },
       "plugins": [
         {
-          "name": "rsbuild:format",
+          "name": "rsbuild:disable-url-parse",
           "setup": [Function],
         },
         {
@@ -189,6 +189,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
                   "requireAsExpression": false,
                   "requireDynamic": false,
                   "requireResolve": false,
+                  "worker": false,
                 },
               },
             },
@@ -365,6 +366,10 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
           "name": "rsbuild:cjs-import-meta-url-shim",
           "setup": [Function],
         },
+        {
+          "name": "rsbuild:disable-url-parse",
+          "setup": [Function],
+        },
         {
           "name": "rsbuild:lib-asset",
           "pre": [
@@ -441,6 +446,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
                   "requireAsExpression": false,
                   "requireDynamic": false,
                   "requireResolve": false,
+                  "worker": false,
                 },
               },
             },

pnpm-lock.yaml

@@ -0,0 +1,26 @@
+import { buildAndGetResults, queryContent } from 'test-helper';
+import { expect, test } from 'vitest';
+
+test('new Worker(new URL(...)) should be preserved', async () => {
+  process.env.NODE_ENV = 'production';
+  const fixturePath = __dirname;
+  const { contents } = await buildAndGetResults({
+    fixturePath,
+  });
+
+  expect(contents.esm).toMatchInlineSnapshot(`
+    {
+      "<ROOT>/tests/integration/worker/dist/esm/index.js": "const worker = new Worker(new URL('./worker.js', import.meta.url), {
+        name: 'my-worker'
+    });
+    export { worker };
+    ",
+      "<ROOT>/tests/integration/worker/dist/esm/worker.js": "console.log('Hello from worker', self.name);
+    ",
+    }
+  `);
+
+  expect(queryContent(contents.cjs, /\/index\.js/).content).toContain(
+    "new Worker(new URL('./worker.js', __rslib_import_meta_url__)",
+  );
+});

tests/integration/worker/index.test.ts

@@ -0,0 +1,5 @@
+{
+  "name": "worker-test",
+  "version": "1.0.0",
+  "private": true
+}

tests/integration/worker/package.json

@@ -0,0 +1,25 @@
+import { defineConfig } from '@rslib/core';
+import { generateBundleCjsConfig, generateBundleEsmConfig } from 'test-helper';
+
+export default defineConfig({
+  lib: [
+    generateBundleEsmConfig({
+      autoExtension: false,
+      source: {
+        entry: {
+          index: './src/index.ts',
+          worker: './src/worker.ts',
+        },
+      },
+    }),
+    generateBundleCjsConfig({
+      autoExtension: false,
+      source: {
+        entry: {
+          index: './src/index.ts',
+          worker: './src/worker.ts',
+        },
+      },
+    }),
+  ],
+});

tests/integration/worker/rslib.config.ts

@@ -0,0 +1,3 @@
+export const worker = new Worker(new URL('./worker.js', import.meta.url), {
+  name: 'my-worker',
+});

tests/integration/worker/src/index.ts

@@ -0,0 +1 @@
+console.log('Hello from worker', self.name);