chore: update

Author: Timeless0911

packages/core/src/config.ts

@@ -235,15 +235,29 @@ const composeExternalsWarnConfig = (
   };
 };
 
+const getAutoExternalDefaultValue = (
+  format: Format,
+  autoExternal?: AutoExternal,
+): AutoExternal => {
+  return isIntermediateOutputFormat(format)
+    ? (autoExternal ?? true)
+    : (autoExternal ?? false);
+};
+
 export const composeAutoExternalConfig = (options: {
   format: Format;
   autoExternal?: AutoExternal;
   pkgJson?: PkgJson;
   userExternals?: NonNullable<RsbuildConfig['output']>['externals'];
 }): RsbuildConfig => {
-  const { format, autoExternal = true, pkgJson, userExternals } = options;
+  const { format, pkgJson, userExternals } = options;
+
+  const autoExternal = getAutoExternalDefaultValue(
+    format,
+    options.autoExternal,
+  );
 
-  if (autoExternal === false || !isIntermediateOutputFormat(format)) {
+  if (autoExternal === false) {
     return {};
   }
 
@@ -1007,7 +1021,7 @@ const composeDtsConfig = async (
   libConfig: LibConfig,
   dtsExtension: string,
 ): Promise<RsbuildConfig> => {
-  const { format, autoExternal = true, banner, footer } = libConfig;
+  const { format, autoExternal, banner, footer } = libConfig;
 
   let { dts } = libConfig;
 
@@ -1030,9 +1044,7 @@ const composeDtsConfig = async (
         build: dts?.build,
         abortOnError: dts?.abortOnError,
         dtsExtension: dts?.autoExtension ? dtsExtension : '.d.ts',
-        autoExternal: !isIntermediateOutputFormat(format!)
-          ? false
-          : autoExternal,
+        autoExternal: getAutoExternalDefaultValue(format!, autoExternal),
         banner: banner?.dts,
         footer: footer?.dts,
       }),

packages/core/src/types/config/index.ts

@@ -109,8 +109,7 @@ export interface LibConfig extends RsbuildConfig {
   autoExtension?: boolean;
   /**
    * Whether to automatically externalize dependencies of different dependency types and do not bundle them.
-   * Only takes effect when {@link format} is `cjs` or `esm`.
-   * @defaultValue `true`
+   * @defaultValue `true` when {@link format} is `cjs` or `esm`, `false` when {@link format} is `umd` or `mf`.
    * @see {@link https://lib.rsbuild.dev/config/lib/auto-external}
    */
   autoExternal?: AutoExternal;

packages/core/tests/external.test.ts

@@ -4,7 +4,7 @@ import { composeAutoExternalConfig } from '../src/config';
 vi.mock('rslog');
 
 describe('should composeAutoExternalConfig correctly', () => {
-  it('autoExternal is undefined', () => {
+  it('autoExternal default value', () => {
     const esmResult = composeAutoExternalConfig({
       format: 'esm',
       autoExternal: undefined,
@@ -27,6 +27,28 @@ describe('should composeAutoExternalConfig correctly', () => {
       },
     });
 
+    const umdResult = composeAutoExternalConfig({
+      format: 'umd',
+      autoExternal: undefined,
+      pkgJson: {
+        name: 'umd',
+        dependencies: {
+          foo: '1.0.0',
+        },
+      },
+    });
+
+    const mfResult = composeAutoExternalConfig({
+      format: 'mf',
+      autoExternal: undefined,
+      pkgJson: {
+        name: 'mf',
+        dependencies: {
+          foo: '1.0.0',
+        },
+      },
+    });
+
     expect(esmResult).toMatchInlineSnapshot(`
       {
         "output": {
@@ -48,33 +70,8 @@ describe('should composeAutoExternalConfig correctly', () => {
         },
       }
     `);
-  });
-
-  it('autoExternal should be disabled when format is umd or mf', () => {
-    const umdResult = composeAutoExternalConfig({
-      format: 'umd',
-      autoExternal: undefined,
-      pkgJson: {
-        name: 'umd',
-        dependencies: {
-          foo: '1.0.0',
-        },
-      },
-    });
 
     expect(umdResult).toMatchInlineSnapshot('{}');
-
-    const mfResult = composeAutoExternalConfig({
-      format: 'mf',
-      autoExternal: undefined,
-      pkgJson: {
-        name: 'mf',
-        dependencies: {
-          foo: '1.0.0',
-        },
-      },
-    });
-
     expect(mfResult).toMatchInlineSnapshot('{}');
   });
 
@@ -111,6 +108,52 @@ describe('should composeAutoExternalConfig correctly', () => {
     });
   });
 
+  it('autoExternal is true when format is umd or mf', () => {
+    const umdResult = composeAutoExternalConfig({
+      format: 'umd',
+      autoExternal: true,
+      pkgJson: {
+        name: 'umd',
+        dependencies: {
+          foo: '1.0.0',
+        },
+      },
+    });
+
+    expect(umdResult).toMatchInlineSnapshot(`
+      {
+        "output": {
+          "externals": [
+            /\\^foo\\(\\$\\|\\\\/\\|\\\\\\\\\\)/,
+            "foo",
+          ],
+        },
+      }
+    `);
+
+    const mfResult = composeAutoExternalConfig({
+      format: 'mf',
+      autoExternal: true,
+      pkgJson: {
+        name: 'mf',
+        dependencies: {
+          foo: '1.0.0',
+        },
+      },
+    });
+
+    expect(mfResult).toMatchInlineSnapshot(`
+      {
+        "output": {
+          "externals": [
+            /\\^foo\\(\\$\\|\\\\/\\|\\\\\\\\\\)/,
+            "foo",
+          ],
+        },
+      }
+    `);
+  });
+
   it('autoExternal will deduplication ', () => {
     const result = composeAutoExternalConfig({
       format: 'esm',

website/docs/en/config/lib/auto-external.mdx

@@ -17,12 +17,12 @@ type AutoExternal =
     };
 ```
 
-- **Default:** `true`
+- **Default:**
+  - `true` when [format](/config/lib/format) is `cjs` or `esm`
+  - `false` when [format](/config/lib/format) is `umd` or `mf`
 
 Whether to automatically externalize dependencies of different dependency types and do not bundle them.
 
-This option only takes effect when [format](/config/lib/format) is `cjs` or `esm`.
-
 ## Object Type
 
 ### autoExternal.dependencies

website/docs/zh/config/lib/auto-external.mdx

@@ -17,12 +17,12 @@ type AutoExternal =
     };
 ```
 
-- **默认值：** `true`
+- **默认值：**
+  - 当 [format](/config/lib/format) 为 `cjs` 或 `esm` 时为 `true`
+  - 当 [format](/config/lib/format) 为 `umd` 或 `mf` 时为 `false`
 
 是否自动对不同依赖类型的依赖进行外部化处理，不将其打包。
 
-该选项仅当 [format](/config/lib/format) 为 `cjs` 或 `esm` 时生效。
-
 ## 对象类型
 
 ### autoExternal.dependencies