chore: set moduleIds in config

Author: 2heal1

packages/core/src/config.ts

@@ -53,7 +53,6 @@ import {
   calcLongestCommonPath,
   checkMFPlugin,
   color,
-  composeMFPlugin,
   isEmptyObject,
   isObject,
   nodeBuiltInModules,
@@ -589,9 +588,12 @@ const composeFormatConfig = ({
             },
             // can not set nodeEnv to false, because mf format should build shared module.
             // If nodeEnv is false, the process.env.NODE_ENV in third-party packages's will not be replaced
-            // now we have not provide dev mode for users, so we can always set nodeEnv as 'production'
             optimization: {
               nodeEnv: 'production',
+              moduleIds:
+                process.env.NODE_ENV === 'production'
+                  ? 'deterministic'
+                  : 'named',
             },
           },
         },
@@ -1078,7 +1080,6 @@ const composeExternalHelpersConfig = (
 
 async function composeLibRsbuildConfig(config: LibConfig, configPath: string) {
   checkMFPlugin(config);
-  const mfConfig = composeMFPlugin(config);
   const rootPath = dirname(configPath);
   const pkgJson = readPackageJson(rootPath);
   const { compilerOptions } = await loadTsconfig(
@@ -1162,7 +1163,6 @@ async function composeLibRsbuildConfig(config: LibConfig, configPath: string) {
   );
 
   return mergeRsbuildConfig(
-    mfConfig,
     formatConfig,
     shimsConfig,
     externalHelpersConfig,

packages/core/src/utils/helper.ts

@@ -1,7 +1,7 @@
 import fs from 'node:fs';
 import fsP from 'node:fs/promises';
 import path from 'node:path';
-import type { RsbuildConfig, RsbuildPlugins } from '@rsbuild/core';
+import type { RsbuildPlugins } from '@rsbuild/core';
 import color from 'picocolors';
 
 import type { LibConfig, PkgJson } from '../types';
@@ -201,20 +201,4 @@ export function checkMFPlugin(config: LibConfig): boolean {
   return added;
 }
 
-export function composeMFPlugin(config: LibConfig): RsbuildConfig {
-  if (config.format !== 'mf' || process.env.NODE_ENV !== 'production') {
-    return {};
-  }
-
-  return {
-    tools: {
-      rspack: {
-        optimization: {
-          moduleIds: 'deterministic',
-        },
-      },
-    },
-  };
-}
-
 export { color };

tests/integration/minify/index.test.ts

@@ -1,6 +1,7 @@
 import { join } from 'node:path';
+import { afterEach, beforeEach, describe } from 'node:test';
 import { buildAndGetResults } from 'test-helper';
-import { expect, test } from 'vitest';
+import { afterAll, beforeAll, expect, test, vi } from 'vitest';
 
 test('tree shaking is enabled by default, bar and baz should be shaken', async () => {
   const fixturePath = join(__dirname, 'default');
@@ -31,40 +32,21 @@ test('tree shaking is disabled by the user, bar and baz should be kept', async (
 
 test('minify is enabled by default in mf format, bar and baz should be minified', async () => {
   const fixturePath = join(__dirname, 'mf/default');
+  const nodeEnv = process.env.NODE_ENV;
+  process.env.NODE_ENV = 'production';
   const { mfExposeEntry } = await buildAndGetResults({ fixturePath });
+  process.env.NODE_ENV = nodeEnv;
   // biome-ignore format: snapshot
-  expect(mfExposeEntry).toMatchInlineSnapshot(`""use strict";(globalThis["default_minify"]=globalThis["default_minify"]||[]).push([["249"],{"../../__fixtures__/src/index.ts":function(__unused_webpack_module,__webpack_exports__,__webpack_require__){__webpack_require__.r(__webpack_exports__);__webpack_require__.d(__webpack_exports__,{foo:function(){return foo}});const foo=()=>{}}}]);"`);
+  expect(mfExposeEntry).toMatchInlineSnapshot(`""use strict";(globalThis["default_minify"]=globalThis["default_minify"]||[]).push([["249"],{163:function(__unused_webpack_module,__webpack_exports__,__webpack_require__){__webpack_require__.r(__webpack_exports__);__webpack_require__.d(__webpack_exports__,{foo:function(){return foo}});const foo=()=>{}}}]);"`);
 });
 
 test('minify is disabled by the user, bar and baz should not be minified', async () => {
   const fixturePath = join(__dirname, 'mf/config');
-  const { mfExposeEntry } = await buildAndGetResults({ fixturePath });
-  expect(mfExposeEntry).toMatchInlineSnapshot(`
-    ""use strict";
-    (globalThis['disable_minify'] = globalThis['disable_minify'] || []).push([["249"], {
-    "../../__fixtures__/src/index.ts": (function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
-    __webpack_require__.r(__webpack_exports__);
-    __webpack_require__.d(__webpack_exports__, {
-      foo: function() { return foo; }
-    });
-    const foo = ()=>{};
-    const bar = ()=>{};
-    const baz = ()=>{
-        return bar();
-    };
-
-
-    }),
-
-    }]);"
-  `);
-});
-
-test('enable minify and set NODE_ENV to production, the moduleIds should be the deterministic', async () => {
-  const fixturePath = join(__dirname, 'mf/config');
-  const prevNodeEnv = process.env.NODE_ENV;
+  const nodeEnv = process.env.NODE_ENV;
   process.env.NODE_ENV = 'production';
   const { mfExposeEntry } = await buildAndGetResults({ fixturePath });
+  process.env.NODE_ENV = nodeEnv;
+
   expect(mfExposeEntry).toMatchInlineSnapshot(`
     ""use strict";
     (globalThis['disable_minify'] = globalThis['disable_minify'] || []).push([["249"], {
@@ -84,6 +66,4 @@ test('enable minify and set NODE_ENV to production, the moduleIds should be the
 
     }]);"
   `);
-
-  process.env.NODE_ENV = prevNodeEnv;
 });