up

Author: fi3ework

pnpm-lock.yaml

@@ -1,48 +1,100 @@
-import path, { join } from 'node:path';
-import { buildAndGetResults } from 'test-helper';
+import fs from 'node:fs';
+import { join } from 'node:path';
+import { buildAndGetResults, queryContent } from 'test-helper';
 import { describe, expect, test } from 'vitest';
 
 describe('shebang', async () => {
-  const fixturePath = join(__dirname, 'shebang/bundle');
-  const { entries } = await buildAndGetResults({ fixturePath });
+  const fixturePath = join(__dirname, 'shebang');
+  const { entries, contents, entryFiles } = await buildAndGetResults({
+    fixturePath,
+  });
+
+  describe('bundle', async () => {
+    test('shebang at the beginning', async () => {
+      expect(entries.esm0!.startsWith('#!/usr/bin/env node')).toBe(true);
+    });
+
+    test('shebang at the beginning even if minified', async () => {
+      expect(entries.esm1!.startsWith('#!/usr/bin/env node')).toBe(true);
+    });
+  });
+
+  describe('bundle-false', async () => {
+    test('shebang at the beginning', async () => {
+      const index = queryContent(contents.esm2!, 'index.js', {
+        basename: true,
+      });
+      expect(index!.startsWith('#!/usr/bin/env node')).toBe(true);
+
+      const bar = queryContent(contents.esm2!, 'bar.js', { basename: true });
+      expect(bar!.startsWith('#!/usr/bin/env node')).toBe(true);
+
+      const foo = queryContent(contents.esm2!, 'foo.js', { basename: true });
+      expect(foo!.includes('#!')).toBe(false);
+    });
+
+    test('shebang at the beginning even if minified', async () => {
+      const index = queryContent(contents.esm3!, 'index.js', {
+        basename: true,
+      });
+      expect(index!.startsWith('#!/usr/bin/env node')).toBe(true);
 
-  test('shebang at the beginning', async () => {
-    expect(entries.esm0!.startsWith('#!/usr/bin/env node')).toBe(true);
+      const bar = queryContent(contents.esm3!, 'bar.js', {
+        basename: true,
+      });
+      expect(bar!.startsWith('#!/usr/bin/env node')).toBe(true);
+
+      const foo = queryContent(contents.esm2!, 'foo.js', { basename: true });
+      expect(foo!.includes('#!')).toBe(false);
+    });
+
+    test.todo('shebang commented by JS parser should be striped', async () => {
+      const index = queryContent(contents.esm3!, 'index.js', {
+        basename: true,
+      });
+      expect(index!.includes('//#!')).toBe(false);
+
+      const bar = queryContent(contents.esm3!, 'bar.js', {
+        basename: true,
+      });
+      expect(bar!.includes('//#!')).toBe(false);
+    });
   });
 
-  test('shebang at the beginning even if minified', async () => {
-    expect(entries.esm1!.startsWith('#!/usr/bin/env node')).toBe(true);
+  describe('chmod', async () => {
+    test('shebang at the beginning', async () => {
+      const filePath = entryFiles.esm0!;
+      const fileStats = fs.statSync(filePath);
+      expect(fileStats.mode).toBe(0o100755);
+    });
+
+    test('shebang at the beginning even if minified', async () => {
+      const filePath = entryFiles.esm1!;
+      const fileStats = fs.statSync(filePath);
+      expect(fileStats.mode).toBe(0o100755);
+    });
   });
 });
 
 describe('react', async () => {
   const fixturePath = join(__dirname, 'react/bundleless');
   const { contents } = await buildAndGetResults({ fixturePath });
-  test('React directive at the beginning', async () => {
-    const bar = Object.entries(contents.esm0!).find(([key]) => {
-      return path.basename(key) === 'bar.js';
-    })?.[1];
-
-    expect(bar!.startsWith(`'use server';`)).toBe(true);
-
-    const foo = Object.entries(contents.esm0!).find(([key]) => {
-      return path.basename(key) === 'foo.js';
-    })?.[1];
-
-    expect(foo!.startsWith(`'use client';`)).toBe(true);
-  });
 
-  test('React directive at the beginning even if minified', async () => {
-    const bar = Object.entries(contents.esm1!).find(([key]) => {
-      return path.basename(key) === 'bar.js';
-    })?.[1];
+  describe('bundle-false', async () => {
+    test('React directive at the beginning', async () => {
+      const foo = queryContent(contents.esm0!, 'foo.js', { basename: true });
+      expect(foo!.startsWith(`'use client';`)).toBe(true);
 
-    expect(bar!.startsWith(`'use server';`)).toBe(true);
+      const bar = queryContent(contents.esm0!, 'bar.js', { basename: true });
+      expect(bar!.startsWith(`'use server';`)).toBe(true);
+    });
 
-    const foo = Object.entries(contents.esm1!).find(([key]) => {
-      return path.basename(key) === 'foo.js';
-    })?.[1];
+    test('React directive at the beginning even if minified', async () => {
+      const foo = queryContent(contents.esm1!, 'foo.js', { basename: true });
+      expect(foo!.startsWith(`'use client';`)).toBe(true);
 
-    expect(foo!.startsWith(`'use client';`)).toBe(true);
+      const bar = queryContent(contents.esm1!, 'bar.js', { basename: true });
+      expect(bar!.startsWith(`'use server';`)).toBe(true);
+    });
   });
 });

tests/integration/directive/index.test.ts

@@ -9,6 +9,15 @@ const esmShared = {
   },
 };
 
+const esmSharedBundleFalse = {
+  bundle: false,
+  source: {
+    entry: {
+      index: './src/*',
+    },
+  },
+};
+
 export default defineConfig({
   lib: [
     generateBundleEsmConfig({
@@ -30,6 +39,25 @@ export default defineConfig({
         },
       },
     }),
+    generateBundleEsmConfig({
+      ...esmSharedBundleFalse,
+      shims: { esm: { __dirname: true, __filename: true } },
+      output: {
+        distPath: {
+          root: './dist/bundle-false/esm0',
+        },
+      },
+    }),
+    generateBundleEsmConfig({
+      ...esmSharedBundleFalse,
+      shims: { esm: { __dirname: true, __filename: true } },
+      output: {
+        minify: true,
+        distPath: {
+          root: './dist/bundle-false/esm1',
+        },
+      },
+    }),
   ],
   output: {
     target: 'node',

tests/integration/directive/shebang/bundle/package.json renamed to tests/integration/directive/shebang/package.json

@@ -1,6 +1,6 @@
 import assert from 'node:assert';
 import fs from 'node:fs';
-import { dirname, join, normalize } from 'node:path';
+import path, { dirname, join, normalize } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { pluginModuleFederation } from '@module-federation/rsbuild-plugin';
 import {
@@ -319,3 +319,25 @@ export function getFileBySuffix(
   assert(content);
   return content;
 }
+
+export function queryContent(
+  contents: Record<string, string>,
+  query: string | RegExp,
+  options: {
+    basename?: boolean;
+  } = {},
+): string | null {
+  const basename = options?.basename ?? false;
+  const matched = Object.entries(contents).find(([key]) => {
+    const toQueried = basename ? path.basename(key) : key;
+    return typeof query === 'string'
+      ? toQueried === query
+      : query.test(toQueried);
+  });
+
+  if (!matched) {
+    return null;
+  }
+
+  return matched[1];
+}