shim test

Author: fi3ework

packages/core/src/plugins/EntryChunkPlugin.ts

@@ -40,8 +40,6 @@ class EntryChunkPlugin {
   private shebangInjectedAssets: Set<string> = new Set();
 
   private enabledImportMetaUrlShim: boolean;
-  private importMetaUrlShims: Record<string, { startsWithUseStrict: boolean }> =
-    {};
 
   constructor({
     enabledImportMetaUrlShim = true,
@@ -89,17 +87,6 @@ class EntryChunkPlugin {
         if (reactDirective) {
           this.reactDirectives[name] = reactDirective;
         }
-
-        // import.meta.url shim
-        if (this.enabledImportMetaUrlShim) {
-          this.importMetaUrlShims[name] = {
-            startsWithUseStrict:
-              // This is a hypothesis that no comments will occur before "use strict;".
-              // But it should cover most cases.
-              content.startsWith('use strict;') ||
-              content.startsWith('"use strict";'),
-          };
-        }
       }
     });
 
@@ -120,11 +107,6 @@ class EntryChunkPlugin {
         if (reactDirective) {
           this.reactDirectives[filename] = reactDirective;
         }
-
-        const importMetaUrlShimInfo = this.importMetaUrlShims[name];
-        if (importMetaUrlShimInfo) {
-          this.importMetaUrlShims[filename] = importMetaUrlShimInfo;
-        }
       });
     });
 
@@ -134,24 +116,22 @@ class EntryChunkPlugin {
         for (const name of chunkAsset) {
           if (this.enabledImportMetaUrlShim) {
             compilation.updateAsset(name, (old) => {
-              const importMetaUrlShimInfo = this.importMetaUrlShims[name];
-              if (importMetaUrlShimInfo) {
-                const replaceSource = new rspack.sources.ReplaceSource(old);
-
-                if (importMetaUrlShimInfo.startsWithUseStrict) {
-                  replaceSource.replace(
-                    0,
-                    11, // 'use strict;'.length,
-                    `"use strict";${os.EOL}${importMetaUrlShim}`,
-                  );
-                } else {
-                  replaceSource.insert(0, importMetaUrlShim);
-                }
-
-                return replaceSource;
+              const oldSource = old.source().toString();
+              const replaceSource = new rspack.sources.ReplaceSource(old);
+              if (
+                oldSource.startsWith('use strict;') ||
+                oldSource.startsWith('"use strict";')
+              ) {
+                replaceSource.replace(
+                  0,
+                  11, // 'use strict;'.length,
+                  `"use strict";${os.EOL}${importMetaUrlShim}`,
+                );
+              } else {
+                replaceSource.insert(0, importMetaUrlShim);
               }
 
-              return old;
+              return replaceSource;
             });
           }
         }

packages/core/tests/__snapshots__/config.test.ts.snap

@@ -204,7 +204,6 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
             "plugins": [
               EntryChunkPlugin {
                 "enabledImportMetaUrlShim": true,
-                "importMetaUrlShims": {},
                 "reactDirectives": {},
                 "shebangChmod": 493,
                 "shebangEntries": {},
@@ -430,7 +429,6 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
             "plugins": [
               EntryChunkPlugin {
                 "enabledImportMetaUrlShim": true,
-                "importMetaUrlShims": {},
                 "reactDirectives": {},
                 "shebangChmod": 493,
                 "shebangEntries": {},
@@ -640,7 +638,6 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
             "plugins": [
               EntryChunkPlugin {
                 "enabledImportMetaUrlShim": true,
-                "importMetaUrlShims": {},
                 "reactDirectives": {},
                 "shebangChmod": 493,
                 "shebangEntries": {},

tests/integration/directive/index.test.ts

@@ -4,6 +4,8 @@ import { join } from 'node:path';
 import { buildAndGetResults, queryContent } from 'test-helper';
 import { describe, expect, test } from 'vitest';
 
+// The test for `import.meta.url` shim is in tests/integration/shims/index.test.ts
+
 describe('shebang', async () => {
   const fixturePath = join(__dirname, 'shebang');
   const { entries, contents, entryFiles } = await buildAndGetResults({

tests/integration/shims/cjs/src/index.ts

@@ -1,4 +1,3 @@
-// import.meta.url
 import { createRequire } from 'node:module';
 const importMetaUrl = import.meta.url;
 const require = createRequire(import.meta.url);

tests/integration/shims/index.test.ts

@@ -95,14 +95,17 @@ describe('CJS shims', () => {
     const fileUrl = pathToFileURL(entryFiles.cjs).href;
     expect(importMetaUrl).toBe(fileUrl);
     expect(requiredModule).toBe('ok');
+    expect(cjsCode.startsWith('"use strict"')).toBe(true);
+    expect(cjsCode).toContain(
+      'const __rslib_import_meta_url__ = /*#__PURE__*/ function() {',
+    );
   });
 
   test('ESM should not be affected by CJS shims configuration', async () => {
     const fixturePath = join(__dirname, 'cjs');
     const { entries } = await buildAndGetResults({ fixturePath });
     expect(entries.esm).toMatchInlineSnapshot(`
       "import * as __WEBPACK_EXTERNAL_MODULE_node_module__ from "node:module";
-      // import.meta.url
       const importMetaUrl = import.meta.url;
       const src_rslib_entry_require = (0, __WEBPACK_EXTERNAL_MODULE_node_module__.createRequire)(import.meta.url);
       const requiredModule = src_rslib_entry_require('./ok.cjs');