fix(dts): error log of set declarationDir when dts.build is true (#1120)

Author: Timeless0911

biome.json

@@ -1,5 +1,5 @@
 {
-  "$schema": "https://biomejs.dev/schemas/2.0.6/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.1.1/schema.json",
   "assist": {
     "actions": {
       "source": {

packages/plugin-dts/src/dts.ts

@@ -167,12 +167,8 @@ export async function generateDts(data: DtsGenOptions): Promise<void> {
       (!rawCompilerOptions.declarationDir ||
         normalize(rawCompilerOptions.declarationDir) !== resolvedDtsEmitPath)
     ) {
-      const info =
-        rawCompilerOptions.outDir && !rawCompilerOptions.declarationDir
-          ? 'outDir'
-          : 'declarationDir';
       throw Error(
-        `Please set ${info}: "${dtsEmitPath}" in ${color.underline(
+        `Please set "declarationDir": "${dtsEmitPath}" in ${color.underline(
           tsconfigPath,
         )} to keep it same as "dts.distPath" or "output.distPath.root" field in lib config.`,
       );

pnpm-lock.yaml

@@ -8,6 +8,7 @@ export default defineConfig({
       dts: {
         bundle: false,
         build: true,
+        distPath: './dist/types',
       },
     }),
   ],

tests/integration/dts/build/tsconfig/rslib.config.ts

@@ -3,7 +3,8 @@
   "compilerOptions": {
     "baseUrl": "./",
     "rootDir": "src",
-    "declaration": true
+    "declaration": true,
+    "outDir": "./dist/esm"
   },
   "include": ["src"],
   "references": [

tests/integration/dts/build/tsconfig/tsconfig.json

@@ -533,7 +533,9 @@ describe('dts when build: true', () => {
     const stdoutOutput = result.stdout ? result.stdout.toString() : '';
 
     expect(result.status).toBe(1);
-    expect(stdoutOutput).toContain('Please set declarationDir: "./dist/esm"');
+    expect(stdoutOutput).toContain(
+      'Please set "declarationDir": "./dist/types"',
+    );
   });
 
   test('should clean dts dist files', async () => {