fix: shared Rsbuild plugin should run only once

Author: chenjiahan

packages/core/src/cli/build.ts

@@ -11,6 +11,7 @@ export async function build(
   const environments = await composeRsbuildEnvironments(config);
   const rsbuildInstance = await createRsbuild({
     rsbuildConfig: {
+      plugins: config.plugins,
       environments: pruneEnvironments(environments, options.lib),
     },
   });

packages/core/src/cli/inspect.ts

@@ -10,6 +10,7 @@ export async function inspect(
   const environments = await composeRsbuildEnvironments(config);
   const rsbuildInstance = await createRsbuild({
     rsbuildConfig: {
+      plugins: config.plugins,
       environments: pruneEnvironments(environments, options.lib),
     },
   });

packages/core/src/config.ts

@@ -1258,7 +1258,7 @@ export async function composeCreateRsbuildConfig(
   rslibConfig: RslibConfig,
 ): Promise<RsbuildConfigWithLibInfo[]> {
   const constantRsbuildConfig = await createConstantRsbuildConfig();
-  const { lib: libConfigsArray, ...sharedRsbuildConfig } = rslibConfig;
+  const { lib: libConfigsArray, plugins, ...sharedRsbuildConfig } = rslibConfig;
 
   if (!libConfigsArray) {
     throw new Error(

pnpm-lock.yaml

@@ -0,0 +1,12 @@
+import fs from 'node:fs';
+import { buildAndGetResults } from 'test-helper';
+import { expect, test } from 'vitest';
+import { distIndex } from './rslib.config';
+
+test('should run shared plugins only once', async () => {
+  const fixturePath = __dirname;
+  await buildAndGetResults({ fixturePath });
+
+  const content = fs.readFileSync(distIndex, 'utf-8');
+  expect(content).toEqual('count: 1');
+});

tests/integration/plugins/index.test.ts

@@ -0,0 +1,6 @@
+{
+  "name": "plugins-test",
+  "version": "1.0.0",
+  "private": true,
+  "type": "module"
+}

tests/integration/plugins/package.json

@@ -0,0 +1,21 @@
+import fs from 'node:fs';
+import path from 'node:path';
+import type { RsbuildPlugin } from '@rsbuild/core';
+import { defineConfig } from '@rslib/core';
+
+let count = 0;
+export const distIndex = path.resolve(__dirname, 'dist/count.txt');
+
+const testPlugin: RsbuildPlugin = {
+  name: 'test',
+  setup(api) {
+    api.onAfterBuild(() => {
+      fs.writeFileSync(distIndex, `count: ${++count}`);
+    });
+  },
+};
+
+export default defineConfig({
+  lib: [{ format: 'esm' }, { format: 'cjs' }],
+  plugins: [testPlugin],
+});

tests/integration/plugins/rslib.config.ts

@@ -0,0 +1 @@
+export const test = 'hello';