Skip to content

Conversation

@fi3ework
Copy link
Member

Summary

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit d90cccc
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67089f52cfe1bf00084ad7a3
😎 Deploy Preview https://deploy-preview-273--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #273 will not alter performance

Comparing 0010 (7ce9c35) with main (eceb8b9)

Summary

✅ 3 untouched benchmarks

@fi3ework
Copy link
Member Author

We need to speed up CI, especially benchmark. Considering disable dts when building, we need to pass inlined config to merge with the file config first.

@Timeless0911
Copy link
Contributor

The lockfile change seems a little extra, pnpm update may cause resolution again.

@fi3ework fi3ework force-pushed the 0010 branch 2 times, most recently from d36af8f to d90cccc Compare October 11, 2024 03:45
@fi3ework
Copy link
Member Author

fi3ework commented Oct 11, 2024

Reverted part of the lockfile. Rspress is still using legacy version Rsbuild, so there are multiple Rspack inside monorepo.

@Timeless0911 Timeless0911 enabled auto-merge (squash) October 11, 2024 05:30
@Timeless0911 Timeless0911 merged commit 9d89dfc into main Oct 11, 2024
16 checks passed
@Timeless0911 Timeless0911 deleted the 0010 branch October 11, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants