Skip to content

Conversation

@fi3ework
Copy link
Member

Summary

This PR partially revert #302. After #302, we can't execute npx rslib build under any integrations tests cases.

This PR doesn't revert the goal of #302, just remove the workspaces field of the root package.json which is the monorepo field for npm(https://docs.npmjs.com/cli/v7/using-npm/workspaces), this also helps keep single source of truth of the monorepo definition (pnpm-workspace.yaml).

changesets uses https://github.com/Thinkmill/manypkg to find packages in a monorepo under the hood so it could correct resolve pnpm-workspace.yaml. check-dependency-version-consistency could also read it https://github.com/bmish/check-dependency-version-consistency#usage.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@fi3ework fi3ework requested a review from Timeless0911 October 17, 2024 15:26
@netlify
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 932b8bb
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67112cedfa894d0008175117
😎 Deploy Preview https://deploy-preview-306--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Learned

@Timeless0911 Timeless0911 enabled auto-merge (squash) October 17, 2024 15:33
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #306 will improve performances by 12.81%

Comparing revet (932b8bb) with main (f9f1751)

Summary

⚡ 1 improvements
✅ 3 untouched benchmarks

Benchmarks breakdown

Benchmark main revet Change
examples/react-component-bundle-false 325.7 ms 288.7 ms +12.81%

@Timeless0911 Timeless0911 merged commit 760968b into main Oct 17, 2024
18 checks passed
@Timeless0911 Timeless0911 deleted the revet branch October 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants